From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C0502BDC03 for ; Fri, 19 Dec 2025 03:53:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766116434; cv=none; b=uCYtxFvFP9p2+B+CijJlirZWHF5ZzkAWiczqLqZCTYUTVEpLOPokVX8UyFU6yrqH9GQWvWqjcFl8Vq3T0z/9CLyaBTM6GGwDySxoZI7S0Ow3iHI2Sh0l6GIOojmLC/wq8x/QFq9Dk48dSDpZSquyZsXX2RgCwUMxnmJYH0kteBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766116434; c=relaxed/simple; bh=nCfhV3t3w0fDBZ86SZ2f5UYt0sbOmM5oEt/LOCV1HW4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e7fTOZAkrwSh/LqYR/9P/YIDobuG1iCRtE6ZaEBdjfEopSrwuBam48m8wreapWZW6GI/LjzPwNrSdg+talb8vkOJpjQtstYZuc2mp3ss8Qo3Ssc/wsfsXnVQKfuSxpMtk7ShibvJ1pt089HVbI2o7O5riWwTg5+WJShibfmT2CM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cCZjaWc1; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cCZjaWc1" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2a081c163b0so12810215ad.0 for ; Thu, 18 Dec 2025 19:53:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766116432; x=1766721232; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PKNOibSL1/cWKHhBQtnXUGps0akL1GNIAh6E4cPLko8=; b=cCZjaWc1R4JwB3IAFxYJEg8sRuhJCQ6qPTuB6WDCOb47OFHUPBve4lbtnxH1GS+hqb HowBcqxHnw4ZLp4RO7KeGJ5BT6sVt/Td24IW6BvuekBzXu3PB5DTZGKm1Plp7Xs+Q7MY 7o/yfgpR4lsI9TCApEMeMEUX31Vipoh1YV5UKlc+O0cKS+s1hXJB93SMQmZlojpmejyU GvyNUbEqvYPVVmKiXA0oXOVV1hu21qle+H+GhzGUeUfJpbI9EBCcxF7OdAXpxtcq/wj0 VrP6oVMS21hlZ6z1yTssCT+Nbhy+D/pMXp6ZnWrgJhVenjk88+PFlFHXgq79i9UzAgzD BR/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766116432; x=1766721232; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PKNOibSL1/cWKHhBQtnXUGps0akL1GNIAh6E4cPLko8=; b=pLcdmGDibw6eqfu27qrgIhU/RIkSxK15M47cku4IgMOWHL4GaElti5G9WYYBDVXCna M55pLhjQfe+njNPhJRWzqAci9j1YyvjpCmIF/WylKgINsiMBiO2DMVpRpuYHjw/JkALY 1OHFJv3ztWjLQzE6bVWLZy/X2BOxmpMP+ugLEcQg7UispEe1X8pEUB8kjRKOb3M0ggUy jWVt6XJsrd5Osl+3OiI1ljpaLAPo0jPlLBi7sR5mnTdZLBihsuzkxMQDWt7Fl3930jvC dQF+myfdCJhtaSOakVXSZmZyw9L6oSB7c1lRd5XAlRMCMczRxwOe9JrTpQG8L2v3ZeLJ j6DA== X-Forwarded-Encrypted: i=1; AJvYcCUr8fHm1Q+uzytrquftbnCKo2OpKXY9fAk8KutRuDy9nKoo1w+Qtxh01CC5EbY4eX1HcRRQfgM3qJz+w5s=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq0Zq338TJ4PSapFwFEk9bQ6UPGYkDQV3WJFrjrLmlEdeA88vV XaIz/2c5Fq4dfoH5cygdOkx0OMxRZ34Uku2+NPzdUeSty6TrZ6vtyD8EeR3MXDw22sLV8w== X-Gm-Gg: AY/fxX7Lli0Qgty29qqUZsbRgCm2+E8nZL683htin0mNbNRYTbUOmeCCXnb9XMVUd+u r7JRXbP01GxJ/ftWgt17pPPDyr4PC+02lBsSIRh8hs3uhSbOJ5FMmhKHuZkNT+5TRkUBnOnKNuJ 2jk9EtSJ4VE9dkcamJgsiCL4oeLMzIJJDaBHkyk6UB6zWg3kWD/dUvDxFQh6wWjGU+m8wpMc+Ge wwviqDOVbaHPdfo0wtrWFC4UQnzG1th+GmIDT8Li0TdPTuhlE7Nl1xHzH28hsZut4SkzAmNrN3r mtGk2VB/SH5gViyNeNgPWke3wQU4tM+iYGngVn+l7mtJHzkt91CX1sqaHxXn5eFKyUC2ZNZuUuG Tjwvu9CTfHrx2P4ssy2/qG4aYQOSO0ZKREb5HA/ri4TWlLLgWD7866B9ns9g/QsJMIVvO/Qe9DC trwda2x6Ymyw== X-Google-Smtp-Source: AGHT+IEJYyJNSB3Ukzqrx3Oaw5wAgD+IMqeB5MdBvVM8lj03fHxXJGocNZ4Q2zrJZ+PSFeJR4jFMuQ== X-Received: by 2002:a17:903:2348:b0:2a1:2b5f:d16b with SMTP id d9443c01a7336-2a2f28367e7mr12961555ad.31.1766116431728; Thu, 18 Dec 2025 19:53:51 -0800 (PST) Received: from wanpengli.. ([175.170.92.22]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2a2f3d4d36esm7368135ad.63.2025.12.18.19.53.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Dec 2025 19:53:51 -0800 (PST) From: Wanpeng Li To: Peter Zijlstra , Ingo Molnar , Thomas Gleixner , Paolo Bonzini , Sean Christopherson Cc: K Prateek Nayak , Christian Borntraeger , Steven Rostedt , Vincent Guittot , Juri Lelli , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Wanpeng Li Subject: [PATCH v2 3/9] sched/fair: Add cgroup LCA finder for hierarchical yield Date: Fri, 19 Dec 2025 11:53:27 +0800 Message-ID: <20251219035334.39790-4-kernellwp@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251219035334.39790-1-kernellwp@gmail.com> References: <20251219035334.39790-1-kernellwp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Wanpeng Li Implement yield_deboost_find_lca() to locate the lowest common ancestor (LCA) in the cgroup hierarchy for EEVDF-aware yield operations. The LCA represents the appropriate hierarchy level where vruntime adjustments should be applied to ensure fairness is maintained across cgroup boundaries. This is critical for virtualization workloads where vCPUs may be organized in nested cgroups. Key aspects: - For CONFIG_FAIR_GROUP_SCHED: Walk up both entity hierarchies by aligning depths, then ascending together until common cfs_rq found - For flat hierarchy: Simply verify both entities share the same cfs_rq - Validate that meaningful contention exists (h_nr_queued > 1) - Ensure yielding entity has non-zero slice for safe penalty calculation Function operates under rq->lock protection. Static helper integrated in subsequent patches. v1 -> v2: - Change nr_queued to h_nr_queued for accurate hierarchical task counting that includes tasks in child cgroups - Improve comments to clarify the LCA algorithm Signed-off-by: Wanpeng Li --- kernel/sched/fair.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 2f327882bf4d..39dbdd222687 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9102,6 +9102,36 @@ yield_deboost_validate_tasks(struct rq *rq, struct task_struct *p_target) return p_yielding; } +/* + * Find the lowest common ancestor (LCA) in the cgroup hierarchy. + * Uses find_matching_se() to locate sibling entities at the same level, + * then returns their common cfs_rq for vruntime adjustments. + * + * Returns true if a valid LCA with meaningful contention (h_nr_queued > 1) + * is found, storing the LCA entities and common cfs_rq in output parameters. + */ +static bool __maybe_unused +yield_deboost_find_lca(struct sched_entity *se_y, struct sched_entity *se_t, + struct sched_entity **se_y_lca_out, + struct sched_entity **se_t_lca_out, + struct cfs_rq **cfs_rq_out) +{ + struct sched_entity *se_y_lca = se_y; + struct sched_entity *se_t_lca = se_t; + struct cfs_rq *cfs_rq; + + find_matching_se(&se_y_lca, &se_t_lca); + + cfs_rq = cfs_rq_of(se_y_lca); + if (cfs_rq->h_nr_queued <= 1) + return false; + + *se_y_lca_out = se_y_lca; + *se_t_lca_out = se_t_lca; + *cfs_rq_out = cfs_rq; + return true; +} + /* * sched_yield() is very simple */ -- 2.43.0