Re: [PATCH v5 15/19] mm, swap: add folio to swap cache directly on allocation

Kairui Song
2025-12-22T02:42:50Z

On Sat, Dec 20, 2025 at 12:12 PM Baoquan He <bhe@redhat.com> wrote:
>
> On 12/20/25 at 03:43am, Kairui Song wrote:
> > From: Kairui Song <kasong@tencent.com>
> >
> > The allocator uses SWAP_HAS_CACHE to pin a swap slot upon allocation.
> > SWAP_HAS_CACHE is being deprecated as it caused a lot of confusion.
> > This pinning usage here can be dropped by adding the folio to swap
> > cache directly on allocation.
> >
> > All swap allocations are folio-based now (except for hibernation), so
> > the swap allocator can always take the folio as the parameter. And now
> > both swap cache (swap table) and swap map are protected by the cluster
> > lock, scanning the map and inserting the folio can be done in the same
> > critical section. This eliminates the time window that a slot is pinned
> > by SWAP_HAS_CACHE, but it has no cache, and avoids touching the lock
> > multiple times.
> >
> > This is both a cleanup and an optimization.
> >
> > Signed-off-by: Kairui Song <kasong@tencent.com>
> > ---
> > include/linux/swap.h | 5 --
> > mm/swap.h | 10 +---
> > mm/swap_state.c | 58 +++++++++++--------
> > mm/swapfile.c | 161 ++++++++++++++++++++++-----------------------------
> > 4 files changed, 105 insertions(+), 129 deletions(-)
> >
> > diff --git a/include/linux/swap.h b/include/linux/swap.h
> > index aaa868f60b9c..517d24e96d8c 100644
> > --- a/include/linux/swap.h
> > +++ b/include/linux/swap.h
> > @@ -452,7 +452,6 @@ static inline long get_nr_swap_pages(void)
> > }
> >
> > extern void si_swapinfo(struct sysinfo *);
> > -void put_swap_folio(struct folio *folio, swp_entry_t entry);
> > extern int add_swap_count_continuation(swp_entry_t, gfp_t);
> > int swap_type_of(dev_t device, sector_t offset);
> > int find_first_swap(dev_t *device);
> > @@ -533,10 +532,6 @@ static inline void swap_put_entries_direct(swp_entry_t ent, int nr)
> > {
> > }
> >
> > -static inline void put_swap_folio(struct folio *folio, swp_entry_t swp)
> > -{
> > -}
> > -
> > static inline int __swap_count(swp_entry_t entry)
> > {
> > return 0;
> > diff --git a/mm/swap.h b/mm/swap.h
> > index 9ed12936b889..ec1ef7d0c35b 100644
> > --- a/mm/swap.h
> > +++ b/mm/swap.h
> > @@ -277,13 +277,13 @@ void __swapcache_clear_cached(struct swap_info_struct *si,
> > */
> > struct folio *swap_cache_get_folio(swp_entry_t entry);
> > void *swap_cache_get_shadow(swp_entry_t entry);
> > -int swap_cache_add_folio(struct folio *folio, swp_entry_t entry,
> > - void **shadow, bool alloc);
> > void swap_cache_del_folio(struct folio *folio);
> > struct folio *swap_cache_alloc_folio(swp_entry_t entry, gfp_t gfp_flags,
> > struct mempolicy *mpol, pgoff_t ilx,
> > bool *alloced);
> > /* Below helpers require the caller to lock and pass in the swap cluster. */
> > +void __swap_cache_add_folio(struct swap_cluster_info *ci,
> > + struct folio *folio, swp_entry_t entry);
> > void __swap_cache_del_folio(struct swap_cluster_info *ci,
> > struct folio *folio, swp_entry_t entry, void *shadow);
> > void __swap_cache_replace_folio(struct swap_cluster_info *ci,
> > @@ -459,12 +459,6 @@ static inline void *swap_cache_get_shadow(swp_entry_t entry)
> > return NULL;
> > }
> >
> > -static inline int swap_cache_add_folio(struct folio *folio, swp_entry_t entry,
> > - void **shadow, bool alloc)
> > -{
> > - return -ENOENT;
> > -}
> > -
> > static inline void swap_cache_del_folio(struct folio *folio)
> > {
> > }
> > diff --git a/mm/swap_state.c b/mm/swap_state.c
> > index 327c051d7cd0..29fa8d313a79 100644
> > --- a/mm/swap_state.c
> > +++ b/mm/swap_state.c
> > @@ -122,35 +122,56 @@ void *swap_cache_get_shadow(swp_entry_t entry)
> > return NULL;
> > }
> >
> > +void __swap_cache_add_folio(struct swap_cluster_info *ci,
> > + struct folio *folio, swp_entry_t entry)
> > +{
> > + unsigned long new_tb;
> > + unsigned int ci_start, ci_off, ci_end;
> > + unsigned long nr_pages = folio_nr_pages(folio);
> > +
> > + VM_WARN_ON_ONCE_FOLIO(!folio_test_locked(folio), folio);
> > + VM_WARN_ON_ONCE_FOLIO(folio_test_swapcache(folio), folio);
> > + VM_WARN_ON_ONCE_FOLIO(!folio_test_swapbacked(folio), folio);
> > +
> > + new_tb = folio_to_swp_tb(folio);
> > + ci_start = swp_cluster_offset(entry);
> > + ci_off = ci_start;
> > + ci_end = ci_start + nr_pages;
> > + do {
> > + VM_WARN_ON_ONCE(swp_tb_is_folio(__swap_table_get(ci, ci_off)));
> > + __swap_table_set(ci, ci_off, new_tb);
> > + } while (++ci_off < ci_end);
> > +
> > + folio_ref_add(folio, nr_pages);
> > + folio_set_swapcache(folio);
> > + folio->swap = entry;
> > +
> > + node_stat_mod_folio(folio, NR_FILE_PAGES, nr_pages);
> > + lruvec_stat_mod_folio(folio, NR_SWAPCACHE, nr_pages);
> > +}
> > +
> > /**
> > * swap_cache_add_folio - Add a folio into the swap cache.
>
> With my understanding, __swap_cache_add_folio() is the pure
> functionality of adding a folio into swap cache. While

Hi Baoquan, thanks for the review and suggestion!

> swap_cache_add_folio() is specifically adding a folio into swap cache
> during swap in path. Not sure if we can rename them to reflect this
> clearer. At least from the functiona name and below kernel doc we can't
> feel that. Maybe:
> __swap_cache_add_folio() -> swap_cache_add_folio()

The `__` prefix should stay, I think. This function requires the
caller to lock the swap cluster.

> swap_cache_add_folio() -> swap_cache_add_swapin_folio()

Indeed, my plan is that `swap_cache_add_folio` will be gone soon, we
should always call `swap_cache_alloc_folio` instead to do the swap
folio allocation in a unified way, and just remove this.

Currently we can't do that because shmem and anon have different
routines for swapin folio allocation. Having a unified
`swap_cache_alloc_folio` will provide better swapin fallout control
and cleaner cgroup charging to avoid thrashing, etc.

Also this helper is currently inexplicitly used by zswap writeback
too, so adding the swapin keyword seems not accurate.