From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2339D2FD69F for ; Sat, 20 Dec 2025 10:09:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766225368; cv=none; b=U/rnbeqfCr54Xtp+fm86JiojGkxETY9gELw9r7bA6jtL8lMTXoJ2Zthtfd9Cu4rpckLzkCpJEw/8StsEC5v+A3+oJJQDe6EJd0E3WR63YpJwjyi7G1tcmGfuHNzvHF8bhGQ1XSrNNqLobuEMEU7qSrCORzYWX7DEcMTq6BePb/A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766225368; c=relaxed/simple; bh=T286e3Yg0Q0S75/6v0G/eny0pp2qOlq56+De2M6BuMo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OGy4fUldCoRA1g0agIRSn9QakCADVEYx9bSXMhmO6DwDH4CgRKMAVDdUVVrqMA44wYlFvSPMfHfornhAGa2ihyLaQgXeBtiLMFv0LvCW+hfDiSEgoVIHHPe5sPXavX/upEai6tlSqfQH54erDGVt9ZX7gR6ImGeq+tJrQa1bw0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XJX2zX4f; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XJX2zX4f" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-4308d81fdf6so1201070f8f.2 for ; Sat, 20 Dec 2025 02:09:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766225365; x=1766830165; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YltJZVr5NuyQpfEZwyZbwRl9KappV6MIekKgUZHqamY=; b=XJX2zX4fYdPNyfKBIoOBvFW7369gvcKzBVaLpKWROIFBLLlfr5HStNIW58IUJZRXqJ D9TDtT4sYYmVICg+2vDLUaKKCnA2zW2rUk3UgG8TOpOO66ef47GGbs7yTKc1nJa+qC6i 0IpcO9Asz3yS3H8OelXoUC0tSJN0mvHX7a/FFopHA39cAgv3uxV0HRSo2ss9VrbfZaKq eeU4oZ9GLLBq26on/SgXOuujLWaq/i8EU1wIUrIAVYKcU3fnWv9KyUn9RovgA8wxtAkF DTKbpkJvDDESa8d08tx02q1u4dnRM+pW5px0EkaCc4nr6S0YC/nWHpmuh/S+o/lDXXA3 jDEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766225365; x=1766830165; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YltJZVr5NuyQpfEZwyZbwRl9KappV6MIekKgUZHqamY=; b=n+c4E3+DCHl/d5inavbr7CqAyV2a/M0raRx1qhDaGxMPrDZOTd+H6GfhrLGEAJ3MIG hpqhgJCuRvdgYxIQnsGW2hExy2CUd1FQp5+h/T4O14GbipjZzpZTETuwaO3eDqvfNTpB aO4KAGdgQiPrRGVvR0B58KNVdieYgY9Rf7yV+fHyvI1DIxslsV1q0JSUqeLzbxeqbh3t f+IDk7TD+fUVXM+FfSk8CGGE3GuVJ7BAvrswOVkpPz6uW9+GsE/lqEZtOR4SNz5GxMPs eeBMBw4e/T7+Kol9GGlleTaT+QG4BCcJnD6bBolzEicw5ToS7cDz8ZKycyx/TiqHrVx/ ovsA== X-Forwarded-Encrypted: i=1; AJvYcCWwdgLHMGxoziJaBrTD+sdbzZxYtvC6DIVrDXmAJjXwD19YQ19veDMj7q1nXXZfPKrlctRrQWh+AkZ+b2w=@vger.kernel.org X-Gm-Message-State: AOJu0YzPeWbo5AY6yUROvV2IpQhR2dbCiM0UgREIz676zPHfT9HSCXX7 U+nABPcx1DmD6JQ6KM/3UXcvFa/pewwSviedKb3vYfU3dXnVZkjSA5mQ X-Gm-Gg: AY/fxX6N6eZ8Jx047zEx+nKpAbvGqU27VSQa2rMRe6BKtcItLgTArv9F4mEaWQXhEBn hLFmvwa5QezPwhH0aAMVEG5Linf2MJ2KXQkia4atNHdMCXGbkZEA3ooqe8k6RdWsvYeuyFgvGls rwJiHukraAcjG5TBI27KcG4Wq7BN5G9rmmCcutSKhaMDbib5ftQgyhz6J4lefaLaRA6758m8sgF S8QLyWbQFFxd2UqtbElqR27oZkLWPpipM5CfzjY055Jh7VAbGPKx644UmNpUkCxpMp0Qtdmny3W 06vaYFV6Lfsc3Nn5fbI6N1Q10fR4nkh7ej9FNTZv6YXWTXW7R1ztJ6ef7ZBvM/jMletgZ4tVnqU r68uHJCsHj+v8fI5aYmY004dfeXyf4xb+w8PuK6fVrXBDej37Yw6TB1D5YWdgSh1u4jT1EPq1kf ALtKFP7dQC2cTzkrddxcftb9DS1V/C9pLmiZFQmsorCRHB85Tj7x30 X-Google-Smtp-Source: AGHT+IEVS0YXlTRBLtbgj2BbSWCnRw75i1fGTOjJqia9uMJ4AbbjmPLtb4whaBSPbMoQAZnfFVwMxg== X-Received: by 2002:a05:6000:400f:b0:431:5ca:c1a9 with SMTP id ffacd0b85a97d-4324e4c9e82mr6668504f8f.23.1766225365164; Sat, 20 Dec 2025 02:09:25 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea22674sm10222429f8f.10.2025.12.20.02.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Dec 2025 02:09:24 -0800 (PST) Date: Sat, 20 Dec 2025 10:09:23 +0000 From: David Laight To: Preyas Cc: marvin24@gmx.de, gregkh@linuxfoundation.org, ac100@lists.launchpad.net, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: nvec: replace short udelay with usleep_range Message-ID: <20251220100923.2a3de6db@pumpkin> In-Reply-To: <20251220092229.16606-1-preyas17@zohomail.in> References: <20251220092229.16606-1-preyas17@zohomail.in> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 20 Dec 2025 09:22:29 +0000 Preyas wrote: > From: Preyas Sharma > > Signed-off-by: Preyas Sharma > --- > drivers/staging/nvec/nvec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c > index 263774e6a78c..6ffe5e8656d1 100644 > --- a/drivers/staging/nvec/nvec.c > +++ b/drivers/staging/nvec/nvec.c > @@ -648,7 +648,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) > break; > case 2: /* first byte after command */ > if (status == (I2C_SL_IRQ | RNW | RCVD)) { > - udelay(33); > + usleep_range(33, 66); Given its name the function looks like an ISR - where you can't sleep. Spinning isn't a good idea either.... David > if (nvec->rx->data[0] != 0x01) { > dev_err(nvec->dev, > "Read without prior read command\n");