From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A0D1D168BD for ; Sat, 20 Dec 2025 13:15:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766236524; cv=none; b=sywO5H6sa1lDUnO9C6tyLk0kW1MfNQtMzLx1ZKMY+5OJmu1sKYNIybmh8Lkoik2WE5gTTuYZebjohzt/5hHIV9BrXjFThvpkuXbr2EVwq/NGC9UUyQHZ5sOEQHlLiYmNa0FohFemWkUEeAE4Izdd10r6jGBYZi4nWtIfaqACQbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766236524; c=relaxed/simple; bh=7jK704Mqtj6QiA3VlfvZIt/Bxv6TMyGPOWrng6Upt2Q=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ctnaWJT6KDKZa50mlW/MK5En5PbDhuZ8OtS6jIqb8H8UAhDAKZZoTUvwcmVjuCyn3H81MDI6GkI26zYzYPWXp9GmB93Giwlwvas5OCOQykdFSr5pdXhm7E7wLkWAsJ9jGAV95txKLCNv6UFkEGx5EYHwMsySAj24t+A7SI42iHw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NIZB3bYY; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NIZB3bYY" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b79e7112398so427226866b.3 for ; Sat, 20 Dec 2025 05:15:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766236521; x=1766841321; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=uzN1iErmKRYMzjyS2Nnjlf728qTYKE6BOmNVmIqMOzw=; b=NIZB3bYYAfzL48VVDOlN04Q6CoFZpUvuqpK75q3iUwyW1nZX1r7UgFB+ytyEBzcH8W cs6SzJ72p4zNNJARKXBPTI0bn4Q6j8CTZkqFMeTSNQQ0AOfXOBwTzRuNJ6kg79FBI9NU kwQv7iea4CUvBkpsgZEp2f1M+cCoSXZqsZZmxicKGb+uXKOfzb1hspxEnEharrNX4jjq sOixQUrCXS8mwgMpvp16IskyofkfFK4bxKFH8byCKRg0oYmeOGMpM4w+/Ce9FfQW5b63 K5adDVOhWrdBwzJYrRDJ94kaByf6bQcHPgETgeuzai3YrvUQ7F0LCaM0MjLb+3lW2Lxs 1uSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766236521; x=1766841321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uzN1iErmKRYMzjyS2Nnjlf728qTYKE6BOmNVmIqMOzw=; b=b69jpSehJRXfB+DJFriFqd3Debn70hnoBJyMWNZnhr8iDZ4lW6IduG07zxOMRRVBS2 cLnWaNZTVQa96rU/LtH/IMz+OtgNOkSAzT1OMKuVBw/2E+4ArdTaf3iJaPG2K5SAdLLI 8/nIJRqkUN/dWTntkEDs/GulP6tgDlbwph862o4ND4aEAoqLgcxSU36RiAffKrUbgzzK CkzIZBq0Gplaxc/+EfOtNXJUZi/QgBVxVmSCEgUyXaFVG30OV4O2s01V8SyewmwxTG2L h/W9dYT+FUxzJAsXCZI2VXmhYFgJgBiLcDzV+YlzXrZbrx4Vu9F88qs46qK6rZCZqrLv fx4A== X-Forwarded-Encrypted: i=1; AJvYcCUvYZBUCTxYrSlPBJc+HIGWgxtShhhoW+pE7bBaAvmhPFWnOo1w/ng246VMrr+LROsf+o3X2BfXpN/eo1U=@vger.kernel.org X-Gm-Message-State: AOJu0YxDajXVrbCddZ/3SJEOayM97PQZu+CSsz6Ipkmh++sVgumqnSnr 73wHYzQs64ohaccdMwK1rEFHsMFhFAwYXn4ZtvkBdE5m/X+R+c6yLmH6 X-Gm-Gg: AY/fxX7DQY42ELbdATecJ95FiX6dV3hbD2N90779z1g6143eaHmzO5uBcKUabuaCrTP 9IfKQAL9/y2ZW3hD+AdvK1+eHTh+QmGwA5JXFnxJv0WQFBVtO22TIcVS7Jev1PVqn9yPkFtdSxk fUkBvvGapv3jb69FgbYcD717ii67tgXfsmX3NfIShAV8JNdE6AMmSi1b8SU6OKaGQtfVO0ymUPn ErhpcZZq7bEwlNI7o8uRByqU7QD0hNtkxvKY1z8+tyNTi19G/Y0/hLHJ1ai4phN1zJl5tJ3EEK6 S8DHA1EZ6GQHLE8uQWthwtQ4CvIcStJmQqFGYFdrWiH93n664YUXUPQDbYGqL6aOTEMCrqmAJMe JIFocErT6aEGQMKCKkwwtTGcpdgeza1xunASUtybp2w7h2f96k0BEAr0hxfpCRU5R3mmXvRywgf JS0sPkeh7LXZKpGnEo3JPWryx6ba0YGgUdmg== X-Google-Smtp-Source: AGHT+IGYWZU+cwyFaqBHNyGQOpa3FT4HZheHu9DiPgKQ2wU4Bwi/x1G+SZAxq1LghZc3C6cndsVwig== X-Received: by 2002:a17:907:7ea2:b0:b76:f090:777b with SMTP id a640c23a62f3a-b8036f13dfbmr528837866b.22.1766236516230; Sat, 20 Dec 2025 05:15:16 -0800 (PST) Received: from foxbook (bfd193.neoplus.adsl.tpnet.pl. [83.28.41.193]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f511fesm509765566b.65.2025.12.20.05.15.14 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sat, 20 Dec 2025 05:15:15 -0800 (PST) Date: Sat, 20 Dec 2025 14:15:10 +0100 From: Michal Pecio To: =?UTF-8?B?6IOh6L+e5Yuk?= Cc: Mathias Nyman , Mathias Nyman , Greg Kroah-Hartman , Sarah Sharp , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: xhci: check Null pointer in segment alloc Message-ID: <20251220141510.1bc1ef19.michal.pecio@gmail.com> In-Reply-To: References: <4935bdf5-4d36-45c3-9bcd-9d14606dd54e@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi, On Fri, 19 Dec 2025 15:53:08 +0000, =E8=83=A1=E8=BF=9E=E5=8B=A4 wrote: > [ 4021.987665][ T332] Call trace: > [ 4021.987668][ T332] dma_pool_alloc+0x3c/0x248 > [ 4021.987676][ T332] xhci_segment_alloc+0x9c/0x184 > [ 4021.987682][ T332] xhci_alloc_segments_for_ring+0xcc/0x1cc > [ 4021.987688][ T332] xhci_ring_alloc+0xc4/0x1a8 > [ 4021.987693][ T332] xhci_endpoint_init+0x36c/0x4ac > [ 4021.987698][ T332] xhci_add_endpoint+0x18c/0x2a4 > [ 4021.987702][ T332] usb_hcd_alloc_bandwidth+0x384/0x3e4 > [ 4021.987711][ T332] usb_set_interface+0x144/0x510 > [ 4021.987716][ T332] usb_reset_and_verify_device+0x248/0x5fc > [ 4021.987723][ T332] usb_port_resume+0x580/0x700 > [ 4021.987730][ T332] usb_generic_driver_resume+0x24/0x5c > [ 4021.987735][ T332] usb_resume_both+0x104/0x32c > [ 4021.987740][ T332] usb_runtime_resume+0x18/0x28 > [ 4021.987746][ T332] __rpm_callback+0x94/0x3d4 > [ 4021.987754][ T332] rpm_resume+0x3f8/0x5fc > [ 4021.987762][ T332] rpm_resume+0x1fc/0x5fc > [ 4021.987769][ T332] __pm_runtime_resume+0x4c/0x90 > [ 4021.987777][ T332] usb_autopm_get_interface+0x20/0x4c > [ 4021.987783][ T332] snd_usb_autoresume+0x68/0x124 > [ 4021.987792][ T332] suspend_resume_store+0x2a0/0x2b4 [dwc3_msm a4b799= 7a2e35cfe1a4a429762003b34dd4e85076] This looks like some out of tree driver tries to resume a sound device, and apparently it's doing it while xhci_hcd isn't ready, perhaps during the power_lost branch in xhci_resume() after full system suspend. I suppose dynamic debug could show better what's going on: echo 'module usbcore +p' >/proc/dynamic_debug/control echo 'module xhci_hcd +p' >/proc/dynamic_debug/control If my guess is right then USB core is failing to prevent device resume during HC resume, but IDK whether it's supposed to prevent that or if the out of tree driver simply shouldn't be trying such things. Regards, Michal