From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65A4C150997 for ; Sat, 20 Dec 2025 16:46:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766249191; cv=none; b=jyhkG/kJczcdW/DWTQNkDzKqEQ6Pkpnw/XLx3I6gXzv0FsijmahgAXmhTYP+T5PGEBD465wjLwTYw5tt3Lhrh3VCJhcAuleAD5PgY5vP6JCl1G3/AIIOcxIrrEBzCBr21tiWzg4bHE/85KTzX/TKuYfFrYVrDP9spLfYcCg+y4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766249191; c=relaxed/simple; bh=QEkg/gYIMGsgcTI8cfHodqbEwqtmmBSR03OAXL50yrI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SBg0dxZW8YdZS7NNDOCKXqb+ykTlcwDqqQTVWgUQ+SlvvNh76A7JaVbEy1yU2ajbMBTdCyid2BRLKKC1+n5KBtnHXP1CQr3cxHRb9SFeNtW0dqAi3WXH6QKj7mL3X+Ru+ZXJRdlfLSFXV94w0hkk16LAlBLW/urMEFZ1K/wP7KA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TBn99ai6; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TBn99ai6" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7baa28f553dso40623b3a.3 for ; Sat, 20 Dec 2025 08:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766249190; x=1766853990; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c7EP/tpx9GWxii+AYAC7WJOYO3DbJ6aXW68IWJvk5iw=; b=TBn99ai6ibwitAU8mBf+ovkRIQbbscKC7TObUF9B9B9CbEYFtwgQuSa+H66DPW2Z0G FjZEoq1OST/m+eMp1rp4fYGoXB7TtvjbLp+V2lVj+Di7adHS/O4bOwG/mAGYoMynKdiv lQzZHX6rxoZk8oBAQHdK3Fi6ojLt/gAooKHiXCqcdq407TPo/LXXGsHlMdJp5KFRgQKM YW+GkXhG3qRh6kG5DGSKMOHzB8KN18Dcky/G15WXNQd74QEkXF6EiSNu8Oxn4cSXVd0B T8Xk/Tg2yT4sSCwCAr6GJGut8619R2PJEUM8FTdqJ/aOEYqzH3Ksp49/2Wq66LaRC0TY kHBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766249190; x=1766853990; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=c7EP/tpx9GWxii+AYAC7WJOYO3DbJ6aXW68IWJvk5iw=; b=hSEBtAnrsICwFOPEk3K6sNTtrwbWJmk7HWChXVK4srwwilbrrKExo98reCVOENI6AG TBZknnAuoZXj83zBN2kXcgl6OPGVulJMwCxJ7pTNKUPtrOFV92isgt1OVkz6x+g7B8WP VACjt0I5OsX9e8waEw0eu3ytBMafrpgQ5w6LuUVPwfsiPiEOt4H4Lvu8kBTlZD61Pv0r sBK0ZWc9UD70PHrHKVIV0Z79ZWUyt2AduiQIlxAZuzz9pG0D0Tl4E1cj8Fn4syRYlw1u 5foUWRUq7oTuVY7EAUM5cytAyDHgvI/LSn+hgCUoEKzdV1oQ1eZdGQVWYf4fnEj2hl7Q G1YQ== X-Forwarded-Encrypted: i=1; AJvYcCUm/R4wp/6Vx9v6eZnNulyoYNnUzKcIalQ7E6OZsG7Wd+xpXZTXCfbhoAibN+LHAIkxAd0Y7oRRnfN1Jyw=@vger.kernel.org X-Gm-Message-State: AOJu0YwwL3qTRJjx7tVKWSo0tYI5YDqXaNZrrMEmmoRzGtiZKMeh+oDq Xx0LVBV8FD5xcxYUx+ZrINOh5Vf5Ooo9MXhpQxCSsi3CF3/rbtNWu6kf X-Gm-Gg: AY/fxX7l4aPnALj2MT3Uyxm/+RlgGAVePpbHUburGyEPBdC9IXh8WMCoaEc7KQTdhcO Zyh95IgnliwAiOKi23b/8EZWwpmppIfDgqCxzAORrlJFivG3Sj6h5AWRr58tNRywGDBA5G79NhV 9uYyEFIhkHAQLRSG/ApL1ZEsQcqPT7qNslEw6Hw85GbIxEH7jh36ps3euQCeJ/ztKPOo8bQwcrv xV/G9PgidTW09+hUTw2dzo1XUHTeTxYqLpBc1fz5BQ3MkgCRhAOGBhOhtazHF2RlkQ865svpljs k3VrsiTS9x/SeHkK5UeXGIvV9qESHVSwUGIGqi/mh0q+kCGTUoR96ZUQXfzG/1BLjoFYTuAzxIo 8WPHak46HBQIPo8N79L1XIDwKofnhQ6995iIMZGMwkyrLYRUY7aC9CsrIBaWFV6nI83GhNFFJA9 DC6Ozragnh6U4= X-Google-Smtp-Source: AGHT+IGdbB/Ckh95eIe2oO+uZBQ1VnyCdlca/UmZcXPpvQIRCA3Pnsjbf93FSIDDgBGYnoV1NiUdeg== X-Received: by 2002:a05:6a00:a89:b0:776:19f6:5d3d with SMTP id d2e1a72fcca58-7ff6430c36bmr4406942b3a.2.1766249189699; Sat, 20 Dec 2025 08:46:29 -0800 (PST) Received: from rock-5b.. ([45.32.55.39]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7dfab841sm5623899b3a.35.2025.12.20.08.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Dec 2025 08:46:29 -0800 (PST) From: Jianfeng Liu To: detlev.casanova@collabora.com Cc: corbet@lwn.net, daniel.almeida@collabora.com, didi.debian@cknow.org, ezequiel@vanguardiasur.com.ar, hansg@kernel.org, heiko@sntech.de, hverkuil@kernel.org, james.cowgill@blaize.com, jonas@kwiboo.se, kernel@collabora.com, laurent.pinchart@ideasonboard.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, mchehab@kernel.org, nicolas.dufresne@collabora.com, opensource206@gmail.com, ribalda@chromium.org, sakari.ailus@linux.intel.com, yunkec@google.com Subject: Re: [PATCH v7 14/17] media: rkvdec: Add H264 support for the VDPU381 variant Date: Sun, 21 Dec 2025 00:46:04 +0800 Message-ID: <20251220164604.10052-1-liujianfeng1994@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251218232829.337811-15-detlev.casanova@collabora.com> References: <20251218232829.337811-15-detlev.casanova@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, On Thu, 18 Dec 2025 18:28:24 -0500, Detlev Casanova wrote: >+static int rkvdec_h264_start(struct rkvdec_ctx *ctx) >+{ >+ struct rkvdec_dev *rkvdec = ctx->dev; >+ struct rkvdec_h264_priv_tbl *priv_tbl; >+ struct rkvdec_h264_ctx *h264_ctx; >+ struct v4l2_ctrl *ctrl; >+ int ret; >+ >+ ctrl = v4l2_ctrl_find(&ctx->ctrl_hdl, >+ V4L2_CID_STATELESS_H264_SPS); >+ if (!ctrl) >+ return -EINVAL; >+ >+ h264_ctx = kzalloc(sizeof(*h264_ctx), GFP_KERNEL); >+ if (!h264_ctx) >+ return -ENOMEM; I can see the sps validation is removed: ret = rkvdec_h264_validate_sps(ctx, ctrl->p_new.p_h264_sps); if (ret) return ret; This should fix decoding issue with chromium when minimum size of h264 decoder is lower than 32. While I find this issue is caused by chromium not following v4l2 stateless spec, and I think checking sps at start should be still necessary. I have sent a fix to chromium[1] and it should get merged later. [1] https://chromium-review.googlesource.com/c/chromium/src/+/7274555 Best regards, Jianfeng