From: Leo Yan <leo.yan@arm.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
Arnd Bergmann <arnd@arndb.de>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
Leo Yan <leo.yan@arm.com>
Subject: [PATCH v3 0/3] tools build: Fix arm64 unistd.h dependency
Date: Mon, 22 Dec 2025 18:06:45 +0000 [thread overview]
Message-ID: <20251222-perf_fix_syscall_header-v3-0-eb4a8b9dfe66@arm.com> (raw)
The perf build includes arm64's unistd.h, but its dependent header
unistd_64.h is missing.
As suggested by Arnd in [1]:
"I would suggest using the same method across all architectures:
either we figure out how to use the generated headers on all of them
(including x86, which uses yet another method), or we just stick with
the old asm-generic/unistd.h copy and use that on arm64 as well."
A dynamic approach (e.g., make headers_install) may be explored later to
generate headers for tools, but that will need consensus from the tools
maintainers. In the meantime, this series provides a quick fix by using
the asm-generic/unistd.h copy for arm64.
[1] https://lore.kernel.org/linux-arm-kernel/20251222173653.GF9788@e132581.arm.com/T/#m69a051aae5e53a65f9b10e1d13f67b3e92f4bbc7
Signed-off-by: Leo Yan <leo.yan@arm.com>
---
Changes in v3:
- Changed to include asm-generic/unistd.h copy (Arnd).
- Removed check due to divergence between the kernel and tools.
- Link to v2: https://lore.kernel.org/r/20251210-perf_fix_syscall_header-v2-0-b18b6016e0ea@arm.com
Changes in v2:
- Added a consistency check (Ian).
- Rebased on the latest perf-tools-next.
- Link to v1: https://lore.kernel.org/r/20251204-perf_fix_syscall_header-v1-0-b8e27f74ed6a@arm.com
---
Leo Yan (3):
tools headers: Go back to include asm-generic/unistd.h for arm64
Revert "perf tools: Fix arm64 build by generating unistd_64.h"
tools headers: Don't check arm64's unistd.h
tools/arch/arm64/include/uapi/asm/unistd.h | 24 +++++++++++++++++++++++-
tools/lib/perf/Makefile | 14 ++------------
tools/perf/Makefile.config | 1 -
tools/perf/check-headers.sh | 1 -
4 files changed, 25 insertions(+), 15 deletions(-)
---
base-commit: cb015814f8b6eebcbb8e46e111d108892c5e6821
change-id: 20251203-perf_fix_syscall_header-e280fa931d44
Best regards,
--
Leo Yan <leo.yan@arm.com>
next reply other threads:[~2025-12-22 18:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 18:06 Leo Yan [this message]
2025-12-22 18:06 ` [PATCH v3 1/3] tools headers: Go back to include asm-generic/unistd.h for arm64 Leo Yan
2025-12-24 13:47 ` James Clark
2026-01-07 14:48 ` Leo Yan
2026-01-07 15:21 ` Arnd Bergmann
2026-01-07 17:14 ` Leo Yan
2025-12-22 18:06 ` [PATCH v3 2/3] Revert "perf tools: Fix arm64 build by generating unistd_64.h" Leo Yan
2025-12-22 18:06 ` [PATCH v3 3/3] tools headers: Don't check arm64's unistd.h Leo Yan
2025-12-24 13:51 ` James Clark
2026-01-07 15:05 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251222-perf_fix_syscall_header-v3-0-eb4a8b9dfe66@arm.com \
--to=leo.yan@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox