From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF5630B512 for ; Mon, 22 Dec 2025 08:39:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766392762; cv=none; b=HIpDfTpxlviBZr9jnwK0IkVvZPOSvVuJA8edd27ndb/rd73czv8/Y07XuHn2UsFkp9MBSLhMkK4LTkhqhkm8yGlYalM8clygsJEBNkxxN7bhvs7jXQuniQ6ST4d629daWOyEpGU64XZXgm47yYkBbu+jgnkbuWqIempniTVzdFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766392762; c=relaxed/simple; bh=auSg26CfZlSSNZjKfr7BRpVNy+ZYjFMpxMGU641YRCw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L4OoZhEOV/CCKm8cSecKILFH/+h7FCK5XExolV4DhPnXIV7ddI44RYX8ZAD8OT3er3C9NqOL6c4p0Kga8E5bKxqRI3j3W8/my3PKIurbuIxEoDfhezpl4Wl6LZpgvM/wQJdoQ6RIdSfpDtE0K0JXKuClw+fu3braVQIpvkfVYRE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Se2KeJ0K; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=gGbGwijH; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Se2KeJ0K"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="gGbGwijH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766392759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w8RM3/o6FB83AIG5gcDlEP7+b/8hOvjggWFz+DBBFz0=; b=Se2KeJ0KlEOMYkVHEcgNzY4ctmMDAkq5NQFnR6xxzIxlckdkfAczt1NaZRSUqEQwWg5lPh Y3Zhl5hIhuoVcxltbl5T9FCbIJMIhVxRFVX8Mbv7L8mrsfl6Pq0VtTjWz9m7c0++9VCaV+ gWaugJxcdd8csCflEBh1yijcsS0p9fU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-92-nQOyI7L6Mz25OJO-3dNs3g-1; Mon, 22 Dec 2025 03:39:17 -0500 X-MC-Unique: nQOyI7L6Mz25OJO-3dNs3g-1 X-Mimecast-MFC-AGG-ID: nQOyI7L6Mz25OJO-3dNs3g_1766392756 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-430f5dcd4cdso2029473f8f.2 for ; Mon, 22 Dec 2025 00:39:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766392756; x=1766997556; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=w8RM3/o6FB83AIG5gcDlEP7+b/8hOvjggWFz+DBBFz0=; b=gGbGwijHwV3DYbcz4wBv3/aIbXs9G3lN/MjWhgBa0QyrCARRjA/hGdF4jblAPClmOB WzVjx/REY0wfSa2pazJPO9t6rdCoFSvW1Ht97zBUO8UlHBo6RqCTaIE/XAKT1JjEcM8Q WUIH6d/9O6xYCWc97vA0yvP4IekGDFtnbKtkHOr/BSK4gpnZsBZpaHElBO7gEgu9IAT/ Eg44uScEk0f3hTv8Jfnet+rZdpxdtYBGruOXqJJ1zkqouKxR4JHS6pbN//iqFaWpe/4L qNC1cJVGOGO547U8zSlOGTw0Tg58tOGGFeY9J9W8RPXUwE/Y/sJg/0R+YrAHnHkeF1HJ tM/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766392756; x=1766997556; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=w8RM3/o6FB83AIG5gcDlEP7+b/8hOvjggWFz+DBBFz0=; b=DY1iVZdlbhaKic+oRsTVdSVhwpMZf7BhijLHvQ7YpGSvM4/xf2vskxc80WDiqn2XlB oq8HYITF4dcfttH/f0dai4svpLGH+VT+pDYCGDYM15/RM4MXfY19zUjnLQ1CMAgjBSpQ QTS49FaUVobgcbvQnfZZwEaD8ktBge/MfAXkEiAJcnPG768INE6hC3Iy6a8H0FSeKGqi DMmxAX9K1voX4m4QXvKmi8BbjhIZ5/u9uRuQNaBIhohoLYXXzp9Sf6bx4AQ/GAFHmsAT LK1r82vYSc8+YHTnGmgSVppCNOBasqwXP954/YeSqUATi0oGq2qxJiMUpaEam2jVozuE tVgg== X-Forwarded-Encrypted: i=1; AJvYcCUV8Semoh2lICvoSPOs/Lcpu+syjCGG1vXnAGRMaLwSZY59RgNunI7oOMydcIg39d4Uc/cYbVlfVvCoDeY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf7eNIzd9NbSiS/DZoOgfzjrRJPY6LDL81hJaEaTJ4eCRchzK/ /1Vzlg6L9HaNKBf+/G6QasyUNmxICBz0VcVb1lZdwV9zTx65IoIk585rtMDF5Fxmehj6iaXrmJx ZdCnAwvaaF61rKfWsptZqTs4/m17KVNKqki/WdHHjozDNa1q2odEjYfQ47hKDeIaLJA== X-Gm-Gg: AY/fxX5A0ZqssJEOuX9G/u2xC8jwjXhC41SC1nBZTeJM49S24w/eyWVO/wSv7esvt8q VnH0ymNcgdUran1e07g8mizxbFly8HUJXMNe+Q2ph85TbcXUjjpnpg0SzBIFFv+qVWZLh/rxCC+ VX0DKSI1xsbPoiNFjDi2Nd0cUR/UGCjmVYrT2Uqj++4+RwKNDVpxaN0FY+uRFcKRzBKBDyMd5na SdakvNBi5Jyyoz1QP+dxMe6g9VWSW9iJgnZk7cFNhUP/juVcp1bFWZcpZakDEmp5X0dkPKZjkP+ 4QMjw6cAj8VQoPmIV/WiP942CokyFLxHlNnA6Sw5lKuXEMl3GdTaP/rIBlrBKLxxxmHT6H0ElBb NAL1eEtNnjMS7jMO4WJ4E5zfxmDjLx0W+iA== X-Received: by 2002:a05:6000:2890:b0:431:808:2d60 with SMTP id ffacd0b85a97d-4324e4c23a1mr13773022f8f.12.1766392756241; Mon, 22 Dec 2025 00:39:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IH6FHBNL3fzb6KVVsr/bjJemsrbUHJXfzvwJ73EdVuGDT3KdKweVrjghaZ5OFlDaxm+wufJqg== X-Received: by 2002:a05:6000:2890:b0:431:808:2d60 with SMTP id ffacd0b85a97d-4324e4c23a1mr13772986f8f.12.1766392755718; Mon, 22 Dec 2025 00:39:15 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324ea1af20sm19528873f8f.2.2025.12.22.00.39.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 00:39:15 -0800 (PST) Date: Mon, 22 Dec 2025 03:39:12 -0500 From: "Michael S. Tsirkin" To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH] virtio: uapi: avoid usage of libc types Message-ID: <20251222033807-mutt-send-email-mst@kernel.org> References: <20251222-uapi-virtio-v1-1-29390f87bcad@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251222-uapi-virtio-v1-1-29390f87bcad@linutronix.de> On Mon, Dec 22, 2025 at 09:00:33AM +0100, Thomas Weißschuh wrote: > Using libc types and headers from the UAPI headers is problematic as it > introduces a dependency on a full C toolchain. > > On Linux 'unsigned long' works as a replacement for 'uintptr_t' and does > not depend on libc. > > Signed-off-by: Thomas Weißschuh are you fixing other uses of uintptr_t ? > --- > include/uapi/linux/virtio_ring.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/include/uapi/linux/virtio_ring.h b/include/uapi/linux/virtio_ring.h > index f8c20d3de8da..3c478582a3c2 100644 > --- a/include/uapi/linux/virtio_ring.h > +++ b/include/uapi/linux/virtio_ring.h > @@ -31,9 +31,6 @@ > * SUCH DAMAGE. > * > * Copyright Rusty Russell IBM Corporation 2007. */ > -#ifndef __KERNEL__ > -#include > -#endif > #include > #include > > @@ -202,7 +199,7 @@ static inline void vring_init(struct vring *vr, unsigned int num, void *p, > vr->num = num; > vr->desc = p; > vr->avail = (struct vring_avail *)((char *)p + num * sizeof(struct vring_desc)); > - vr->used = (void *)(((uintptr_t)&vr->avail->ring[num] + sizeof(__virtio16) > + vr->used = (void *)(((unsigned long)&vr->avail->ring[num] + sizeof(__virtio16) > + align-1) & ~(align - 1)); > } > > > --- > base-commit: 8f0b4cce4481fb22653697cced8d0d04027cb1e8 > change-id: 20251222-uapi-virtio-d208b915ca1d > > Best regards, > -- > Thomas Weißschuh