From: Johan Hovold <johan@kernel.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Pooja Katiyar <pooja.katiyar@intel.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 0/4] usb: typec: ucsi: revert broken buffer management
Date: Mon, 22 Dec 2025 16:22:00 +0100 [thread overview]
Message-ID: <20251222152204.2846-1-johan@kernel.org> (raw)
The new buffer management code has not been tested or reviewed properly
and breaks boot of machines like the Lenovo ThinkPad X13s.
Fixing this will require designing a proper interface for managing these
transactions, something which most likely involves reverting most of the
offending commit anyway.
Revert the broken code to fix the regression and let Intel come up with
a properly tested implementation for a later kernel.
Johan
Johan Hovold (4):
Revert "usb: typec: ucsi: Add support for SET_PDOS command"
Revert "usb: typec: ucsi: Enable debugfs for message_out data
structure"
Revert "usb: typec: ucsi: Add support for message out data structure"
Revert "usb: typec: ucsi: Update UCSI structure to have message in and
message out fields"
drivers/usb/typec/ucsi/cros_ec_ucsi.c | 5 +-
drivers/usb/typec/ucsi/debugfs.c | 36 +-------
drivers/usb/typec/ucsi/displayport.c | 11 +--
drivers/usb/typec/ucsi/ucsi.c | 118 ++++++++----------------
drivers/usb/typec/ucsi/ucsi.h | 22 ++---
drivers/usb/typec/ucsi/ucsi_acpi.c | 25 +----
drivers/usb/typec/ucsi/ucsi_ccg.c | 11 ++-
drivers/usb/typec/ucsi/ucsi_yoga_c630.c | 15 +--
8 files changed, 71 insertions(+), 172 deletions(-)
--
2.51.2
next reply other threads:[~2025-12-22 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-22 15:22 Johan Hovold [this message]
2025-12-22 15:22 ` [PATCH 1/4] Revert "usb: typec: ucsi: Add support for SET_PDOS command" Johan Hovold
2025-12-22 15:22 ` [PATCH 2/4] Revert "usb: typec: ucsi: Enable debugfs for message_out data structure" Johan Hovold
2025-12-22 15:22 ` [PATCH 3/4] Revert "usb: typec: ucsi: Add support for message out " Johan Hovold
2025-12-22 15:22 ` [PATCH 4/4] Revert "usb: typec: ucsi: Update UCSI structure to have message in and message out fields" Johan Hovold
2025-12-22 22:15 ` [PATCH 0/4] usb: typec: ucsi: revert broken buffer management Katiyar, Pooja
2025-12-23 14:04 ` Johan Hovold
2025-12-23 14:24 ` Greg Kroah-Hartman
2025-12-23 20:21 ` Katiyar, Pooja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251222152204.2846-1-johan@kernel.org \
--to=johan@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pooja.katiyar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox