From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5550A1F5821 for ; Mon, 22 Dec 2025 16:48:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766422100; cv=none; b=ZcGt9hF3/EMovbegisYhqnSM+ylbKvbhqrvuYLgCmUgn8CdoaPCcONWSe8wp2rt+8FP9yh0iFgBdY098389EACttbqNZ9uR0CfSSUCt7RV4Ffm7x6jshuIlKNgusdiBiVn7I9Va4Uc77UxuiYfVEQ0WS9mK93OQIIexHUtiNGoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766422100; c=relaxed/simple; bh=6RJH5pyL2BpLfZ1rbXHIMDvB1WeDFq8yqvAdSPiVg88=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=N87ujvuYm3kIkZGO63MF1mK8OoWA1bR8BcgU047LKvAdfnJNTP8uNU/oKAtRcGVk0EE8tva/Bukbz/PpOx7BGWqyhj1aziu0V4hqPf7bGQW8/b6Q9ObLqg4jx+aJC/pOfsdco1jhcndP/CugTMqGZuVTxbcH17gvrJL8TB2P+so= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=kBrHMZiQ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=dcLz+Vca; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=TcAJKJZZ; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=T+DWQLd5; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="kBrHMZiQ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="dcLz+Vca"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="TcAJKJZZ"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="T+DWQLd5" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 46CB8336A0; Mon, 22 Dec 2025 16:48:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1766422095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UPpXbNtj0vAnbPG6/wPCwq0lIcvY0lyEEKXFKXWrxFQ=; b=kBrHMZiQwE1Z/P8os0OZCa9zBryiUPVYhMMCMZ0rAylR29Z/tWCCoQ6EDc+dTNa+uhIccu 52ZWf19Q/Z20Lvm64hckXdSmzTMQWgPkuDPjJaIDmL6BctZhXkgLON6gs4Bm/mknr3wyQj /HuifZjmy9bpcuCZjSy4pc8RIsanuK4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1766422095; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UPpXbNtj0vAnbPG6/wPCwq0lIcvY0lyEEKXFKXWrxFQ=; b=dcLz+VcaXNGQtNBM9hOdbau7cwKO+rjTZWAoiLReaWSfuYSYE/JBsBhJzZgeHpwv5uwPAH 7m6m57P0U/N7XmBQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TcAJKJZZ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=T+DWQLd5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1766422094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UPpXbNtj0vAnbPG6/wPCwq0lIcvY0lyEEKXFKXWrxFQ=; b=TcAJKJZZVjfJvvvBpKU5STTk4dgL00JsJGw5QLx6FE6D1hMX0npb0TuE5DQTkaFxDHee+B 3zLbKzGdIG/P5c0gkb7gH3w4perErsjDh41aoG3rjFDCDIsm56jKYa7Z5QhU9eYc2VnnE7 z5yl5b3FdVR/SjHpqSlKSCQr0+arEug= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1766422094; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UPpXbNtj0vAnbPG6/wPCwq0lIcvY0lyEEKXFKXWrxFQ=; b=T+DWQLd5xdMtXMwfa7NusQE+F/gqELRx++9z8/NVRz7i+Fon7u0qD5cTDUtnhZF84EtcQt ipbjgoi2nJGvOsBw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DA5C51364B; Mon, 22 Dec 2025 16:48:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uQFLM012SWmvGwAAD6G6ig (envelope-from ); Mon, 22 Dec 2025 16:48:13 +0000 Date: Mon, 22 Dec 2025 17:48:10 +0100 From: Jean Delvare To: "Mario Limonciello (AMD)" Cc: Yazen Ghannam , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] firmware: dmi: Correct an indexing error in dmi.h Message-ID: <20251222174810.36a3deb4@endymion> In-Reply-To: <20251216123354.9219-2-superm1@kernel.org> References: <20251216123354.9219-1-superm1@kernel.org> <20251216123354.9219-2-superm1@kernel.org> Organization: SUSE Linux X-Mailer: Claws Mail 4.2.0 (GTK 3.24.43; x86_64-suse-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Flag: NO X-Spam-Score: -4.01 X-Rspamd-Queue-Id: 46CB8336A0 X-Spamd-Result: default: False [-4.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; HAS_ORG_HEADER(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim]; URIBL_BLOCKED(0.00)[dmtf.org:url,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim,amd.com:email]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Level: Hi Mario, On Tue, 16 Dec 2025 06:33:48 -0600, Mario Limonciello (AMD) wrote: > The entries later in `enum dmi_entry_type` don't match the SMBIOS > specification. The entry for type 33: `64-Bit Memory Error Information` > is not present and thus the index for all later entries is incorrect. > > Add the missing type 33 entry. > > Fixes: 93c890dbe5287 ("firmware: Add DMI entry types to the headers") > Link: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.4.0a.pdf > Reviewed-by: Yazen Ghannam > Signed-off-by: Mario Limonciello (AMD) > --- > include/linux/dmi.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/dmi.h b/include/linux/dmi.h > index 927f8a8b7a1dd..a809b5095c259 100644 > --- a/include/linux/dmi.h > +++ b/include/linux/dmi.h > @@ -60,6 +60,7 @@ enum dmi_entry_type { > DMI_ENTRY_OOB_REMOTE_ACCESS, > DMI_ENTRY_BIS_ENTRY, > DMI_ENTRY_SYSTEM_BOOT, > + DMI_ENTRY_MEMORY_INFO, > DMI_ENTRY_MGMT_DEV, > DMI_ENTRY_MGMT_DEV_COMPONENT, > DMI_ENTRY_MGMT_DEV_THRES, Good catch. Do I understand correctly that this does not fix any actual bug because none of the entry types after DMI_ENTRY_SYSTEM_BOOT was used in code so far? As for the name, considering that we used DMI_ENTRY_32_MEM_ERROR for type 18 (32-Bit Memory Error Information), I believe we should use DMI_ENTRY_64_MEM_ERROR for type 33 (64-Bit Memory Error Information) for consistency. Thanks, -- Jean Delvare SUSE L3 Support