From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A2592C11E2 for ; Mon, 22 Dec 2025 16:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766422222; cv=none; b=L45/7dA+jlHKlf3VinXrHCjMBdrf/vRKMgNJtGf+QsLPISnK1svMJk74Nr4TTbYDsVJ5IUfikOat7JhjBACblCtXdDASsvazLHcQ4dtlVMHjiNa/kbS3MImlPSNOP37VJV9oz7lLe/E/OjFcmyNwS87ioTocwD1zvGvGeN8Dxqg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766422222; c=relaxed/simple; bh=52vhscXwaUt2M91p286oPVr7fYybdMkygfQ15OjvgMI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SleI4H1oyTJeoyljIXZzCxhhVYz40D8knvq6IoVQpX7jrQjSzxCXOyHiYJiGR4lTvaGXbw4UH0EiGv5c5lgYjF+YCNOndPPCetxBj9S1r5/BI8cyDkuGtc9eEO7e6RJdKJ2Hb/VGp3tC9SbT1ptTfT6rjABaUdYv5ZkOSkZzKrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=bZQHymjf; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=FuW9Sz6k; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=bZQHymjf; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=FuW9Sz6k; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="bZQHymjf"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="FuW9Sz6k"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="bZQHymjf"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="FuW9Sz6k" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 85083336A9; Mon, 22 Dec 2025 16:50:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1766422218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rHkvM8DG6YlM+C31YtAc+6KxCT8ODSyhwceYfXhNTh4=; b=bZQHymjfzVvoSGFRjVwYvzFFIvnSvF3jnZLmvrqlw+F73kSXpN3cgjsyjs8/q02/seWGYT 83O1WYEYc/iOM9NvzNIaWltxlli+6ACTjOylc3y8XlsxmyMdUM1BeK9W14ib4dVGUTePjO Bh8fCuaGDnWAHI34qNau/44VHx6M7K8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1766422218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rHkvM8DG6YlM+C31YtAc+6KxCT8ODSyhwceYfXhNTh4=; b=FuW9Sz6ku4fhTwjQiC0uPh+MmmW7DOlgHcKyKn+7MjkWhYkwDdsvJhOKNHt8+ldake4QzX 1qt9q4JrIJGg8bCA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1766422218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rHkvM8DG6YlM+C31YtAc+6KxCT8ODSyhwceYfXhNTh4=; b=bZQHymjfzVvoSGFRjVwYvzFFIvnSvF3jnZLmvrqlw+F73kSXpN3cgjsyjs8/q02/seWGYT 83O1WYEYc/iOM9NvzNIaWltxlli+6ACTjOylc3y8XlsxmyMdUM1BeK9W14ib4dVGUTePjO Bh8fCuaGDnWAHI34qNau/44VHx6M7K8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1766422218; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rHkvM8DG6YlM+C31YtAc+6KxCT8ODSyhwceYfXhNTh4=; b=FuW9Sz6ku4fhTwjQiC0uPh+MmmW7DOlgHcKyKn+7MjkWhYkwDdsvJhOKNHt8+ldake4QzX 1qt9q4JrIJGg8bCA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2473B1364B; Mon, 22 Dec 2025 16:50:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id j9LyBsp2SWkoHAAAD6G6ig (envelope-from ); Mon, 22 Dec 2025 16:50:18 +0000 Date: Mon, 22 Dec 2025 17:50:17 +0100 From: Jean Delvare To: "Mario Limonciello (AMD)" Cc: Yazen Ghannam , x86@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/7] firmware: dmi: Adjust dmi_decode() to use enums Message-ID: <20251222175017.23d66430@endymion> In-Reply-To: <20251216123354.9219-3-superm1@kernel.org> References: <20251216123354.9219-1-superm1@kernel.org> <20251216123354.9219-3-superm1@kernel.org> Organization: SUSE Linux X-Mailer: Claws Mail 4.2.0 (GTK 3.24.43; x86_64-suse-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-3.75 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; NEURAL_HAM_SHORT(-0.15)[-0.734]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; HAS_ORG_HEADER(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:email,amd.com:email]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,amd.com:email] X-Spam-Level: X-Spam-Flag: NO X-Spam-Score: -3.75 On Tue, 16 Dec 2025 06:33:49 -0600, Mario Limonciello (AMD) wrote: > dmi_decode() has hardcoded values with comments for each DMI entry > type. The same information is already in dmi.h though, so drop the > comments and use the definitions instead. > > Reviewed-by: Yazen Ghannam > Signed-off-by: Mario Limonciello (AMD) > --- > drivers/firmware/dmi_scan.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c > index 70d39adf50dca..80aded4c778bc 100644 > --- a/drivers/firmware/dmi_scan.c > +++ b/drivers/firmware/dmi_scan.c > @@ -484,14 +484,14 @@ static void __init dmi_memdev_walk(void) > static void __init dmi_decode(const struct dmi_header *dm, void *dummy) > { > switch (dm->type) { > - case 0: /* BIOS Information */ > + case DMI_ENTRY_BIOS: > dmi_save_ident(dm, DMI_BIOS_VENDOR, 4); > dmi_save_ident(dm, DMI_BIOS_VERSION, 5); > dmi_save_ident(dm, DMI_BIOS_DATE, 8); > dmi_save_release(dm, DMI_BIOS_RELEASE, 21); > dmi_save_release(dm, DMI_EC_FIRMWARE_RELEASE, 23); > break; > - case 1: /* System Information */ > + case DMI_ENTRY_SYSTEM: > dmi_save_ident(dm, DMI_SYS_VENDOR, 4); > dmi_save_ident(dm, DMI_PRODUCT_NAME, 5); > dmi_save_ident(dm, DMI_PRODUCT_VERSION, 6); > @@ -500,33 +500,33 @@ static void __init dmi_decode(const struct dmi_header *dm, void *dummy) > dmi_save_ident(dm, DMI_PRODUCT_SKU, 25); > dmi_save_ident(dm, DMI_PRODUCT_FAMILY, 26); > break; > - case 2: /* Base Board Information */ > + case DMI_ENTRY_BASEBOARD: > dmi_save_ident(dm, DMI_BOARD_VENDOR, 4); > dmi_save_ident(dm, DMI_BOARD_NAME, 5); > dmi_save_ident(dm, DMI_BOARD_VERSION, 6); > dmi_save_ident(dm, DMI_BOARD_SERIAL, 7); > dmi_save_ident(dm, DMI_BOARD_ASSET_TAG, 8); > break; > - case 3: /* Chassis Information */ > + case DMI_ENTRY_CHASSIS: > dmi_save_ident(dm, DMI_CHASSIS_VENDOR, 4); > dmi_save_type(dm, DMI_CHASSIS_TYPE, 5); > dmi_save_ident(dm, DMI_CHASSIS_VERSION, 6); > dmi_save_ident(dm, DMI_CHASSIS_SERIAL, 7); > dmi_save_ident(dm, DMI_CHASSIS_ASSET_TAG, 8); > break; > - case 9: /* System Slots */ > + case DMI_ENTRY_SYSTEM_SLOT: > dmi_save_system_slot(dm); > break; > - case 10: /* Onboard Devices Information */ > + case DMI_ENTRY_ONBOARD_DEVICE: > dmi_save_devices(dm); > break; > - case 11: /* OEM Strings */ > + case DMI_ENTRY_OEMSTRINGS: > dmi_save_oem_strings_devices(dm); > break; > - case 38: /* IPMI Device Information */ > + case DMI_ENTRY_IPMI_DEV: > dmi_save_ipmi_device(dm); > break; > - case 41: /* Onboard Devices Extended Information */ > + case DMI_ENTRY_ONBOARD_DEV_EXT: > dmi_save_extended_devices(dm); > } > } I'm fine with this change. Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support