From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8B8D1FE44A for ; Mon, 22 Dec 2025 16:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766422791; cv=none; b=bjZRcIbziVtKdBy91aJXIBRp8YYUILkoRB1c9QDN78G0ib+LYBikbC0bHfHl5MoCLZdWEnMifbSMMR8N4wT7TVjRrLk1vEktNjSLl9TwHquDVhEv+0ViC980L40QqlBo5DkdbfXmv5MK1W+FoL1VlFat/4RdPNvsDeVWDghSwLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766422791; c=relaxed/simple; bh=2KPzmYAdHzbiqvwssCiyC0MzEUnrs22E8xY4s6uHHUs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=edQ03tjCE4NeTuwBWFhy24I+rs7qJGDQi88Y5kINDsQMD4el2UcROR9owui9Hv8TpF13WmeHmAjBIwNAq6pgpV0+eZjaX5XIP3fEjFx6YXldkBEoruN1Qp1OI728meZP005t4XCPC4Qe5o7xP18o4iOVOuAgbCiFGdP/VYU/kf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=pXblY6Bg; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=QDBjGTSg; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=SkVSAYFO; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=Gq5tse88; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="pXblY6Bg"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="QDBjGTSg"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="SkVSAYFO"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="Gq5tse88" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 882CE5BCF4; Mon, 22 Dec 2025 16:59:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1766422787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jyz3GMr9DSm10n/P0MSsRpFMaW0xK2vydriz2ACzdVU=; b=pXblY6BgZYTVRiVGohVFcmj/XIbnMq81cPRF1My06R9gkD0JPuSCuRRIOeaxoGHvZwnjNo z2B90DOHRAZqRtaXOkKh59fkTWq64Q+4UH36IaFgnwxfD04rtshbXvP/2rVf36ePwd4Ig6 QBulToBmI3beiCJ9/SgaW+2bZ0mhWvE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1766422787; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jyz3GMr9DSm10n/P0MSsRpFMaW0xK2vydriz2ACzdVU=; b=QDBjGTSgH2sk/4qslpKdLKXYTus3jZOtVlBx+0eRROzTNg1TyD9tNxwZHVOq5ay4AHw1C1 Qmd2EY1+PZS5+aBQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SkVSAYFO; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Gq5tse88 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1766422786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jyz3GMr9DSm10n/P0MSsRpFMaW0xK2vydriz2ACzdVU=; b=SkVSAYFO6Jgu63yMYoPwcD5pbLtTXzDV1ZGT73oCok8XidvoTe3kcj13rW05a7VoJfUfkN Wc2L7nMRH0LF70smRFy+PufcISFbCPd0vkEuYjBSImTlth80FPkEYkckXtpGXDZ1MFmpzU hih5+lace606FFuMfC0VS2JiABaUU3s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1766422786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jyz3GMr9DSm10n/P0MSsRpFMaW0xK2vydriz2ACzdVU=; b=Gq5tse883nWL+6fh2jShGaLJH6wfTp8ieFfMUGtPFDLTLzRqA5fcJeeZBGvuRM78MNAiD2 BTJb5q1Ihhwq/ICg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 29B041364B; Mon, 22 Dec 2025 16:59:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YHItCAJ5SWkHHgAAD6G6ig (envelope-from ); Mon, 22 Dec 2025 16:59:46 +0000 Date: Mon, 22 Dec 2025 17:59:45 +0100 From: Jean Delvare To: Yazen Ghannam Cc: Mario Limonciello , , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/7] firmware: dmi: Read additional information when decoding DMI table Message-ID: <20251222175945.59c76f67@endymion> In-Reply-To: <20251217212134.GD1263950@yaz-khff2.amd.com> References: <20251216123354.9219-1-superm1@kernel.org> <20251216123354.9219-4-superm1@kernel.org> <20251217210352.GA1263950@yaz-khff2.amd.com> <78dbc0eb-37a3-468d-b43e-f5a5a06ad8fe@kernel.org> <20251217212134.GD1263950@yaz-khff2.amd.com> Organization: SUSE Linux X-Mailer: Claws Mail 4.2.0 (GTK 3.24.43; x86_64-suse-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.01 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_RHS_NOT_FQDN(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; HAS_ORG_HEADER(0.00)[]; TO_DN_SOME(0.00)[]; RCPT_COUNT_SEVEN(0.00)[9]; RCVD_TLS_ALL(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spam-Level: X-Rspamd-Queue-Id: 882CE5BCF4 X-Spam-Flag: NO X-Spam-Score: -4.01 Hi Yazen, Mario, On Wed, 17 Dec 2025 16:21:34 -0500, Yazen Ghannam wrote: > On Wed, Dec 17, 2025 at 03:09:33PM -0600, Mario Limonciello wrote: > > On 12/17/25 3:03 PM, Yazen Ghannam wrote: > > > On Tue, Dec 16, 2025 at 06:33:50AM -0600, Mario Limonciello (AMD) wrote: > > > > Type 40 entries (Additional information) are summarized in section > > > > 7.41 as part of the SMBIOS specification. Save these entries when > > > > decoding the DMI tables. > > > > > > Why can't an interested user just use dmidecode? > > > > They could. The reason for doing it in this series is the same reason for > > the one that we did the S5 bit. > > > > It shows up in the logs, you can tie regressions to the AGESA version at > > specifically at the time of the failure if they've done BIOS updates since > > then. > > Yes, right. Sorry, I mixed this up with the debugfs patch. > > We need to save it here so the init code can find it. > > But why do we need a debugfs entry for it? FWIW, I had the exact same feeling when first gazing at this patch series. I believe that every problem that can be solved in user-space should be solved in user-space. Now I get the reason (explained above) for logging the information at boot time, and thus the requirement to parse type 40 in the kernel, but if there's no strong reason to have a debugfs interface then I'd just drop it. Of course, we also want to improve support for type 40 in dmidecode. I admit I didn't pay too much attention to it so far due to a lack of use case. But now that there's a use case, I'll be happy to work on it (or commit a contribution if someone else beats me to it). -- Jean Delvare SUSE L3 Support