From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBFB4354ADB for ; Tue, 23 Dec 2025 01:29:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766453356; cv=none; b=Lt/wzwfD8vdroLU7+7Mq1GXIpcn3c0x2LUnD7H6cCEoqkzTMb+R6kGFxqw4T8xuFwHCo3Z7x6WjsrY+NIADplFPDDezQIlAr7q/hzXQyd0w3WUerIqXkFHmtxBu5kfohjUDVMvsiy0qZ87iGPdtk5ndgfb+NbAKagCd+B8h35BE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766453356; c=relaxed/simple; bh=HxZBIQrNPUtqILX+MUs7BAnpHkmCv3JHX/T4T16NDGU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FXbS9RccUmUvybZb5rmfyPndlL/L3ViAbJe/RDiPCck853MgsEqyvUb8eAp4ENJGApaVctj1kQAi8iUnYtYcDKBFouXG1LXFBuafmBHJkJRBHqjsVB3pm/F06yqvDXQu53PMYCk/zIuTfXr5STDwFRdPkRzrJBiA8Ce943mYGOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MOhbmNca; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=aNDZAXvY; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MOhbmNca"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="aNDZAXvY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766453353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BD3GjIyrDKH9xeBbUL4g7HcZl7Q4z8Vu90OXxS4FE5E=; b=MOhbmNca92arjdz9yH7p+/MafdSc2dK2n3F00p2PuAcjbckoZixnt+niepw3/Dzn4inz2h OHdhjPqMCuBNbb8u8FFHYSTtPqzgVjoTzOyb5ixpY0+0wWCT7DMYpa7SeJd0ldbeCebP8Q k7auFwC/nmo19pekwyrgsfCmnZ7tK40= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-4py-wyhJN8-P_VDmd_9eTw-1; Mon, 22 Dec 2025 20:29:12 -0500 X-MC-Unique: 4py-wyhJN8-P_VDmd_9eTw-1 X-Mimecast-MFC-AGG-ID: 4py-wyhJN8-P_VDmd_9eTw_1766453351 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4779b432aecso23605545e9.0 for ; Mon, 22 Dec 2025 17:29:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766453351; x=1767058151; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=BD3GjIyrDKH9xeBbUL4g7HcZl7Q4z8Vu90OXxS4FE5E=; b=aNDZAXvYFEVjBQE4BzLRu2QoUwJBH8tQvXIhx60QkCqJSCHCQux2f6nSgpwo0PnOiC TRR3KmdTmLJDABYj03SlFU6ymh9KBOcLXdJBIK7NOi23fLdDH4t4zeyd/29fc5n3aiRa z2V0mkRSsLoojqPtW+vK8Cocr+7ACLEhn/EYxyQkg+u7uACqwMPjF20Q5/Oo/IX1KLRP 08wjfNPBQEolIn6CRwzg4kf61ViL26lE/3cux/LbnoXMEiKDfbpsuFTQJblEPSKSQeFP AGiAA4ZGXPTnxXxYW9vQgwt5njhT8AHlfUdG8/sTBDPI4QYPpAfesGuwRWBFDfyhsIsG PSzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766453351; x=1767058151; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BD3GjIyrDKH9xeBbUL4g7HcZl7Q4z8Vu90OXxS4FE5E=; b=BfXvZln2JDYMAMYYDYyuqJQIkhj7Mkz5IxQ2rigP9cXVj+9rNXRoQzdorIm7GV7A9v CntDwHuN4bphJorGs3JmDg5UD3CqgTWWmp8DHCzPTy7mB79LjiTyujFx/KeyJlgJ9cQw KCUa6K0ZGNGWJJMfUXs4EjzNdewp5uk2P01n8pa6kVrgZiQXzQl2jxwMapZS3bUqWxY1 Vh5iHJ7owrZ0VnRzvXOtenpuEy5NSAI8sqLrrIcG+quKpgCwKZ6Qq55Gs6bRsmFT22Vm GB9V5s2q0OvzKiy70XXqKiH5O4NOB9KcxucfSDVirk4xiJDHqqmbPFiQCnZyziCAVWng y2pg== X-Forwarded-Encrypted: i=1; AJvYcCVo4qwwBA1+nWte4J4hYMnfTPTcoQfz4thU6x6X1kW5LFeMYCbazptSd9D8BkWoj8SlYjfGMWmBnLlYGlY=@vger.kernel.org X-Gm-Message-State: AOJu0YyZ/rWSIWvIvhhbLz7eI6QSkqis0HDEl7c+OF8k+3Zu1vRjlt3z 47zTspf7hnL/vBTBc100j46LNq9nSVWeeab95KTwtap1JkUMI3wnClnBMkm0RJMA3QbDjgTXuGv c56oxKyIRJCBMlw7/wdd0zy64YnmoBPd2/fB6itbJ+bRhh6X8sND5J8SfM19WbNIFag== X-Gm-Gg: AY/fxX4jMZSX85KcM884nvR2rB6UAJaPrm95Tmy3aW0zGwh1iuugvtMyacN2TCHFvZ1 b2uIW41FTPya4nw/SmmW2nJZ68+XgdnsXIPCTeCPmlHunfE0RqnLq+KqOBspnDP0cFs7YqXFjpm eff4Ha0rVr2AECid5gYjFvyi5iWOZlxbbXCeCTrXrv/353QSjpLsAHzE7UkG/pMMyRZZSEv1An9 qKyDX6lUHgvViqSg1o5NcjOCrDIehgGSgUlFIwk4/09l4YN3ICh6VKk95RrzQPCnPHZsAxKFgIu DRwNINQpz++ugt+6Xr4FQm73lHv5E9V2QXVCMTRPxheRyku6UHmMKo3LVFgmzi5CNIoCffiaRp5 MQGtxOyVT7Fq3YitNWU4KSeZKbDjMMJ14aw== X-Received: by 2002:a05:600c:8208:b0:46e:33b2:c8da with SMTP id 5b1f17b1804b1-47d1958d960mr119134285e9.32.1766453351306; Mon, 22 Dec 2025 17:29:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGO+LG2FI8JPMK8jgG+/xJo3+UBYSR7dVKlIQUEA+U3e7FL+sIKeyZHuU+YrwGcYBw8xYWP6Q== X-Received: by 2002:a05:600c:8208:b0:46e:33b2:c8da with SMTP id 5b1f17b1804b1-47d1958d960mr119134165e9.32.1766453350851; Mon, 22 Dec 2025 17:29:10 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa2bdfsm25512101f8f.32.2025.12.22.17.29.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Dec 2025 17:29:09 -0800 (PST) Date: Mon, 22 Dec 2025 20:29:07 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: xuanzhuo@linux.alibaba.com, eperezma@redhat.com, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH V9 00/19] virtio_ring in order support Message-ID: <20251222202855-mutt-send-email-mst@kernel.org> References: <20251125070838.70736-1-jasowang@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Dec 23, 2025 at 09:18:47AM +0800, Jason Wang wrote: > On Tue, Nov 25, 2025 at 3:08 PM Jason Wang wrote: > > > > Hello all: > > > > This sereis tries to implement the VIRTIO_F_IN_ORDER to > > virtio_ring. This is done by introducing virtqueue ops so we can > > implement separate helpers for different virtqueue layout/features > > then the in-order were implemented on top. > > > > Tests shows 2%-19% imporvment with packed virtqueue PPS with KVM guest > > vhost-net/testpmd on the host. > > > > Changes since V8: > > > > - Rebase to vhost.git linux-next branch > > - Fix issue when indirect descriptor is disabled > > - use UINT_MAX instead of vq->num to indicate no batching is pending > > - Tweak the comments for used_entry > > - Various coding style tweaks and typo fixes > > - Try to use in_order varianet in in_order ops > > Michael, any chance to make this for this merge window? > > Thanks want to fix last minor comments?