From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5363D27703A for ; Wed, 24 Dec 2025 01:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766540106; cv=none; b=JRunw0rGpcHzxZ1H4hvagILlH8v4zwLDXi6ebcy5FNtJIPBx4omFwFKUvoljB9hMZAWL5FSD/TyOWeM2OcJ+QvJSoE5uVOXDsxCCPk/lSJozp9Tp5gQrcTCmc2uqpPL/mKvlIP/M21VRs2SUJFVqd3W174DXX9hmhtNnqZeAsuQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766540106; c=relaxed/simple; bh=VxgwS571p6d9ltRCxPlktCpRXiNoc5EoA/Yuj4mRh0k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QfwsE4y3HhlBJkLKPuGjVVSbUuWeopE52nqGKvXuLyuRGswDSZzD/ARKukFU+ihvoe/q/cMAKvMPR8+3Qrdyr7gb9OorPYPsyDgNzJUxFIV3vt4Tb+9oNm9NOMawz3vG30BHVrwTDBJMJgFzhgK2bw7FSd4yoAXLA58kj2KFuHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=W2yrPsYL; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jp3Y52fG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="W2yrPsYL"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jp3Y52fG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766540104; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ul5RYtwKuLzb4fmUt0dahcK3wJyHyhIWdXTPSkMhGA8=; b=W2yrPsYLpYienJuhVT1NK9k/++RvzFzCBYaND968e03B3ThmXQYhMxS2gDq4LTWYmz1zqJ WNs/p1SbKIL5yrGjk2h6g4ACHQOh+twJ5e0XacY8CoRKYVFIH6v6XFh7rr5R/+fnY1Yi39 4LqexlkjI9RGxHmNfmZdeiR1IrC+jL8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-2-mGjxSvOaCmUo1e_-5F4Q-1; Tue, 23 Dec 2025 20:35:01 -0500 X-MC-Unique: 2-mGjxSvOaCmUo1e_-5F4Q-1 X-Mimecast-MFC-AGG-ID: 2-mGjxSvOaCmUo1e_-5F4Q_1766540098 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47904cdb9bbso53847755e9.1 for ; Tue, 23 Dec 2025 17:34:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766540098; x=1767144898; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ul5RYtwKuLzb4fmUt0dahcK3wJyHyhIWdXTPSkMhGA8=; b=jp3Y52fGPO/B3hmxJtGq8GKulUZVsVmMrdLGuVjR8jXfaVZtVUrd1GpphDOt2d1dL9 GdLz5m0JuIi6ia5qj33N/fbRK/DHrSQzh2XsR3S4ClIXOb7WkkgoQotucXmI8RFLiOn6 z+sgl4gblqgcM5MOsG/gxu7N2ACVeulT8fg859MnKmEzeaaP1rUhXr8ak65YvOMTGbCN lUrshpgZJlP05fFhfVjx8KXaamOWMMfyYQxX2lkomJNKKv6OMBQCsnfvtZOSAX7BBEAr kz4jD6YpaJUl8xJYreAs5uCp3OM8a/WHrFrZrtVDUGEqBkm2pgfeNIr1RPDeC/cL65Oa WRpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766540098; x=1767144898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ul5RYtwKuLzb4fmUt0dahcK3wJyHyhIWdXTPSkMhGA8=; b=HJbkJbDnnEFwVdOIbY5X2yAh3Q1FhUPedRwGok0q/X6RSNvq24hq3QZk25HVTDux0T 1lcBUYPxZKvtI2ytfhQMwZ7RHo+MNF48K62K9AUPN2TAA8FrFoaRNsqL13OOfe23I7Sk R4S5Mxv9IeCIVtjUGeFLx3ybUuwAS6dnq+aW+mZHzimKJdotbGnoaSj0rbq41iRQnD4q 2QfDcphHMOBoMdUJbSnSMykFEg0+SobFL1/w7D8k3CzTft4KNl73jLwrpMAiFVNW0O7d qQSELq2zmk52xUkrPp7kDVErFsTLXJiNhk/cUrcpGRNx39mDnz1btHnraD6UkvDbdPVT X+Rg== X-Forwarded-Encrypted: i=1; AJvYcCVzVC5e6gLCHeXJrNvgegJcw481DNfy5BivU1yje6Xs2kNADYXRESiX4eiH/VsK3M9NO2R2PXdyD7CX01o=@vger.kernel.org X-Gm-Message-State: AOJu0YzVEcJWjJFMxNMJnxzoY+cvttjvxFD73hWAuJetGgdPWmpO3g5v FS3ZiOi17fRy0GmUZ5r8Hu98OKyG43DShenrn7xybHZ9zUOwake3TRQqKqTrIIrHjGXQvosYwXH FlqlUOzF7QmCZ+qTgRvqsUmJtXQ2NaAaOpW9vVobm2heRZH2Uw8Y0t3zaJHo4INEIRw== X-Gm-Gg: AY/fxX4tIVG03MPK4ZTcEviegdfnNiVd23/EfOlvBjkrCt6plzQW1Yt/QBtJ9jA00gC 5hzWuZ6/7nE1rBs2wvydNusADwIIpzNBHm/WO5TVT/9iM7IJtk8RhWFZ6kn7d0yqZ8mkYiqZfOW e7HeG15nGzZyYF2ALIQnkt7WR5ohxmFdvjA5oeyxWaHWJhotQQf4DHBGn/T5HideQtMdndnQVWg D+mDC6BKpbX7c33DMRlnJYnlv8c8wcmF8s5t3z5n2YJh/7DsOOsij9GtmZX782xSI0uufQTGMDN 55Fv6VQU4L7YL/h+EyLx0Kwt/lretOcKUnOUjFS4wBRa5RK7BR0Q7hysRFHlOx0BGoDbbSmlQn6 k X-Received: by 2002:a05:600c:444d:b0:475:ddad:c3a9 with SMTP id 5b1f17b1804b1-47d18bdfc61mr174135185e9.13.1766540098384; Tue, 23 Dec 2025 17:34:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IFS9I2SQh5r2tYHnvHjQVonS3jrba9soPU92JGUQFF6MGUaVBWeHJ/5ROPtwija6HgeR+BPrA== X-Received: by 2002:a05:600c:444d:b0:475:ddad:c3a9 with SMTP id 5b1f17b1804b1-47d18bdfc61mr174134935e9.13.1766540097822; Tue, 23 Dec 2025 17:34:57 -0800 (PST) Received: from redhat.com ([31.187.78.137]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be279d6d8sm319276165e9.10.2025.12.23.17.34.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 17:34:57 -0800 (PST) Date: Tue, 23 Dec 2025 20:34:54 -0500 From: "Michael S. Tsirkin" To: Bui Quang Minh Cc: netdev@vger.kernel.org, Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH net 1/3] virtio-net: make refill work a per receive queue work Message-ID: <20251223203310-mutt-send-email-mst@kernel.org> References: <20251223152533.24364-1-minhquangbui99@gmail.com> <20251223152533.24364-2-minhquangbui99@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251223152533.24364-2-minhquangbui99@gmail.com> > static void virtnet_rx_pause(struct virtnet_info *vi, struct receive_queue *rq) > @@ -3463,8 +3444,8 @@ static void virtnet_rx_pause(struct virtnet_info *vi, struct receive_queue *rq) > * Make sure refill_work does not run concurrently to > * avoid napi_disable race which leads to deadlock. > */ > - disable_delayed_refill(vi); > - cancel_delayed_work_sync(&vi->refill); > + disable_delayed_refill(rq); > + cancel_delayed_work_sync(&rq->refill); > __virtnet_rx_pause(vi, rq); > } > disable_delayed_refill is always followed by cancel_delayed_work_sync. Just put cancel into disable, and reduce code duplication. -- MST