Re: [PATCH v2 1/2] net: phy: adin: enable configuration of the LP Termination Register

Vadim Fedorenko
2025-12-23T07:36:45Z

On 22/12/2025 22:21, Osose Itua wrote:
> The ADIN1200/ADIN1300 provide a control bit that selects between normal
> receive termination and the lowest common mode impedance for 100BASE-TX
> operation. This behavior is controlled through the Low Power Termination
> register (B_100_ZPTM_EN_DIMRX).
>
> Bit 0 of this register enables normal termination when set (this is the
> default), and selects the lowest common mode impedance when cleared.
>
> Signed-off-by: Osose Itua <osose.itua@savoirfairelinux.com>
> ---
> drivers/net/phy/adin.c | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/drivers/net/phy/adin.c b/drivers/net/phy/adin.c
> index 7fa713ca8d45..e8b778cb191d 100644
> --- a/drivers/net/phy/adin.c
> +++ b/drivers/net/phy/adin.c
> @@ -4,6 +4,7 @@
> *
> * Copyright 2019 Analog Devices Inc.
> */
> +#include <cerrno>

This kind of include is not used in kernel.
You don't need to include anything in this file to have EINVAL defined.

> #include <linux/kernel.h>
> #include <linux/bitfield.h>
> #include <linux/delay.h>
> @@ -89,6 +90,9 @@