From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28C6F314D3B for ; Wed, 24 Dec 2025 06:27:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766557680; cv=none; b=ZVQT2nD8ghv4lYMOQJW45QzLo4kgFmgXTX5gvx7hX2ZNttBy6jHkaUsPTlMXXL12jTW95ym6PBIzOAq7/wIpsjfBwcVGRwxy3Xa8GV3a0DWjWsf5uIAo1bUPMJ+ivZGfv6r+2bo1BnhzrbUSKCm6wkhgOEdjEEGq9fs79bB0ipg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766557680; c=relaxed/simple; bh=LQBwQ5KKiAURRSdH9SPmpV/8R5KpoEVoxpc1FUT4Bqs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cZiFg8XWKElaS1ZMjWYKowx7L5ZTzamhH0jziepgZSwD6e5/T44tjr6Xjt8i//mbUNWSKiNpc0n2r+10DDRB5OBu+GQTpYk3W0pmZVBJDwZhaO9rZ+rVTeneHmYPmXIc3LWOtJmih0zKNRKSZXCiuUD38j4DzPxNJaOlio2SVSU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=If5K/Bj3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Vk1dP4SI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="If5K/Bj3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Vk1dP4SI" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BNJCr461056218 for ; Wed, 24 Dec 2025 06:27:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1+l/KNumtMTGWNi4cIdCRyGHVnnCi7mJh+TTQ304qCI=; b=If5K/Bj3zQdKfonB 1P/HzoOt3wJXo77Lyt0X+p1W2UEspwrDI00B16J8JD0u9RaIzoNcTevQXUVaZM8z xv6Zi2bqeIRSzMY+O+uZ0VeZ3RYQRJ6yH+TeXN4aD5LLhsRn1sV+xPge84VpWV/N xUw8sUPoSESQr21SysouBHUj7EgP5XOnidYUpaUZGrK8DbNztKx0A1OdjqwRv/TJ xL+dn48loaHQPm6zetiyDvDmlB8AymMITG1vvKkLxxrQ47h1ApUSnSRJEYKNglYb FD5n4+4Sj28rGkshyG7+tgo+Iz4Jw7xnmf1D1MdYBekXN0pwdwcKL/quz+yxHOg1 biS+mg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b811v1j69-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 06:27:58 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-7b6b194cf71so10648696b3a.3 for ; Tue, 23 Dec 2025 22:27:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766557678; x=1767162478; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1+l/KNumtMTGWNi4cIdCRyGHVnnCi7mJh+TTQ304qCI=; b=Vk1dP4SIZSCI84SMZf4skZKqDskJu1OFqh2UhT1xm0lfCSenbcIOII3s62JRygfOf3 lk/e9RcVCWwlaBjV24Xib0dUbZX+8fSn6sAmJDSS4R+0I5EHG/4ft+ywf5Z9g6gU+/NA iAuowVivHhlOG3zVohBFL9sB0oxGbJnOujknajHAWrJLc9KUw1rp0LaB8gy3YFK4IzUz SLZ0G0fnt3OGEnGC40CCp0LaCbFSD7t4xNzoW8WNHWEjA4m9Kt3iOTgGdtQNxWSJIqd2 Tb8ZbKPtIk0p/hNVXuFjcFUsjVdDFlbMrwIN/naoBt+PODDMOaj/azfkuMqnZY8Y4UsC FWwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766557678; x=1767162478; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1+l/KNumtMTGWNi4cIdCRyGHVnnCi7mJh+TTQ304qCI=; b=i59kcUuT65HUHvtWSuD3aRqKb2sgqzYpnXuZdGbHsFRXIyyEEsIrVAJZ++T1+P6wOi Ay73PygnzqF71wlXXFJQibBp1AvTTi0rBj5FczAc48f6Ur1XVZkryefTpUkNDxC4TMWy s89uZmz382oLgKvJnzs8HST3e3S9LieGOU6PxOJLkFVK/NpU74J2/qQ9AYirTGTIFOqD hbpzFRqj1kGYcTjnLwftnoSTTvVxZclMK/4I6ZCwlXU242xuCgGwyYJq+VD/41qZmg6P 0xxJDEBe8eZbfgBlj4cU6fwSSHVkj2pKYmxGPu4byCEq+/Ig0Wit54jt0RTdj3GXJaUC Nf+A== X-Forwarded-Encrypted: i=1; AJvYcCWdja/aj2wuQCKDLwp01Dbc+CVaRr3cBIQ94FjwQwspsLrAfUecckZ4IA21PNPw2UwVaRwalmDjW9WG8pc=@vger.kernel.org X-Gm-Message-State: AOJu0YxWooaGY/+W0WAXjpKEPT2NLBth/ONUZInlwMVmVV2wl1iYrgPQ WzwRiA7a0+W4aNt4V88WUcItKm7q2gr29saMnAfdtHI4ENxfXXNBV5zug22C+hndUt7zDw7SUq9 DxxGKDJhSygXYuIgy/PHZUZP0ucKl6eQV86fA4Jq6tfUV6JSy3sozn6ChgO5faOH9wFY= X-Gm-Gg: AY/fxX7RiG1GD3xSyiPCRTmgJpFTO5XfJ/9L2sLQ6iXvISbX1LoneAxRS81DskaZRpv L2aQbCXjwb86bCU5FBxjZs4Fwmv3qZ6Q/Q4p/9V8a8eH3ZwGWbiTB4CSc0ObUDdFUnEgpkeoMfc xr9H4GsnwG+xvyXlB+d9f/CU1CQ/HsyWVsJqAtcOpV9ZXh4heS1oamiewBpEMSPeZ9wjHJU3wsj WSme1YFAQwleU/8dMHu9C+CwAYo3007O4AukK8k3I1nw0ufiQC06/+z6wXdu5gOCbjzekievvpd mGIWaie5L0wx/TkSInPw6ktfyRoSApaOfEs9tJtRzJH/oGi2TlxGvERziNeaXHCB1iOx/8TfbHp 6iKK1uqGofKVIzw/01nJS4Hd4kEWkEkuIxfov/CldQcWfwPw= X-Received: by 2002:a05:6a00:a24b:b0:7e8:4471:ae77 with SMTP id d2e1a72fcca58-7ff6804bc30mr15661291b3a.67.1766557677775; Tue, 23 Dec 2025 22:27:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHu1FE4J6q5O1UvJoccxuZNXG1nshn0LtkfTYhJX/wOLuef0Tz0VKj3C4Bs4u79XfEmdJChGg== X-Received: by 2002:a05:6a00:a24b:b0:7e8:4471:ae77 with SMTP id d2e1a72fcca58-7ff6804bc30mr15661277b3a.67.1766557677287; Tue, 23 Dec 2025 22:27:57 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7eb85f15sm15618908b3a.68.2025.12.23.22.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 22:27:56 -0800 (PST) From: Dikshita Agarwal Date: Wed, 24 Dec 2025 11:57:12 +0530 Subject: [PATCH 3/6] media: iris: gen1: Destroy internal buffers after FW releases Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251224-iris-fixes-v1-3-5f79861700ec@oss.qualcomm.com> References: <20251224-iris-fixes-v1-0-5f79861700ec@oss.qualcomm.com> In-Reply-To: <20251224-iris-fixes-v1-0-5f79861700ec@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766557663; l=1276; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=LQBwQ5KKiAURRSdH9SPmpV/8R5KpoEVoxpc1FUT4Bqs=; b=sQ3DmktSk8EVWqsjPA2/Ve4wcxGMmspelpgTal7NESaqCdsMXLFwRdhFqDmURH2S/SisZzPG0 yg8VMPk4/PIB3/+DzTqjxF+LUNKqf17Qd8GZmywFcNKrdYuPrEYhUKR X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDA1MyBTYWx0ZWRfX8trvVrDfOY7m WoLvRYdU0ao4qj1GPkROkcZDjwrd4iuZZ9SdFiSgIqXEzMwA3k83Mvt3cCAZxvvLFsZ52LrUjK5 OYaBuyli3IUX/bz+Jbp8Ps5PYiIrArf1zS1JuiCN4qz83lnlFkkR8X/s3e+nueOt19xE8sbx69e DlGCybMkMCnYz802dEwCkcLm7Rhi9AGgDxK+DcUiTOVBSVURd5lFDeP2xTQz1MJhCjM2AC87K0L yEMNY8g9s6wyY4oohx+JxE4JFhw3lIyjlbR9GRL3p0hyr+tGitHCWPZvjxsMRcVFCrc84H8+BIg Xl1bM6uenRoLwT3L/mEaTVMzfmJZ3vzNq/LpISknNMvpL/WgtiVk9Jo4jQHKCyiqqy2D6Ra+4dz wTepyZz/hmD1UrzJjuuk/waFKJLB93BcvnOOm9m0urUGwz2jNx/E4iO7DA+Bu5r5Kmp2evLeq8y II/RUSTISAssEbHP7mg== X-Proofpoint-ORIG-GUID: hcilLsgGSe_WDRpe35Ii9R3trhx42dWT X-Authority-Analysis: v=2.4 cv=WegBqkhX c=1 sm=1 tr=0 ts=694b87ee cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=ClRbyBwZYeV4lDUphtoA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: hcilLsgGSe_WDRpe35Ii9R3trhx42dWT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_02,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 bulkscore=0 adultscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240053 After the firmware releases internal buffers, the driver was not destroying them. This left stale allocations that were no longer used, especially across resolution changes where new buffers are allocated per the updated requirements. As a result, memory was wasted until session close. Destroy internal buffers once the release response is received from the firmware. Fixes: 73702f45db81 ("media: iris: allocate, initialize and queue internal buffers") Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c index 5087e51daa842515e9d62730680fb237bf274efa..5ff71e25597b61587c674142feb99626e402c893 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c @@ -441,6 +441,8 @@ static int iris_hfi_gen1_session_unset_buffers(struct iris_inst *inst, struct ir goto exit; ret = iris_wait_for_session_response(inst, false); + if (!ret) + ret = iris_destroy_internal_buffer(inst, buf); exit: kfree(pkt); -- 2.34.1