From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7251E311588 for ; Wed, 24 Dec 2025 06:28:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766557687; cv=none; b=OUEB2pjROAL2kRv3QN1lPQUGJlg0Jxb4+TdUFYIBitfAuwwFfarkkK9JAwJtmwxsVFSoXBha0WzU4h2uzkobfu7mG4DJ44swLO6lraugo6bGlGteZ9EZDSmFs65DH3OvUId2Gn5nYtn7VhUUGY0wA8lz4DBWd9oU3pOq2Pgbzsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766557687; c=relaxed/simple; bh=uFNt44v16+VNSladcy20KcC0FS/WVmmz9c1Lp4p1lEw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hFYmfQKc8MObuL04IBrgzxdTfpl27SWaPEBjB8fw5M6R62CmyAYDnlZEYW3yv4yGDUyygF7UGx2a6xgqhtDe62NPc8+7jngU9wCfK++xRhUVYMO493niVcwtyqE5lD7Vah1s5epRVXJjeO1YaZFlVJZ/QKyFBLVxnYqDcCMn0zA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=c+gxEcXW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dU54ihDh; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="c+gxEcXW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dU54ihDh" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BNHrcQZ678258 for ; Wed, 24 Dec 2025 06:28:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VUTT93LKzs62jsIB8hKM06ywx/M5I0v8a0LHmaZ71W4=; b=c+gxEcXW19+c/P7i C6Uf4EMG+kSeHQwilmC6r1Eet9jBq3stn78T8HLAkJZAVSUZSZaSdsrL8xYMdYhC t84BldxVJ+Zvi7T1xWzvmgn1XYWCpsf1hYAKFrGFDI0e6dwzsTPBfkvQAntKO8uG 95GXJZrFBghg6WFOz21Tb7AzvPqFeNZXKTmrQdG5khH9bkKNSKYIYNa2dQRmHS/Z bZygtwZrp9ttNp/Xqtrdi594lTmBCHww07LYGYs8qkXfahh/3P1kr0FG2cmY4Eyf vCNzbyTmdnYmGtvL6kEELs0iIImySpGudogYVuzHuac48+2eK/EBe3WrOlu3nWiA paIK9w== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b7yvq1rpg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 24 Dec 2025 06:28:05 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-7a99a5f77e0so9176801b3a.2 for ; Tue, 23 Dec 2025 22:28:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766557685; x=1767162485; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VUTT93LKzs62jsIB8hKM06ywx/M5I0v8a0LHmaZ71W4=; b=dU54ihDhmFhd1v11yCmqrnGFZcOfVQKFQ26aci9f62JcseSbQ04zY2llNc4pljwZvq R/W7JbFxXoSJlcGYf7cVcN1Ou4aVOGIYJy45MWXcxk+IJhFt9uJiajOBx4Q4HolFem9O KQGFOq8qkFXG881tS1MQRfaZVryA1ZODtmxfKmxrME1jg5Y5zY2Wci0Dx0CNaKPYNoP0 20920ZRJ1lrdEvT/+YNgywKbzy8Dc0X6xjqI6JP/z5iMuJcLYdptSrd+4UxdHniSlkvB +yruMIfnI39izjJEJsHkca9xtCgAInNo9wXw8zUD0ZMNxOPMZwgW1pQjgKMKKIjZwHwo xYqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766557685; x=1767162485; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=VUTT93LKzs62jsIB8hKM06ywx/M5I0v8a0LHmaZ71W4=; b=RGBHpqRz+g6k34uCn9EElhz3blIqBZl455tFhRtmVYLY/rPdl6+pSieESEuIydK30d uPuwwE4lDAKJrVlxLNqCrmqXscEgFvlOpwAtLMUX4HXsNWRK5w7IRaMTZ1HPmwyzdFgG QMh9FDR5iZptTN8tI2r5pwHxVEcc3pjd4vzG5oIPwd0zxvNqBAvFHAnTsITW7KKpQW2m epPMTHhsLKaZEhaHomJ4d8u/lM1hjYRyyKLGfVzbFRtHcvYdnqKU3OJeXNEbPtZrEH/U WNyQrYNPnQkBPPUxfRWqHHVbf96Dcgf/IWJ1soL1WJyRhyGcE71O5OdQh8Ooo90KbTuR gZPQ== X-Forwarded-Encrypted: i=1; AJvYcCVKryFZjanT3r8LhgXFnlay+3eP6v+VW4ZEug/mv3YuoUta2YH1Cef+dB+Zq6Psi1KYNbU9htGJIpIPNWs=@vger.kernel.org X-Gm-Message-State: AOJu0YywXU+fcRK89yNRWnipJrYia+sGDf7zPv0urGRSEPOtv44MZWEH I8jgVxypDvTFO1PIPKvlxvWEvOLiQ5ntsp/SSDz/203xpEDx88EGpl9FjufsgFBpIO/A2MHhplL k+W9OBnGxgYY5Ww1iI80GrVd5Ck5T+O+H0tmUU9WjS8VP8DZf7rc+9BtVG6CgCxwiAS8= X-Gm-Gg: AY/fxX6Ak7kLF1mGagtGxxxBfgnEmhWbMW8tN157oO3sB3mUDBPdoxHpJsgLTjPu2b2 ZihjFPRl/YQw0x4vsYXvSbPY/FeIYwSthK5RrPViZ6e9KKtdjQrrFeDQ3OqtU87L5e5wXmTUAj4 v0uiUijCXJtsFVYbb+kC4cIV1f9g75whR+eQRyivMY9kq9Lg1N/V6LrYdyN0m6SFf/iaTyFaAyg gdfClZ3pE7S7r9OBLZa0voE7+wESaky+gUxkLlCWOhT/ZE74AYyKcFhrIX5UoqDwn/0TJhcvD4h deB4KSCVzid3ARYc7uakcurFzUwc0b6kguSAVsJ8/+G+bnqMOLwQ/+5v9ARKIK12v7PgOh40QSb 1ixweAY/+XEnwGxH16ISWcz07h6EYwHOyLalIxe6DAYF5FVs= X-Received: by 2002:a05:6a00:ad08:b0:807:3ce8:58bb with SMTP id d2e1a72fcca58-8073ce85e26mr2495967b3a.12.1766557685183; Tue, 23 Dec 2025 22:28:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IEetZusp4r/t67X4n+UM25nReI7/guSHCsVpzSsGU3LKTeAF+acxysyBkAwTm9CwntmMO1VYQ== X-Received: by 2002:a05:6a00:ad08:b0:807:3ce8:58bb with SMTP id d2e1a72fcca58-8073ce85e26mr2495907b3a.12.1766557683834; Tue, 23 Dec 2025 22:28:03 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7eb85f15sm15618908b3a.68.2025.12.23.22.28.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 22:28:03 -0800 (PST) From: Dikshita Agarwal Date: Wed, 24 Dec 2025 11:57:14 +0530 Subject: [PATCH 5/6] media: iris: gen2: Add sanity check for session stop Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251224-iris-fixes-v1-5-5f79861700ec@oss.qualcomm.com> References: <20251224-iris-fixes-v1-0-5f79861700ec@oss.qualcomm.com> In-Reply-To: <20251224-iris-fixes-v1-0-5f79861700ec@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1766557663; l=1178; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=uFNt44v16+VNSladcy20KcC0FS/WVmmz9c1Lp4p1lEw=; b=9TGR5Pw1RDMwFvktNoiXTDKVAFp1rPowhOUSpIlVuAfAa22mlq46+3ngJw747/AmbbewAmpj9 s6Xu/6ilbKgDxdQEPRQzy3DDnCyiT8qb9Rah1eZmnPB4j79Cwwui1fx X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-ORIG-GUID: H8i5c37ozaakv92SlA8nvLtgOW92TM2a X-Authority-Analysis: v=2.4 cv=abZsXBot c=1 sm=1 tr=0 ts=694b87f5 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=hJpQIKcYsydMz8RtK9gA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-GUID: H8i5c37ozaakv92SlA8nvLtgOW92TM2a X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI0MDA1MyBTYWx0ZWRfXyDvL4ZBrbs/A UtwjQJfvsvCOCSMf0nhCoqinczjCQ9wdaSyWivUS5FaSa0b1FB7KK8I6nL8back7zj+RGQAxSxD amt8XK2w9L0ukTWlYpQIuCqUpHc61jMZ+PRvO/V9cxtW+wnucCCi1rK1GslxzJDAD7hHYkEcR88 LPrYXTCiZ2VUxnySRl+aMP83AuAefeiYE0F4H5RDnzjaxlAgcQjuWKY+TNOsKr13UYxI8qz0Zq2 p73tEzjAT/KyYaVNXClWJp/ZebsCzHI7JQsvgz0u0RjW9qG5xsVHIondHMlGfEu6cfEqHkzG80/ cPlxlOmrGlV/wyrZp455/S5eRbEENJ3djGxHzgyHBWN0NmSJLDV3n3Ff75+Tv9GVNs7q53SNILL D7MdDBfiN+X4e72QMt1EPjYfS0OoYxiiJmd6umW/JnL2USKCfMn7vRqW/DjshMztW7h0y3eZiZn 3bLBRK4iJFr4gEi0IgQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-24_02,2025-12-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512240053 In iris_kill_session, inst->state is set to IRIS_INST_ERROR and session_close is executed, which will kfree(inst_hfi_gen2->packet). If stop_streaming is called afterward, it will cause a crash. Add a NULL check for inst_hfi_gen2->packet before sendling STOP packet to firmware to fix that. Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c index 6a772db2ec33fb002d8884753a41dc98b3a8439d..59e41adcce9aadd7c60bb1d369d68a4954f62aef 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -963,6 +963,9 @@ static int iris_hfi_gen2_session_stop(struct iris_inst *inst, u32 plane) struct iris_inst_hfi_gen2 *inst_hfi_gen2 = to_iris_inst_hfi_gen2(inst); int ret = 0; + if (!inst_hfi_gen2->packet) + return -EINVAL; + reinit_completion(&inst->completion); iris_hfi_gen2_packet_session_command(inst, -- 2.34.1