From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A9671E7C23 for ; Wed, 24 Dec 2025 00:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766535391; cv=none; b=GQMSCCY+JD6jLLmVeQdFiSUMUWvv8adRIPSeabXP20WiAIVbET7u4aNIymOhKWMR4cooh+OX2V3hK/HsFSrxPFlXK+j/wvNxwToQbpwCatdAQjQpQYw7hFxAkhVr63v7FbNzuSnF2WnMGq3Yh0Z6H1PjYVK3u2BUByK+Pl7Rqs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766535391; c=relaxed/simple; bh=upD/4x6ibpw6R+WdTgLKMfphzj7tz4P2ER3fffkh/Cs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nUsLEVWBB/lZNDdPwN7HGQ2lrOtvWZmw2R/LhkMQENfxSnY4R9LT+L64ia1ZW1RHQcHo98vVcwN9ruxfgXV3ly7xwstqGOqKf5nOSYXe8QHf8BTdSwi/20b/zMyyXHkeCDisOX6dCghpn2uWM9NXe/jMWr3n1IPy3oRaWHBYc/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YEyXu1Rj; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YEyXu1Rj" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2a2ea96930cso61959315ad.2 for ; Tue, 23 Dec 2025 16:16:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1766535387; x=1767140187; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/3as0KK9jiK9MBOY9ErKWGFvvWPWhqUzqXP/S7u5uac=; b=YEyXu1Rj3j/t60ETlcEEpdwtJuUul/v3uUxxmT49prhCaFxDilUABRTjVhRYX1Ohjg UCNrkBCDy5Vyt9aNXGhb4lSlRoyhjgzZgqKkD+g/+Mn4x1IndkKUEpz24IrHvz39KWTa spXwauOiCD/VC4625M7PEXdnTA2m4jNg+dNGxamskxKTLtzzAKbN5KLfOch42a7kgtvE O6WDpv83QpK8xq0BHBJ8fVqVFWUj8JbNhEiM2qfd8x11yrM0KHBqRiShCeC4L65PdTF7 MckHVCBfi6fDHlnWuorL4ObCuIftS01zArjr2u/zXmiUFX1xu6r5xqCEf6bLvwDsPBrV b3aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766535387; x=1767140187; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/3as0KK9jiK9MBOY9ErKWGFvvWPWhqUzqXP/S7u5uac=; b=wHbujbpX4EYuO6u3JUlquk1LgPTvx/FF/LgbdlM4kb7MMlaMVaknXRanE+ofh8CKuN wmtYgTpQY4Ap33QduMkYuFMJ/c9PT0aYgT5BOdAUstqjn652E62FOuEmMSQ34us9UiiK lrauabmYA/fBMoQ5P4ICd9AO31+oZKmkEG799QJIzWDAr0MGtq26YcJ4aXHGAtXwOSYF 47cFDr1pCkmpKW4IjQFfl2LFl9VSrCUysUb1jv4tfnxz0HKO+7CaEaeiSShZwVGhVSzl wMxZt4x52+YSJLIGXIFlDRRuCDiLAIQKYGrvVirYzuU1+5qFF9tEx4sfSvOT2QbxADQ3 nPrg== X-Forwarded-Encrypted: i=1; AJvYcCXm5jsw+tyn6smtF3Ss548t5YSVHZdc4v2yQkvxyJVMKBShUi2DfT3Z1tljrNreTLT9Xb6Ki/Amb6c5eHo=@vger.kernel.org X-Gm-Message-State: AOJu0YyVhKHsB+7RK2jj7Q+qcatN27RDWYSO1De/fj/aYHvQPlGLmNo9 SbPsEuAes4h3sxc+H24Kog+0i0II1OUADa+BreitCSXrXfChNST/jGdiF4elX0Bq X-Gm-Gg: AY/fxX4uyoWh0uAIBb77Q+Qg9rx5AwtMJi12ItAJDq9W/Y1XssZO6YjyaHSSuq7HbtB HWI9hd5xjWsyuEfty5HINZgtRldv6IMCR3vTY0Z1kcJPjy5wlLubWMpY/ff+WezWMnkNg24JQIr dTPSpo9XzzN0lDcE8v+o2n88Ro3ORG4VnSKHOQzSBgCsMJyctmSWGOrnU++6hhHq4Bv9LST/QGp TT30/AjiOfko7MQwj6WOKc/EImvORU5G/wPuhBPRfSMNA6NVeNeNXqGaAa9+TNAT4tNQCszvwkN jmQUu701vfQnHQp4Rxr4xEqm1o3hQOYTy/4ZU7Rx9H4OryJAuA++oP+Pwtcx8FgRWWt41Z0tXZ6 N10ipDbSKwWKX+7jnA+9f4iXcOmx/O4oiu/gldVwV/96kUWocosDUQkBHKihBZqaMrBWzzqQYy6 s/wpqbqDFTPl4C X-Google-Smtp-Source: AGHT+IGx+27QTffUYdLS3J+w0/bNQA8s35EwyjT+BuL3pLFC3ge5l6vQiYv7HpHnMcjPR2qm/DaA9A== X-Received: by 2002:a17:903:2441:b0:2a0:941a:6b08 with SMTP id d9443c01a7336-2a2f2231aa1mr157311945ad.21.1766535387372; Tue, 23 Dec 2025 16:16:27 -0800 (PST) Received: from barry-desktop.hub ([47.72.129.29]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ff7e797787sm14756538b3a.60.2025.12.23.16.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Dec 2025 16:16:26 -0800 (PST) From: Barry Song <21cnbao@gmail.com> To: pfalcato@suse.de Cc: 21cnbao@gmail.com, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, bhe@redhat.com, chrisl@kernel.org, hughd@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, nphamcs@gmail.com, shikemeng@huaweicloud.com, syzbot+178fff6149127421c2cc@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [mm?] KMSAN: uninit-value in swap_writeout Date: Wed, 24 Dec 2025 13:16:16 +1300 Message-ID: <20251224001617.45293-1-21cnbao@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <7ng6tntadu62ls32r54aetyevgbghta4oufyzxtq5ym6bprjai@hc2ozb2mbcyb> References: <7ng6tntadu62ls32r54aetyevgbghta4oufyzxtq5ym6bprjai@hc2ozb2mbcyb> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Wed, Dec 24, 2025 at 12:43 PM Pedro Falcato wrote: > > On Wed, Dec 24, 2025 at 11:46:44AM +1300, Barry Song wrote: > > > > > > Uninit was created at: > > >  __alloc_frozen_pages_noprof+0x421/0xab0 mm/page_alloc.c:5233 > > >  alloc_pages_mpol+0x328/0x860 mm/mempolicy.c:2486 > > >  folio_alloc_mpol_noprof+0x56/0x1d0 mm/mempolicy.c:2505 > > >  shmem_alloc_folio mm/shmem.c:1890 [inline] > > >  shmem_alloc_and_add_folio+0xc56/0x1bd0 mm/shmem.c:1932 > > >  shmem_get_folio_gfp+0xad3/0x1fc0 mm/shmem.c:2556 > > >  shmem_get_folio mm/shmem.c:2662 [inline] > > >  shmem_symlink+0x562/0xad0 mm/shmem.c:4129 > > >  vfs_symlink+0x42f/0x4c0 fs/namei.c:5514 > > >  do_symlinkat+0x2ae/0xbb0 fs/namei.c:5541 > > > > +Hugh and Baolin. > > > > This happens in the shmem symlink path, where newly allocated > > folios are not cleared for some reason. As a result, > > is_folio_zero_filled() ends up reading uninitialized data. > > > > I'm not Hugh nor Baolin, but I would guess that letting > is_folio_zero_filled() skip/disable KMSAN would also work. Since all we want > is to skip writeout if the folio is zero, whether it is incidentally zero, or not, > does not really matter, I think. Hi Pedro, thanks! You’re always welcome to chime in. You are probably right. However, I still prefer the remaining data to be zeroed, as it may be more compression-friendly. Random data could potentially lead to larger compressed output, whereas a large area of zeros would likely result in much smaller compressed data. Not quite sure if the below can fix the issue: diff --git a/mm/shmem.c b/mm/shmem.c index ec6c01378e9d..0ca2d4bffdb4 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -4131,6 +4131,7 @@ static int shmem_symlink(struct mnt_idmap *idmap, struct inode *dir, goto out_remove_offset; inode->i_op = &shmem_symlink_inode_operations; memcpy(folio_address(folio), symname, len); + memset(folio_address(folio) + len, 0, folio_size(folio) - len); folio_mark_uptodate(folio); folio_mark_dirty(folio); folio_unlock(folio); > > -- > Pedro Thanks Barry