From: Yixun Lan <dlan@gentoo.org>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] dt-bindings: pinctrl: spacemit: add K3 SoC support
Date: Wed, 24 Dec 2025 11:04:14 +0800 [thread overview]
Message-ID: <20251224030414-GYA1992051@gentoo.org> (raw)
In-Reply-To: <8840B91CE3D9278B+aUtWX6fizXnheGMl@kernel.org>
Hi Troy,
On 10:56 Wed 24 Dec , Troy Mitchell wrote:
> Hi Yixun,
>
> On Sat, Dec 20, 2025 at 06:14:53PM +0800, Yixun Lan wrote:
> > Add new compatible string for SpacemiT K3 SoC, the pinctrl IP shares
> > almost same logic with previous K1 generation, but has different register
> > offset and pin configuration, for example the drive strength and
> > schmitter trigger settings has been changed.
> >
> > Signed-off-by: Yixun Lan <dlan@gentoo.org>
> > ---
> > Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> > index d80e88aa07b4..c5b0218ad625 100644
> > --- a/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> > +++ b/Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml
> > @@ -11,7 +11,9 @@ maintainers:
> >
> > properties:
> > compatible:
> > - const: spacemit,k1-pinctrl
> > + enum:
> > + - spacemit,k1-pinctrl
> > + - spacemit,k3-pinctrl
> The drive-strength description should be updated. The driver uses a
> different current table between K1 and K3, but the binding description does not
> mention K3.
>
yes, I realised already, will update in next version
--
Yixun Lan (dlan)
next prev parent reply other threads:[~2025-12-24 3:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-20 10:14 [PATCH RFC 0/3] pinctrl: spacemit: add support for K3 SoC Yixun Lan
2025-12-20 10:14 ` [PATCH RFC 1/3] dt-bindings: pinctrl: spacemit: add K3 SoC support Yixun Lan
2025-12-24 2:56 ` Troy Mitchell
2025-12-24 3:04 ` Yixun Lan [this message]
2025-12-20 10:14 ` [PATCH RFC 2/3] pinctrl: spacemit: k3: add initial pin support Yixun Lan
2025-12-22 6:59 ` Troy Mitchell
2025-12-22 23:03 ` Yixun Lan
2025-12-23 1:04 ` Troy Mitchell
2025-12-20 10:14 ` [PATCH RFC 3/3] pinctrl: spacemit: k3: adjust drive strength and schmitter trigger Yixun Lan
2025-12-22 2:54 ` Troy Mitchell
2025-12-22 3:52 ` Yixun Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251224030414-GYA1992051@gentoo.org \
--to=dlan@gentoo.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=troy.mitchell@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox