Re: [PATCH v2 5/5] mm/damon/tests/core-kunit: remove a redundant test case and add a new test case in damos_test_commit_quota_goal()

SeongJae Park
2025-12-24T05:35:20Z

On Wed, 24 Dec 2025 04:22:00 +0000 Shu Anzai <shu17az@gmail.com> wrote:

> Remove a redundant test case from damos_test_commit_quota_goal()
> as it is already covered. Instead, add a new test for
> DAMOS_QUOTA_SOME_MEM_PSI_US, which was previously not tested.
>
> Signed-off-by: Shu Anzai <shu17az@gmail.com>
> ---
> mm/damon/tests/core-kunit.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
> index 36622a2c11f1..4bf1d172436b 100644
> --- a/mm/damon/tests/core-kunit.h
> +++ b/mm/damon/tests/core-kunit.h
> @@ -601,9 +601,10 @@ static void damos_test_commit_quota_goal(struct kunit *test)
> });
> damos_test_commit_quota_goal_for(test, &dst,
> &(struct damos_quota_goal) {
> - .metric = DAMOS_QUOTA_USER_INPUT,
> - .target_value = 789,
> - .current_value = 12,
> + .metric = DAMOS_QUOTA_SOME_MEM_PSI_US,
> + .target_value = 234,
> + .current_value = 345,
> + .last_psi_total = 567,
> });
> }
>
> --
> 2.43.0

Reviewed-by: SeongJae Park <sj@kernel.org>

Thanks,
SJ