Re: [PATCH v2 0/5] mm/damon/tests/core-kunit: extend existing test scenarios

SeongJae Park
2025-12-24T05:38:40Z

On Wed, 24 Dec 2025 04:21:55 +0000 Shu Anzai <shu17az@gmail.com> wrote:

> Improve the KUnit test coverage for DAMON.
>
> The five patches in this series respectively extend damon_test_split_at(),
> damon_test_merge_two(), damon_test_merge_regions_of(),
> damon_test_split_regions_of(), and damos_test_commit_quota_goal().
>
> Changes from v1:
> - Split the original patch into five smaller patches.
> - Remove a newly added region from damon_test_merge_regions_of()
> to avoid an obvious test case.
> - Restore the test case in damon_test_split_regions_of()
> that was previously removed.

Thank you for revisioning, Shu!

>
> Shu Anzai (5):
> mm/damon/tests/core-kunit: verify the 'age' field in
> damon_test_split_at()
> mm/damon/tests/core-kunit: verify the 'age' and 'nr_accesses_bp'
> fields in damon_test_merge_two()
> mm/damon/tests/core-kunit: add a test case for region merge size limit
> in damon_test_merge_regions_of()
> mm/damon/tests/core-kunit: add test cases for multiple regions in
> damon_test_split_regions_of()

I left a trivial comment on this fourth patch for unnecessary braces enclosing
a single statement. Other than that, all look good to me.

> mm/damon/tests/core-kunit: remove a redundant test case and add a new
> test case in damos_test_commit_quota_goal()
>
> mm/damon/tests/core-kunit.h | 50 +++++++++++++++++++++++++++++--------
> 1 file changed, 39 insertions(+), 11 deletions(-)
>
> --
> 2.43.0

Thanks,
SJ …