From: Matthew Maurer <mmaurer@google.com>
To: "Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Maurer <mmaurer@google.com>,
Daniel Almeida <daniel.almeida@collabora.com>
Subject: [PATCH v3 0/4] Support more safe `AsBytes`/`FromBytes` usage
Date: Fri, 26 Dec 2025 21:08:19 +0000 [thread overview]
Message-ID: <20251226-transmute-v3-0-c69a81bf8621@google.com> (raw)
Currently:
* Slices of `AsBytes`/`FromBytes` types cannot be synthesized from
bytes slices (without unsafe).
* Users must use `unsafe impl` to assert that structs are `AsBytes` or
`FromBytes` and write appropriate justifications.
* Bindgen-generated types cannot implement `AsBytes` or `FromBytes`,
meaning that casting them to or from bytes involves assumptions in the
`unsafe impl` that could easily go out of sync if the underlying
header is edited or an assumption is invalid on a platform the author
did not consider.
This series seeks to address all there of these by:
1. Adding slice cast functions to `FromBytes`
2. Adding a derive for `AsBytes` and `FromBytes`, for now restricted to
the simple case of structs.
3. Refactoring the crate structure to move `AsBytes` and `FromBytes` to
`ffi` to allow `bindings` and `uapi` to reference them.
4. Enabling bindgen derivation in `bindings`/`uapi` through `AsBytesFfi`
and `FromBytesFfi`.
1+2 can be landed separately if needed, 3 has no purpose without 4, and
3+4 need 1+2.
Signed-off-by: Matthew Maurer <mmaurer@google.com>
---
Changes in v3:
- Explained the `for<'a>` usage in the where clauses generated by macro.
- Split bindgen support into two commits, one which does the crate
migration and one which enables it.
- Link to v2: https://lore.kernel.org/r/20251216-transmute-v2-0-b23e5277ad02@google.com
Changes in v2:
- Reworked to put `transmute` in `ffi` rather than creating a new crate,
per Alice's comment on Zulip.
- Switched to new kernel import style.
- Link to v1: https://lore.kernel.org/r/20251212-transmute-v1-0-9b28e06c6508@google.com
---
Matthew Maurer (4):
rust: transmute: Support transmuting slices of AsBytes/FromBytes types
rust: transmute: Add support for deriving `AsBytes` and `FromBytes`
rust: transmute: Migrate AsBytes/FromBytes to ffi crate for bindgen
rust: transmute: Support deriving AsBytes/FromBytes on bindgen types
rust/Makefile | 14 ++++---
rust/bindgen_parameters | 8 ++++
rust/bindings/lib.rs | 4 ++
rust/{ffi.rs => ffi/lib.rs} | 5 +++
rust/{kernel => ffi}/transmute.rs | 72 +++++++++++++++++++++++++++++++++
rust/kernel/lib.rs | 2 +-
rust/macros/lib.rs | 83 +++++++++++++++++++++++++++++++++++++++
rust/macros/transmute.rs | 67 +++++++++++++++++++++++++++++++
rust/uapi/lib.rs | 4 ++
scripts/generate_rust_analyzer.py | 2 +-
10 files changed, 254 insertions(+), 7 deletions(-)
---
base-commit: 008d3547aae5bc86fac3eda317489169c3fda112
change-id: 20251212-transmute-8ab6076700a8
Best regards,
--
Matthew Maurer <mmaurer@google.com>
next reply other threads:[~2025-12-26 21:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-26 21:08 Matthew Maurer [this message]
2025-12-26 21:08 ` [PATCH v3 1/4] rust: transmute: Support transmuting slices of AsBytes/FromBytes types Matthew Maurer
2025-12-26 21:08 ` [PATCH v3 2/4] rust: transmute: Add support for deriving `AsBytes` and `FromBytes` Matthew Maurer
2025-12-26 21:08 ` [PATCH v3 3/4] rust: transmute: Migrate AsBytes/FromBytes to ffi crate for bindgen Matthew Maurer
2025-12-26 21:08 ` [PATCH v3 4/4] rust: transmute: Support deriving AsBytes/FromBytes on bindgen types Matthew Maurer
2026-04-30 0:27 ` [PATCH v3 0/4] Support more safe `AsBytes`/`FromBytes` usage Alexandre Courbot
2026-04-30 3:22 ` Matthew Maurer
2026-04-30 8:09 ` Miguel Ojeda
2026-04-30 8:24 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251226-transmute-v3-0-c69a81bf8621@google.com \
--to=mmaurer@google.com \
--cc=a.hindborg@kernel.org \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox