From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17A0E2F872 for ; Fri, 26 Dec 2025 19:33:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766777614; cv=none; b=aXbwUYCe8DOsnRR0MmGozVIuOo7xxKTIFD4vSqjx4Tf/MqBBpnLHdvXDEGordFQruKqZjyYeAubyPXq9vdpTa5POTDfB1yOU/bSYSlX1eu9qh1RgAM/FNr269NeYKyZG7kX4UQw2VYG/SDtLVFKkpE5P4g9rnx3X+Jo3VyR5oIc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766777614; c=relaxed/simple; bh=5fVnAIeZHthLRORMu0oztvCUwm7xHuaXIFzj7J4LDu0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C6JZX0wve5XuTwAEhgoCO9bslDmQHYO3wWNzHj/QnRorbXEkFosSUKJW/DuAdEvdNlErxSX+YN030/P5uQ2T0PEtMmSTwG277aW9fu40gf8epiYayW/j8xVLo5WTg4aks0uU4qcAZ0uwEcXFHRH9degDUA/QPr2mWKmJlzVfQ4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Eh/KNtEy; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=QcnBuvKk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Eh/KNtEy"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="QcnBuvKk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766777612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bZflj0ypuZMjd4aOAPAMll6XFz/uRsOFnhPNAPsy618=; b=Eh/KNtEyuBvviHhwmeSiziWmvUAOnB6r8+HdUxV4fbeQOoDW7625y5QyGqLbR3lv6D4XTc 9ux28x753oJCgOoW3ShHJqm+cdN1t1ZOsen40gXjQp9ydm7U9EmN+rTYthcXXwNoC4nkla P2DJOfoeNnV6y6C1REFdfmpFZXNjVtc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454--EIwTACNPHW-LgDS0xlU5g-1; Fri, 26 Dec 2025 14:33:30 -0500 X-MC-Unique: -EIwTACNPHW-LgDS0xlU5g-1 X-Mimecast-MFC-AGG-ID: -EIwTACNPHW-LgDS0xlU5g_1766777609 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4779b432aecso42815485e9.0 for ; Fri, 26 Dec 2025 11:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766777609; x=1767382409; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=bZflj0ypuZMjd4aOAPAMll6XFz/uRsOFnhPNAPsy618=; b=QcnBuvKkhQdn44jpAi+K6/w0HrAOLI4YcYexrjsoXbCtEZ+QRxph54RGrc/1T1xqtS WdC3eIOKIh8D4Eobg/lD27pqHX3jcMncJpfUb1r8dQaBqDH65UR5L/Ze4mKKDP11sbEZ BQExms5uO1BRUpKPDywLJZN5+gSj0pCzJWi+LndAISP9jL+zE+yX9nd2hBiXYQ9GCb22 bnjU413Ot052hvDyXuG8ZY+jqm5Z0b4W+9+a5iNyw6R4rgxWkCoKX3nUxIn6RpWzA+VS uvcVmU70tjRRKfo5mTJlGNHNQ4w+ae9RWvASvXQXmR1b6hzbm0ISh2e9cCW1/VaP5+6K FT5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766777609; x=1767382409; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bZflj0ypuZMjd4aOAPAMll6XFz/uRsOFnhPNAPsy618=; b=OB744otmTmz4f1TH5y/JRoRZAHZzopqkrCDlglm46eqjCsfo3QoS7BoWbu4EoLtMfC eilpZOWQzoswLg18plVytQJ39SEDfOwhIfmsAqlHl/ibpbHu8qrGd0dUMU79q3mJLfO2 omYwBq+I1nZt67jaFZeEQcE6CYAoZ5l1Ct/Ktk6DXMQdbpIdix+WoM6QA4Dq8XK2pDWy xzQfKpCm2xV/yBHHeNIYz8ZOwAieYBsu+Hwbh9y1HJGIt+chuzNUBdvWFOjPdz4yKP+z xZmrw03DPBkqRb8D3DJQPXHePQgsqFYK5YZy4WTllvFW58uLq1virBS440Gg/L8jKSJO n1uQ== X-Forwarded-Encrypted: i=1; AJvYcCXRz7Aj8ep9gjYaa8E6OaalnxCxTWzH8ExG+2ax3EEyuoR4GqrZ305X14/q1SL4qk91RWL3/skRH2ombgo=@vger.kernel.org X-Gm-Message-State: AOJu0YxLdu8d3PfMr4z+QoTf8cxCLdGDWkstD48hULfOWk+aVejgyEs3 PmAZVPjGuhZ0kp5l/IeADK4u32abj4ZSq9ycl7XKakNFc1gXaih9DpQYk8WWIgprRLZBA5ocs+J 0wIerI7tbsA7tPws0fPjIcaPiBmWBWum4EiQvdRAGQwMdYFDefCeN9xlQc62n2jEb0QGoo3d+QQ == X-Gm-Gg: AY/fxX4gx7DOx6T3VRSzdKGB9w6EiWRRYqVdezlyHcVfjnYlG7z88rn9vldt6XKtvpk b/wqSmrjSlVE1rPBihFd+WQFeGe6HxvDnhJ2rsKpWYMvZhEPYPo73ph5vyen5NKrJ1osRiiruAf 6iZRG1DUa2AajDr5VmbHuVv2z7Xn4p0WxWeoa6mxxM4ySSg8fPB/pZLKiQIS+Yam8XqrEMMKzDD +9Sll6CHlFTj/9/UHC3rxQGlyvzJMLQQenG/gLTyokEIaHKq/IX67Yt4nVO+p2D2xENCUCV/ucJ Wodv1jKBD6c4HRJKThjjl3YVBFp6i9y6axPCz/oD2btazZnRmS0Bkw85ct8+EF9UnBoqy7NLrEw 2SiU/rF/SSENUorFQa/tqXqFAqCR4Me+K4w== X-Received: by 2002:a05:600c:8719:b0:471:114e:5894 with SMTP id 5b1f17b1804b1-47d1958575amr247219705e9.25.1766777609106; Fri, 26 Dec 2025 11:33:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IHBZx0PZwJpXdtLqCjfrlLsx3P1IV5TV8i8HHRefbTs7XqxfTkvlvX2rgTd7fN9hlHElI6fGA== X-Received: by 2002:a05:600c:8719:b0:471:114e:5894 with SMTP id 5b1f17b1804b1-47d1958575amr247219525e9.25.1766777608688; Fri, 26 Dec 2025 11:33:28 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be27b0d5asm460396025e9.13.2025.12.26.11.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Dec 2025 11:33:28 -0800 (PST) Date: Fri, 26 Dec 2025 14:33:25 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: xuanzhuo@linux.alibaba.com, eperezma@redhat.com, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH V11 14/19] virtio_ring: determine descriptor flags at one time Message-ID: <20251226143309-mutt-send-email-mst@kernel.org> References: <20251225042608.32350-1-jasowang@redhat.com> <20251225042608.32350-15-jasowang@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251225042608.32350-15-jasowang@redhat.com> On Thu, Dec 25, 2025 at 12:26:03PM +0800, Jason Wang wrote: > Let's determine the last descriptor by counting the number of sg. This > would be consistent with packed virtqueue implementation and ease the > future in-order implementation. > > Acked-by: Eugenio Pérez > Reviewed-by: Xuan Zhuo > Signed-off-by: Jason Wang > --- > drivers/virtio/virtio_ring.c | 28 +++++++++++++--------------- > 1 file changed, 13 insertions(+), 15 deletions(-) > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > index 4e905dc7b6cb..dbcd6f26df7d 100644 > --- a/drivers/virtio/virtio_ring.c > +++ b/drivers/virtio/virtio_ring.c > @@ -575,7 +575,7 @@ static inline int virtqueue_add_split(struct vring_virtqueue *vq, > struct vring_desc_extra *extra; > struct scatterlist *sg; > struct vring_desc *desc; > - unsigned int i, n, avail, descs_used, prev, err_idx; > + unsigned int i, n, avail, descs_used, err_idx, sg_count = 0; > int head; > bool indirect; > > @@ -635,42 +635,40 @@ static inline int virtqueue_add_split(struct vring_virtqueue *vq, > for (sg = sgs[n]; sg; sg = sg_next(sg)) { > dma_addr_t addr; > u32 len; > + u16 flags = 0; > + > + if (++sg_count != total_sg) > + flags |= VRING_DESC_F_NEXT; > > if (vring_map_one_sg(vq, sg, DMA_TO_DEVICE, &addr, &len, premapped)) > goto unmap_release; > > - prev = i; > /* Note that we trust indirect descriptor > * table since it use stream DMA mapping. > */ > - i = virtqueue_add_desc_split(vq, desc, extra, i, addr, len, > - VRING_DESC_F_NEXT, > - premapped); > + i = virtqueue_add_desc_split(vq, desc, extra, i, addr, > + len, flags ,premapped); coding style violation. > } > } > for (; n < (out_sgs + in_sgs); n++) { > for (sg = sgs[n]; sg; sg = sg_next(sg)) { > dma_addr_t addr; > u32 len; > + u16 flags = VRING_DESC_F_WRITE; > + > + if (++sg_count != total_sg) > + flags |= VRING_DESC_F_NEXT; > > if (vring_map_one_sg(vq, sg, DMA_FROM_DEVICE, &addr, &len, premapped)) > goto unmap_release; > > - prev = i; > /* Note that we trust indirect descriptor > * table since it use stream DMA mapping. > */ > - i = virtqueue_add_desc_split(vq, desc, extra, i, addr, len, > - VRING_DESC_F_NEXT | > - VRING_DESC_F_WRITE, > - premapped); > + i = virtqueue_add_desc_split(vq, desc, extra, i, addr, > + len, flags, premapped); > } > } > - /* Last one doesn't continue. */ > - desc[prev].flags &= cpu_to_virtio16(vq->vq.vdev, ~VRING_DESC_F_NEXT); > - if (!indirect && vring_need_unmap_buffer(vq, &extra[prev])) > - vq->split.desc_extra[prev & (vq->split.vring.num - 1)].flags &= > - ~VRING_DESC_F_NEXT; > > if (indirect) { > /* Now that the indirect table is filled in, map it. */ > -- > 2.31.1