From: Jason Gunthorpe <jgg@nvidia.com>
To: Linus Heckemann <linus@schreibt.jetzt>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Kevin Tian <kevin.tian@intel.com>,
Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>,
Fenghua Yu <fenghuay@nvidia.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Zhou Wang <wangzhou1@hisilicon.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
Yi Liu <yi.l.liu@intel.com>
Subject: Re: [PATCH v5 2/8] iommu: Remove IOMMU_DEV_FEAT_SVA
Date: Mon, 29 Dec 2025 21:19:16 -0400 [thread overview]
Message-ID: <20251230011916.GB23056@nvidia.com> (raw)
In-Reply-To: <ygaqzsib7bc.fsf@localhost>
On Thu, Dec 25, 2025 at 10:05:59PM +0100, Linus Heckemann wrote:
> It appears the code removed here was not in fact entirely dead; my 2024
> gpd win mini ("G1617-01", with a Ryzen 8840U) fails to suspend
> correctly, and I bisected the issue to this commit.
The only behavior change this patch had that could be relavent to a
Ryzen was in drivers/accel/amdxdna/aie2_pci.c - are you using this
driver?
Prior to this patch amdxdna would have failed to load in configs
without an iommu as iommu_dev_enable_feature() would have
failed. After this patch it will load successfully.
If so then that driver presmuably doesn't have working power
management in your system.
Jason
next prev parent reply other threads:[~2025-12-30 1:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 8:01 [PATCH v5 0/8] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF Lu Baolu
2025-04-18 8:01 ` [PATCH v5 1/8] iommu/arm-smmu-v3: Put iopf enablement in the domain attach path Lu Baolu
2025-04-18 8:01 ` [PATCH v5 2/8] iommu: Remove IOMMU_DEV_FEAT_SVA Lu Baolu
2025-12-25 21:05 ` Linus Heckemann
2025-12-30 1:19 ` Jason Gunthorpe [this message]
2026-01-16 12:00 ` amdxdna breaks suspend (was: Re: [PATCH v5 2/8] iommu: Remove IOMMU_DEV_FEAT_SVA) Linus Heckemann
2026-01-16 15:27 ` Alex Deucher
2026-01-16 16:02 ` Jason Gunthorpe
2026-01-16 17:01 ` Lizhi Hou
2025-04-18 8:01 ` [PATCH v5 3/8] iommu/vt-d: Put iopf enablement in domain attach path Lu Baolu
2025-04-18 8:01 ` [PATCH v5 4/8] iommufd/selftest: " Lu Baolu
2025-04-18 8:01 ` [PATCH v5 5/8] dmaengine: idxd: Remove unnecessary IOMMU_DEV_FEAT_IOPF Lu Baolu
2025-04-18 8:01 ` [PATCH v5 6/8] uacce: " Lu Baolu
2025-04-18 8:01 ` [PATCH v5 7/8] iommufd: " Lu Baolu
2025-04-18 8:01 ` [PATCH v5 8/8] iommu: Remove iommu_dev_enable/disable_feature() Lu Baolu
2025-04-18 20:23 ` Nicolin Chen
2025-04-21 6:00 ` [PATCH v5 0/8] iommu: Remove IOMMU_DEV_FEAT_SVA/_IOPF Zhangfei Gao
2025-04-28 11:05 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251230011916.GB23056@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=fenghuay@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linus@schreibt.jetzt \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vkoul@kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox