Re: [PATCH v2 06/11] dt-bindings: display: panel: Describe Samsung SOFEF03-M DDIC

Rob Herring
2025-12-30T01:54:01Z

On Sun, Dec 28, 2025 at 11:49:13PM +0100, Marijn Suijten wrote:
> On 2025-12-22 09:36:23, Krzysztof Kozlowski wrote:
> > On 22/12/2025 09:33, Krzysztof Kozlowski wrote:
> > >> + - |
> > >> + #include <dt-bindings/gpio/gpio.h>
> > >> +
> > >> + dsi {
> > >> + #address-cells = <1>;
> > >> + #size-cells = <0>;
> > >> + panel@0 {
> > >> + compatible = "samsung,sofef03-m-amb609vp01";
> > >> + reg = <0>;
> > >> +
> > >> + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>;
> > >> +
> > >> + vci-supply = <&vreg_l11c_3p0>;
> > >> + vddio-supply = <&vreg_l14a_1p8>;
> > >> +
> > >> + port {
> > >
> > > Not tested :/
> >
> > Ah no, this one is correct. It's the other patch with similar compatible
> > which was not tested.
>
> I think you mean:
>
> .output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml
> .output/Documentation/devicetree/bindings/display/panel/samsung,ana6707.example.dtb: panel@0 (samsung,ana6707-amb650yl01): 'port' is a required property
> from schema $id: http://devicetree.org/schemas/display/panel/samsung,ana6707.yaml
>
> Which looks to be fixed by including panel-common-dual.yaml and changing `port`
> to `ports` in the properties and required table? At least the errors are gone,
> just asking if that is acceptable.

Considering it's a dual interface panel, yes, that's the right change.

Rob