Re: [PATCH v2 07/11] drm/panel: Add panel driver for Samsung SOFEF03-M DDIC

Marijn Suijten
2025-12-24T09:43:51Z

On 2025-12-22 00:32:13, Marijn Suijten wrote:
...
> +static int samsung_sofef03_m_probe(struct mipi_dsi_device *dsi)
> +{
...
> + ctx->vddio = devm_regulator_get(dev, "vddio");
> + if (IS_ERR(ctx->vddio))
> + return dev_err_probe(dev, PTR_ERR(ctx->vddio),
> + "Failed to get vddio regulator\n");
> +
> + ctx->vci = devm_regulator_get(dev, "vci");
> + if (IS_ERR(ctx->vci))
> + return dev_err_probe(dev, PTR_ERR(ctx->vci),
> + "Failed to get vci regulator\n");
> +

In case someone wonders why this is inconsistently *NOT* using regulator_bulk
while the other patches are; this was a last-minute clean-up whose fixup! commit
I seem to have lost in a separate branch. This will be incorporated in v3
together with the whitespace fix in the comment.

- Marijn