Re: [PATCH v2 05/11] drm/panel: Add panel driver for Samsung SOFEF01 DDIC

Marijn Suijten
2025-12-26T14:16:31Z

On 2025-12-26 14:21:37, Linus Walleij wrote:
...
> Only nitpicks follow:
>
> > + if (ctx->panel_type == PANEL_TYPE_TC01 ||
> > + ctx->panel_type == PANEL_TYPE_UT01 ||
> > + ctx->panel_type == PANEL_TYPE_UT04) {
> > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xf0, 0x5a, 0x5a);
>
> The sofef00 driver tell us exactly what this sequence is:
>
> #define sofef00_test_key_on_lvl2(ctx) \
> mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0x5a, 0x5a)
> #define sofef00_test_key_off_lvl2(ctx) \
> mipi_dsi_dcs_write_seq_multi(ctx, 0xf0, 0xa5, 0xa5)
>
> I would just rename these two to sofef01_test_key_on/off_lvl2()
> and use the same helpers in this driver to follow the sofef00 pattern.

Right, yes. I think I already brought this up in V1, that some existing
Samsung drivers call this (the 0xf0 part) the MCS PASSWORD, others call it the
LEVEL_2_KEY or USER_KEY or ACCESSPROT.

I'm curious (though should probably look up the patch history) where these names
come from, which of these names match the sofef01/03/souxp00 DDICs provided
here, and what they're supposed to mean (MCS: Magic Command Sequence?).

Then there are possibly a lot more constants we can glean from other drivers,
though again without confirmation that it's identical on this DDIC.

- Marijn