Re: [PATCH] fs: remove stale and duplicate forward declarations

[kernel test robot <lkp@intel.com>]

Hi Yuto,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on linus/master v6.19-rc3 next-20251219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Yuto-Ohnuki/fs-remove-stale-and-duplicate-forward-declarations/20251229-151612
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20251229071401.98146-1-ytohnuki%40amazon.com
patch subject: [PATCH] fs: remove stale and duplicate forward declarations
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20251230/202512302139.Wl0soAlz-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251230/202512302139.Wl0soAlz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512302139.Wl0soAlz-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   In file included from block/bdev.c:14:
>> include/linux/blkdev.h:1656:41: warning: declaration of 'struct hd_geometry' will not be visible outside of this function [-Wvisibility]
    1656 |         int (*getgeo)(struct gendisk *, struct hd_geometry *);
         |                                                ^
   1 warning generated.
--
   In file included from block/ioctl.c:4:
>> include/linux/blkdev.h:1656:41: warning: declaration of 'struct hd_geometry' will not be visible outside of this function [-Wvisibility]
    1656 |         int (*getgeo)(struct gendisk *, struct hd_geometry *);
         |                                                ^
>> block/ioctl.c:564:33: error: incompatible pointer types passing 'struct hd_geometry *' to parameter of type 'struct hd_geometry *' [-Werror,-Wincompatible-pointer-types]
     564 |         ret = disk->fops->getgeo(disk, &geo);
         |                                        ^~~~
   1 warning and 1 error generated.


vim +564 block/ioctl.c

d30a2605be9d513 David Woodhouse   2008-08-11  545  
d8e4bb8103df02a Christoph Hellwig 2015-10-15  546  static int blkdev_getgeo(struct block_device *bdev,
d8e4bb8103df02a Christoph Hellwig 2015-10-15  547  		struct hd_geometry __user *argp)
d8e4bb8103df02a Christoph Hellwig 2015-10-15  548  {
d8e4bb8103df02a Christoph Hellwig 2015-10-15  549  	struct gendisk *disk = bdev->bd_disk;
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  550  	struct hd_geometry geo;
d8e4bb8103df02a Christoph Hellwig 2015-10-15  551  	int ret;
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  552  
d8e4bb8103df02a Christoph Hellwig 2015-10-15  553  	if (!argp)
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  554  		return -EINVAL;
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  555  	if (!disk->fops->getgeo)
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  556  		return -ENOTTY;
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  557  
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  558  	/*
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  559  	 * We need to set the startsect first, the driver may
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  560  	 * want to override it.
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  561  	 */
a014741c0adfb8f Vasiliy Kulikov   2010-11-08  562  	memset(&geo, 0, sizeof(geo));
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  563  	geo.start = get_start_sect(bdev);
4fc8728aa34f548 Al Viro           2024-05-21 @564  	ret = disk->fops->getgeo(disk, &geo);
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  565  	if (ret)
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  566  		return ret;
d8e4bb8103df02a Christoph Hellwig 2015-10-15  567  	if (copy_to_user(argp, &geo, sizeof(geo)))
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  568  		return -EFAULT;
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  569  	return 0;
a885c8c4316e1c1 Christoph Hellwig 2006-01-08  570  }
d8e4bb8103df02a Christoph Hellwig 2015-10-15  571  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki