* [PATCH] staging: sm750fb: fix const array warning
@ 2025-12-26 12:04 MottiKumar
2025-12-30 7:42 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: MottiKumar @ 2025-12-26 12:04 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh
Cc: skhan, linux-kernel-mentees, linux-fbdev, linux-staging,
linux-kernel, mottikumarbabu
Add a missing const to g_fbmode to fix a checkpatch warning:
"static const char * array should probably be static const char * const"
Signed-off-by: MottiKumar <mottikumarbabu@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index d100b9e1d3d5..7afb58561a0c 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -33,7 +33,7 @@
static int g_hwcursor = 1;
static int g_noaccel;
static int g_nomtrr;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
static const char *g_def_fbmode = "1024x768-32@60";
static char *g_settings;
static int g_dualview;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: sm750fb: fix const array warning
2025-12-26 12:04 [PATCH] staging: sm750fb: fix const array warning MottiKumar
@ 2025-12-30 7:42 ` Greg KH
[not found] ` <CAC9bbDKw-TGY81wecEnmhbMror0R=y8McTJGU5CPRf2N8UM9fQ@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2025-12-30 7:42 UTC (permalink / raw)
To: MottiKumar
Cc: sudipm.mukherjee, teddy.wang, skhan, linux-kernel-mentees,
linux-fbdev, linux-staging, linux-kernel
On Fri, Dec 26, 2025 at 05:34:17PM +0530, MottiKumar wrote:
> Add a missing const to g_fbmode to fix a checkpatch warning:
> "static const char * array should probably be static const char * const"
>
> Signed-off-by: MottiKumar <mottikumarbabu@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index d100b9e1d3d5..7afb58561a0c 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -33,7 +33,7 @@
> static int g_hwcursor = 1;
> static int g_noaccel;
> static int g_nomtrr;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};
> static const char *g_def_fbmode = "1024x768-32@60";
> static char *g_settings;
> static int g_dualview;
> --
> 2.43.0
>
>
Did you test build this change? If not, please do so.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: sm750fb: fix const array warning
[not found] ` <CAC9bbDKw-TGY81wecEnmhbMror0R=y8McTJGU5CPRf2N8UM9fQ@mail.gmail.com>
@ 2025-12-30 12:51 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2025-12-30 12:51 UTC (permalink / raw)
To: Motti Kumar Babu
Cc: sudipm.mukherjee, teddy.wang, skhan, linux-kernel-mentees,
linux-fbdev, linux-staging, linux-kernel
On Tue, Dec 30, 2025 at 05:42:43PM +0530, Motti Kumar Babu wrote:
> Hi Greg KH,
>
> Yes, I have verified this change with a test build.
>
> I ran make defconfig followed by make M=drivers/staging/sm750fb/ on the
> staging-testing branch, and the driver compiled successfully without any
> errors or new warnings.
defconfig will not enable this driver, are you sure you actually built
it?
And please do not top-post, or use html email.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-30 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-26 12:04 [PATCH] staging: sm750fb: fix const array warning MottiKumar
2025-12-30 7:42 ` Greg KH
[not found] ` <CAC9bbDKw-TGY81wecEnmhbMror0R=y8McTJGU5CPRf2N8UM9fQ@mail.gmail.com>
2025-12-30 12:51 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).