From: Aaron Tomlin <atomlin@atomlin.com>
To: tony.luck@intel.com, reinette.chatre@intel.com,
Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com
Cc: dave.martin@arm.com, sean@ashe.io, linux-kernel@vger.kernel.org
Subject: [v3 PATCH 1/1] x86/resctrl: Add "*" shorthand to set io_alloc CBM for all domains
Date: Tue, 30 Dec 2025 21:35:49 -0500 [thread overview]
Message-ID: <20251231023549.2390630-2-atomlin@atomlin.com> (raw)
In-Reply-To: <20251231023549.2390630-1-atomlin@atomlin.com>
Introduce a wildcard domain ID selector "*" for the io_alloc_cbm
interface. This allows a user to update the Capacity Bitmask (CBM)
across all cache domains in a single operation.
Currently, configuring io_alloc_cbm requires an explicit ID for each
domain, which is cumbersome on systems with high core counts and
numerous cache clusters. Supporting a wildcard selector simplifies
automation and management tasks.
For example, a user can now write "*=0" to the io_alloc_cbm file to
program every domain to the hardware-defined minimum CBM. Note that the
value provided must still adhere to the constraints defined in the
resource's min_cbm_bits.
Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>
---
Documentation/filesystems/resctrl.rst | 8 ++++
fs/resctrl/ctrlmondata.c | 60 ++++++++++++++-------------
2 files changed, 40 insertions(+), 28 deletions(-)
diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
index 8c8ce678148a..e4d92c865e44 100644
--- a/Documentation/filesystems/resctrl.rst
+++ b/Documentation/filesystems/resctrl.rst
@@ -215,6 +215,14 @@ related to allocation:
# cat /sys/fs/resctrl/info/L3/io_alloc_cbm
0=00ff;1=000f
+ Set each CBM to a specified value.
+
+ A special value "*" is required to represent all cache IDs.
+
+ Example::
+
+ # echo "*=0" > /sys/fs/resctrl/info/L3/io_alloc_cbm
+
When CDP is enabled "io_alloc_cbm" associated with the CDP_DATA and CDP_CODE
resources may reflect the same values. For example, values read from and
written to /sys/fs/resctrl/info/L3DATA/io_alloc_cbm may be reflected by
diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c
index b2d178d3556e..7b3119f91b9d 100644
--- a/fs/resctrl/ctrlmondata.c
+++ b/fs/resctrl/ctrlmondata.c
@@ -873,41 +873,45 @@ static int resctrl_io_alloc_parse_line(char *line, struct rdt_resource *r,
struct rdt_ctrl_domain *d;
char *dom = NULL, *id;
unsigned long dom_id;
+ bool update_all;
-next:
- if (!line || line[0] == '\0')
- return 0;
+ while (line && line[0] != '\0') {
+ update_all = false;
+ dom = strsep(&line, ";");
+ id = strsep(&dom, "=");
- dom = strsep(&line, ";");
- id = strsep(&dom, "=");
- if (!dom || kstrtoul(id, 10, &dom_id)) {
- rdt_last_cmd_puts("Missing '=' or non-numeric domain\n");
- return -EINVAL;
- }
+ if (id && !strcmp(id, "*")) {
+ update_all = true;
+ } else if (!dom || kstrtoul(id, 10, &dom_id)) {
+ rdt_last_cmd_puts("Missing '=' or non-numeric domain\n");
+ return -EINVAL;
+ }
- dom = strim(dom);
- list_for_each_entry(d, &r->ctrl_domains, hdr.list) {
- if (d->hdr.id == dom_id) {
- data.buf = dom;
- data.mode = RDT_MODE_SHAREABLE;
- data.closid = closid;
- if (parse_cbm(&data, s, d))
- return -EINVAL;
- /*
- * Keep io_alloc CLOSID's CBM of CDP_CODE and CDP_DATA
- * in sync.
- */
- if (resctrl_arch_get_cdp_enabled(r->rid)) {
- peer_type = resctrl_peer_type(s->conf_type);
- memcpy(&d->staged_config[peer_type],
- &d->staged_config[s->conf_type],
- sizeof(d->staged_config[0]));
+ dom = strim(dom);
+ list_for_each_entry(d, &r->ctrl_domains, hdr.list) {
+ if (update_all || d->hdr.id == dom_id) {
+ data.buf = dom;
+ data.mode = RDT_MODE_SHAREABLE;
+ data.closid = closid;
+ if (parse_cbm(&data, s, d))
+ return -EINVAL;
+ /*
+ * Keep io_alloc CLOSID's CBM of CDP_CODE and CDP_DATA
+ * in sync.
+ */
+ if (resctrl_arch_get_cdp_enabled(r->rid)) {
+ peer_type = resctrl_peer_type(s->conf_type);
+ d->staged_config[peer_type] =
+ d->staged_config[s->conf_type];
+ }
+
+ if (!update_all)
+ break;
}
- goto next;
}
}
- return -EINVAL;
+ return 0;
}
ssize_t resctrl_io_alloc_cbm_write(struct kernfs_open_file *of, char *buf,
--
2.51.0
next prev parent reply other threads:[~2025-12-31 2:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 2:35 [v3 PATCH 0/1] x86/resctrl: Add "*" shorthand to set io_alloc CBM for all domains Aaron Tomlin
2025-12-31 2:35 ` Aaron Tomlin [this message]
2026-01-06 16:49 ` [v3 PATCH 1/1] " Babu Moger
2026-01-07 1:28 ` Aaron Tomlin
2026-01-08 18:45 ` Reinette Chatre
2026-01-26 3:30 ` Aaron Tomlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251231023549.2390630-2-atomlin@atomlin.com \
--to=atomlin@atomlin.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=sean@ashe.io \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox