From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 494984D8CE for ; Wed, 31 Dec 2025 22:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767218425; cv=none; b=NdTinvclZbX4V0B41ZA3PqVrd6e/btSb+vhLSUBUxk8bT8AtHXGNGkXZHIruaNz3JusqdlpQmyUqeIwW/5e/Amh4QyVmLSoMtnDXyXrMOQCpK/yYc/hjjeo5X6fZvEexH5RHIJBSDmb1BPpl8UPoKz2C8OjxZNlgyOtQcBErcFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767218425; c=relaxed/simple; bh=ks6jIZ3i+BR7h7sQwlahINK0enfVT2oo7oxI3Jtks98=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F8e1bri16vXYy7crZDA30xdjsTNa+fvyGfbzTSOP1TISjp6Xiv6PCiNKggyB6QKxtPtHzSVsSUp/zWLVWrj3TbC64PHCGKU/tNyghY+1DFcZNVw1Jdw+m4Z2MAOUVZvwCoFQ7j9pUuckjcmOFUUP8KK0huou6peSx+I+uhiGGuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=NgYqchNz; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="NgYqchNz" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a0bb2f093aso111899875ad.3 for ; Wed, 31 Dec 2025 14:00:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1767218423; x=1767823223; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=plHL9+oSbLNnTM7eUaDrsYWcFptA7VDrjL54CvUj6zE=; b=NgYqchNzgGcdOIqGillOGjJYGqBIiC+cJ2DORd59tENdgjiDE2wS1I6hoU4Joy9gJ4 fwdy3wgrPt0d1IZf8DtOmEo/xulRifbGb7CQJHSggPPqce2pkBsT6JD2OGbiLnRw2DTZ o9EouNXd00pHMwU244JDQrpeustBzaVLJGna4hnmsb4lyGR7sRfy9oy8z3CIy24Kzm3b kO0gLdMrKD7/34lXrdTS95hXKTCc6Re8iu+T3Bi5uy5nOF/FJksaTBlu+3nVRlZaEQda dajt9Iuj7QulD7njwN4PoExmkZW0PRc32sx60GLHWCq3GsFlTTDevhK1KwP1G95UJ0Cu BjkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767218423; x=1767823223; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=plHL9+oSbLNnTM7eUaDrsYWcFptA7VDrjL54CvUj6zE=; b=sC6N7uNKTZxVKRWklVMFRKwamVW7OXQnlN0MU3UhWypndt2HYONfkOr5JpVHHp5Kb3 3GrdlpmJJVdHr9B7KhwjfBb2iE3gA8QLJuct2VLSpcwCE8wcaxa8WgCcrrd6y1w07iao H9u7eHEIic92snFd1TfydzWyfQ9CnuhGUD9cb52Hv8ValRNfLB8hJr0sBi+jLrnZmesw GakEII1+r+5ASeYlOpvIZlFkZobZJSnlaSoZILq/oF1BfOOiXGFFYW1D/RCS3aCEXXXO XvAbttNnqxnkJ9AlnALhQClbhRXGBfbSkYBh0US9bRSSW83F13cixBiy4cXz7UtlEKud GwIA== X-Forwarded-Encrypted: i=1; AJvYcCWJcVS25zOv1INH0KjKTGuaHmEHJy762oFINM231lQXJk5QhV4ISAUQ3FRLSAk11r7B4puX85sEVSqXifg=@vger.kernel.org X-Gm-Message-State: AOJu0YyB+nNtm/hMDOEJX4owVT05L7QlITtq3r4pWxmhyG2KtT0gtqWB /AnICeIAPzArO+h+C4myEHKnoMHkGiGOOl5o/9sQI6UTMRCrGMP5fxnGghzWE1OJd+I= X-Gm-Gg: AY/fxX7UmSU+VLWgWZmCcRo0U43x4svVmXdgbfpbVR12pzoKWafAuThPYQl08gJSpxa HchFXhf3o+b4GLoEuvxuYkAbUz4Yaw6c6G+lMM9X3zTIapBgaBtlyqN5XTqbKpF16wvCjyI9o9Q vextFc4GadkEwQLeQ34EkGW6pDf4ZHqMQmJISO7Ipia+DBNBkWhdWWv+E01fMr616bDvQmlkhls et1z7nAeJHAicgpf+JA6gY7DtFl+G60wlFnAyFoZDBqRtMajCkKZeb7yfpYsP/PtbiEmDk8EbNK ihG6cYzl6QIHj95ettrKe25jgtLPiRLrdBOxHSh5fJ/Rdmr2FcGKwpWW+9RHv4od5yn1ZxcvIOR gi86Z9gxzil10WWqFiV3oNqA9rULWNZX5QjBPQYxsYuDWdF9wt4LWj64+tiYYaEhG3kGpFDGxSD aVC6ooG65W0SzDXiM4E1O8TI8VIaUVH08= X-Google-Smtp-Source: AGHT+IErmVq2ZJJlRu6w72hZrcFPXfclS6rhnNiGuSvJ7jAIOyFnVwerOHWwtv4A61/jRRnREzQcWw== X-Received: by 2002:a05:7022:e1b:b0:11b:b622:cad9 with SMTP id a92af1059eb24-121722b44a8mr36254861c88.21.1767218421818; Wed, 31 Dec 2025 14:00:21 -0800 (PST) Received: from medusa.lab.kspace.sh ([208.88.152.253]) by smtp.googlemail.com with UTF8SMTPSA id a92af1059eb24-1217254c734sm144726019c88.13.2025.12.31.14.00.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 14:00:21 -0800 (PST) Date: Wed, 31 Dec 2025 14:00:20 -0800 From: Mohamed Khalfella To: Sagi Grimberg Cc: Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Aaron Dailey , Randy Jennings , John Meneghini , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 05/14] nvmet: Send an AEN on CCR completion Message-ID: <20251231220020.GK3864520-mkhalfella@purestorage.com> References: <20251126021250.2583630-1-mkhalfella@purestorage.com> <20251126021250.2583630-6-mkhalfella@purestorage.com> <13c2bf9c-6eac-4c48-b12c-f76e86c8ef32@grimberg.me> <20251225181313.GC8129-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat 2025-12-27 11:48:49 +0200, Sagi Grimberg wrote: > > > On 25/12/2025 20:13, Mohamed Khalfella wrote: > > On Thu 2025-12-25 15:23:51 +0200, Sagi Grimberg wrote: > >> > >> On 26/11/2025 4:11, Mohamed Khalfella wrote: > >>> Send an AEN to initiator when impacted controller exists. The > >>> notification points to CCR log page that initiator can read to check > >>> which CCR operation completed. > >>> > >>> Signed-off-by: Mohamed Khalfella > >>> --- > >>> drivers/nvme/target/core.c | 27 +++++++++++++++++++++++---- > >>> drivers/nvme/target/nvmet.h | 3 ++- > >>> include/linux/nvme.h | 3 +++ > >>> 3 files changed, 28 insertions(+), 5 deletions(-) > >>> > >>> diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c > >>> index 7dbe9255ff42..60173833c3eb 100644 > >>> --- a/drivers/nvme/target/core.c > >>> +++ b/drivers/nvme/target/core.c > >>> @@ -202,7 +202,7 @@ static void nvmet_async_event_work(struct work_struct *work) > >>> nvmet_async_events_process(ctrl); > >>> } > >>> > >>> -void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, > >>> +static void nvmet_add_async_event_locked(struct nvmet_ctrl *ctrl, u8 event_type, > >>> u8 event_info, u8 log_page) > >>> { > >>> struct nvmet_async_event *aen; > >>> @@ -215,12 +215,17 @@ void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, > >>> aen->event_info = event_info; > >>> aen->log_page = log_page; > >>> > >>> - mutex_lock(&ctrl->lock); > >>> list_add_tail(&aen->entry, &ctrl->async_events); > >>> - mutex_unlock(&ctrl->lock); > >>> > >>> queue_work(nvmet_wq, &ctrl->async_event_work); > >>> } > >>> +void nvmet_add_async_event(struct nvmet_ctrl *ctrl, u8 event_type, > >>> + u8 event_info, u8 log_page) > >>> +{ > >>> + mutex_lock(&ctrl->lock); > >>> + nvmet_add_async_event_locked(ctrl, event_type, event_info, log_page); > >>> + mutex_unlock(&ctrl->lock); > >>> +} > >>> > >>> static void nvmet_add_to_changed_ns_log(struct nvmet_ctrl *ctrl, __le32 nsid) > >>> { > >>> @@ -1788,6 +1793,18 @@ struct nvmet_ctrl *nvmet_alloc_ctrl(struct nvmet_alloc_ctrl_args *args) > >>> } > >>> EXPORT_SYMBOL_GPL(nvmet_alloc_ctrl); > >>> > >>> +static void nvmet_ctrl_notify_ccr(struct nvmet_ctrl *ctrl) > >>> +{ > >>> + lockdep_assert_held(&ctrl->lock); > >>> + > >>> + if (nvmet_aen_bit_disabled(ctrl, NVME_AEN_BIT_CCR_COMPLETE)) > >>> + return; > >>> + > >>> + nvmet_add_async_event_locked(ctrl, NVME_AER_NOTICE, > >>> + NVME_AER_NOTICE_CCR_COMPLETED, > >>> + NVME_LOG_CCR); > >>> +} > >>> + > >>> static void nvmet_ctrl_complete_pending_ccr(struct nvmet_ctrl *ctrl) > >>> { > >>> struct nvmet_subsys *subsys = ctrl->subsys; > >>> @@ -1801,8 +1818,10 @@ static void nvmet_ctrl_complete_pending_ccr(struct nvmet_ctrl *ctrl) > >>> list_for_each_entry(sctrl, &subsys->ctrls, subsys_entry) { > >>> mutex_lock(&sctrl->lock); > >>> list_for_each_entry(ccr, &sctrl->ccrs, entry) { > >>> - if (ccr->ctrl == ctrl) > >>> + if (ccr->ctrl == ctrl) { > >>> + nvmet_ctrl_notify_ccr(sctrl); > >>> ccr->ctrl = NULL; > >>> + } > >> Is this double loop necessary? Would you have more than one controller > >> cross resetting the same > > As it is implemented now CCRs are linked to sctrl. This decision can be > > revisited if found suboptimal. At some point I had CCRs linked to > > ctrl->subsys but that led to lock ordering issues. Double loop is > > necessary to find all CCRs in all controllers and mark them done. > > Yes, it is possible to have more than one sctrl resetting the same > > ictrl. > > I'm more interested in simplifying. > > > > >> controller? Won't it be better to install a callback+opaque that the > >> controller removal will call? > > Can you elaborate more on that? Better in what terms? > > > > nvmet_ctrl_complete_pending_ccr() is called from nvmet_ctrl_free() when > > we know that ctrl->ref is zero and no new CCRs will be added to this > > controller because nvmet_ctrl_find_get_ccr() will not be able to get it. > > In nvmet, the controller is serving a single host. Hence I am not sure I > understand how multiple source controllers will try to reset the impacted > controller. So, if there is a 1-1 relationship between source and impacted > controller, I'd perhaps suggest to simplify and install on the impacted > controller > callback+opaque (e.g. void *data) instead of having it iterate and then > actually send > the AEN from the impacted controller. A controller is serving a single path for a given host. A host that is connected to nvme subsystem via multiple paths will have more than one controller. I can think of two reasons why we need to support resetting an impacted controller from multiple source controllers. - It is possible for multiple paths to go down at the same time. The first source controller we use for CCR, even though we check to see if LIVE, might have lost connection to subsystem. It is a matter of time for it to see keepalive timeout and fail too. If CCR fails using this controller we should not give up. We need to try other paths. - Some nvme subsystems might support resetting impacted controller from a subset of controllers connected to the host. An array that has multiple frontend engines might not support resetting controllers across engines. In fact, TP8028 allows for subsystem to suggest to host to use another source controller in Alternate Controller ID (ACID) fied on CCR logpage (not implemente in this patchset).