From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88D382AE99 for ; Wed, 31 Dec 2025 22:36:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767220615; cv=none; b=VToswLtuv5e3McWeYhQYan1VX5keA1DbFGXT33IcB7cbpJPajeKvv2SckJT5x0CfXupNdif3GNObysQeXiURzDQ5aQpX9iIH8CbGjBM/uL8AEs5xt3uq5kOoXoKkhdmI8gW3ABwgQjZLDV1QnyEYSDzVTiw37dZNt7WAdUA8TF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767220615; c=relaxed/simple; bh=ajOeDhIbaRzfCu4IaiWWEhX2uuKL1j/UxZ6R+hNMl78=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZqsLU/Y6mg2oZEXZO9oUK5GwZCOd2MBNLyk+xaL09ZhyiISdk+E7PLsEpJFVG9+KduGE5QVrIX6DGfngWsdXzYi1fw60qOiP5SEQwH2Yr7rC75hLF9XYujj8ht7JcjZAGl1741LH0XkY5TYtCcMfeOQywzdSTS+FTw62eCfIBsk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=QmPezVqF; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="QmPezVqF" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a1388cdac3so103015445ad.0 for ; Wed, 31 Dec 2025 14:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1767220614; x=1767825414; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u3gU23GDV6+dVNC72KymJnypOIwrb8GJDySSJNKepbg=; b=QmPezVqF+0o6AIDXGRlFzcon1pJIP7lFAfKYZoRA1tWuswSIE+D0UVvQvI4WE9Zq+c tprNn9p/8a+u4AP0xuPj7RHEmCwKQTx7KAY8cgpr2AJPQYm2axlfaoSwih5/H60YOPFy uEQ6kcTgfpD/TjcyuSwSAfA3+aW3BCOzKnPilhTqXJa0VEPYlNJ+RseY8ssOVu5UrV+6 nnWkEIkz17bF/6LeSKOUizp0w9z7j5ylUWOlgSICgtDzoLkfC4085+P6NLshZSRciDjd 4UDk8AR8HCcPS6rKmWW/sZGBpYAAp/YSDwaiwrj+UTnctZ9sOsdRvPbRqh0X2FINwxso dCEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767220614; x=1767825414; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u3gU23GDV6+dVNC72KymJnypOIwrb8GJDySSJNKepbg=; b=mZQvM0HkghrderkIfl/p7vBoye/d3N46mvlcHxCH2Fh8ZuSIXKW4liWRdElTKh3Mmd 7YjBwjUowmmDdQdyMmh99I1IktMHLMZ6wgctsQ/CgPEwimEi05pd2uq9FmF86X4XPHAX W7rOY40cKasKCGqJPX3AkzDeyuNRZAeaEazjuqxZWubn1p0cnM698cv+7v2kmBiExca9 O+BaLdHjio66Yq3qsOubrH4Wi1QkhOhfdG9AmKH8YGe49uKa0HgOp8AWsn3RbIX7MBk1 L31jOjThHycNuqIjDCxz2xEDZzdUPk+/nFbNY5UDw/bdWYxQYYjuAv+jnZjcpara6RJj tBRw== X-Forwarded-Encrypted: i=1; AJvYcCXJjxULWok3k5qhCjdC3LxY+YSCjpInZ9QMmHn/OlZmNs/XQGjYf4uulbXqQD3Bk0Mg08gtvAcMqScVKHU=@vger.kernel.org X-Gm-Message-State: AOJu0YwNOFD2oGJdGEe2NWShBbu+ywbdZhk40B0IVIooDLio3gjk/gx2 +MGViTS/QPd7mMcM7JeYr93bji3BBFQt8itQEx4FuKrC7/TDIkNaHtimxHpFd/AGnYI= X-Gm-Gg: AY/fxX7R0rr7wVSjoNE4lr+gcTo8WOWNL37kybvDBW3qcua6NpsHnXk+aK7H+u6pGoO nDT+wE79mmWa1g7tk17LdvqFtFMP/3LCE/EV/YA94XOjbh4o6kf9HyBj19P5TanLjkVDAR7o3/y HoiBCbxVCO/M1psYDCDm8tCv94tppucv26fxVTYk90lt9uUyemLiW2ribNVH9caHj76xQHgH/As 0s1TwRtglWRGDDgo3R04tUoMByoAcfHW7QoMN6C+7y17VEZIUi8pY42gIauhWzSsr8vU73lUA5y HT8ozYmqnj+3vdtkTYPXBymc5W1UrFpfzZRasMB6IVXARVYE0N1xsiJPt16vbP/RQEB7Qm5YymJ AwVdpkhLVgmvIpYEaluZi/UYVbFiSaadKSmSCmPiCyLee0K5N1USmFi+85Brfyoi9YOnC/IgOHO f+GogFwMlXd5F/1bbMYkjuMdbzF8mPa+4= X-Google-Smtp-Source: AGHT+IF01BZtUlvGqP79tx0R03jTkM04G1ETZYeE+YhCga5XjK+Zlo49tx0rW2H5KEtSD9ap1LkmCg== X-Received: by 2002:a05:7022:6722:b0:11d:f464:38b3 with SMTP id a92af1059eb24-121722a9757mr34325025c88.2.1767220613380; Wed, 31 Dec 2025 14:36:53 -0800 (PST) Received: from medusa.lab.kspace.sh ([208.88.152.253]) by smtp.googlemail.com with UTF8SMTPSA id a92af1059eb24-121724ddc30sm146308195c88.6.2025.12.31.14.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 14:36:53 -0800 (PST) Date: Wed, 31 Dec 2025 14:36:52 -0800 From: Mohamed Khalfella To: Sagi Grimberg Cc: Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Aaron Dailey , Randy Jennings , John Meneghini , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 07/14] nvme: Add RECOVERING nvme controller state Message-ID: <20251231223652.GM3864520-mkhalfella@purestorage.com> References: <20251126021250.2583630-1-mkhalfella@purestorage.com> <20251126021250.2583630-8-mkhalfella@purestorage.com> <20251225171709.GA8129-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat 2025-12-27 11:55:01 +0200, Sagi Grimberg wrote: > > > On 25/12/2025 19:17, Mohamed Khalfella wrote: > > On Thu 2025-12-25 15:29:52 +0200, Sagi Grimberg wrote: > >> > >> On 26/11/2025 4:11, Mohamed Khalfella wrote: > >>> Add NVME_CTRL_RECOVERING as a new controller state to be used when > >>> impacted controller is being recovered. A LIVE controller enters > >>> RECOVERING state when an IO error is encountered. While recovering > >>> inflight IOs will not be canceled if they timeout. These IOs will be > >>> canceled after recovery finishes. Also, while recovering a controller > >>> can not be reset or deleted. This is intentional because reset or delete > >>> will result in canceling inflight IOs. When recovery finishes, the > >>> impacted controller transitions from RECOVERING state to RESETTING state. > >>> Reset codepath takes care of queues teardown and inflight requests > >>> cancellation. > >> Is RECOVERING really capturing the nature of this state? Maybe RESETTLING? > >> or QUIESCING? > > Naming is hard. QUIESCING sounds better, I will renaming it to > > QUIESCING. > > I actually think that FENCING is probably best to describe what the > state is used for... FENCING is used in HA clusters with persistent reservations. I find it confusing to use it here. Let me know if you have strong preference.