From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25DB91E49F for ; Wed, 31 Dec 2025 23:04:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767222277; cv=none; b=ZNs3GJGJBAL6gz7UC9PPTVMC3qaSfbTk8AoiaIzzntPNBxb85mEKoxieRzEM7LpYttnIO9649RzHlKmBwnCim/o5xcmj/yRvseiSuc29ktl2Uz4T6XwqBI3RI8JWtohiWzhfxiXTmRwZJAzlvoa7sj2h5c4t5YUjuhak6qgKoj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767222277; c=relaxed/simple; bh=8TofAo2QbsIOD2X8WC4I4GJtOwwTG0xmSXzWRE0u1SI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Yhg3ptbfdACLcDg5fM+g8i8Qfe/CIhRFEVGdCCJIpEhckL3lMUPB7tjctqVo+nHyBvWL4Vp3KXxBOwBZcHAVjkbMsR8x0zXgTSmZhSmD4Ycb5qa+p2CXcX/146c7TCd1baDkaoNkYK72+/rASkJXrIFdoZaHdgCyTJY9pbeIAX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=HpFxJWki; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="HpFxJWki" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-34c1d98ba11so11951532a91.3 for ; Wed, 31 Dec 2025 15:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1767222275; x=1767827075; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/2G5N3iRRZylV24gPMe/ewiYhKqx87GwpYl6Y8LOzVs=; b=HpFxJWki7qG+eluBWyAxaz91sYnxsmkbzL0eUTWl//sH6S2Va66XaHUSeHRJ4fFUXt Rv0WXmbhJFVTM4+WilTXmeZudAj00NFl2aVpwsxxlt40h8blxXf1KbL9vDeDolsDw086 og1tqbk1ckWk97TTOqqB9gPf5l45CNV9ivwOCeuHKWzz1fqwZNyXnc3HO3kTtrj2KMPP AeHvDqsi/FhGSsU8wEiW7K9/yRk/zLbUNOpqbmAc4G/dhshUSNcE/UVVCtO5XFAUeW7C bjHZB+q8hXrWhwz16f07VOhKHQPM0j7IiL2QZ2tw7r5Qbv3Sy2TgKu988kHtLO6NBRrc nwaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767222275; x=1767827075; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/2G5N3iRRZylV24gPMe/ewiYhKqx87GwpYl6Y8LOzVs=; b=mOecMhXaYTJOsvJ7j8ritE9m2Z5on+lcnIeqOEzclnZa1OmdLhS/vfAr03R5l/TJ2l H8L2ifaK5KPKuktTaW9mKiAsx8gelyfePDKFQIrgUV8eFmqkxUPLUeIuNwGyhtlDfcNG hqJOOZw48IYqRlRATi/elB/3DWqE8oZ+gXr23hocHgPcCyzoA0PhH5mJ9t9l0BV9mnQE 3xJK704TUFEaZ4fZsNgIONxj9qHaaieK6p3IEPh3n/f6qVrqOqsWel+KJYpSt7lvYuTp gFKrpzm3PGT/frN80Afhkc1FDpFF0ArBJOP3Q21pZ+xCUXpTKYsieblZ5fO7/Ltb4tIY MQlw== X-Forwarded-Encrypted: i=1; AJvYcCW9gkIruWBa4La//V50DzYl+f6CVpE84OJTrQYXs3FuKc37ECF05REhZhyJhCTcbjA1WS22BYUfsg2Zbps=@vger.kernel.org X-Gm-Message-State: AOJu0YyvqZrwwgfXu7snJRgXSyEJAghB3Nvr+Qzq5+OAcvynRakceDj3 hcTm0pUw47HubiwqNfeaVzyVF3hsDZsHoC5ChEdgSHrBH+oS9HphNXGCwq8WIkQMQN8= X-Gm-Gg: AY/fxX7aIE4k9fI3DQ4LpvYyHrfMn7087p7E2aaCIhos+h3Ew4DPKg8L0pzw3pRGq7G 03Q7UYioRXlA/ffiZkvJ4tutnvcpNOabMvbMv3ZZnkoy5gAV5g9gIW+WqY6n2NRvFZjax6XTQYW 8w6iuqUrOSG+OsQT6GztlVXZPGNwb4NcZ8pkzno0v6G0BYJmc7pBhHyGSRxNM7zv5oDuwFqVaXb doxJrqsfN01xIyEAEURMfHyYI4u4CYTJUQoNOUsdr4SUQ19Sl1FiccO5fhGLE4Lnl/jXkyyWHMw HOBSs8ySh/BeM8J5Yss7gV19jMrS3WLJhT5aCq2DkPJRjDc+7sXZdn3gc1BQN/mbEJINIq3hqOG aahxj49rlBdywHF59qGmwgqsZySrSS27FYoz1nOlYof8l00Wu6Ol7t4cSB0jTsXhGOmEzy0OciO sOWCIp2gi1e62ZTu1c0uraTO2kPRTph/8= X-Google-Smtp-Source: AGHT+IGrPhSy6rlcxOoTc/7hlT47oXmlqW8b7dhSxfG/6gsuoH6/fVFIyMvOVFBteaGYWU0asZoMnw== X-Received: by 2002:a05:7022:42a1:b0:119:e569:f60b with SMTP id a92af1059eb24-121721aab79mr40439531c88.4.1767222275059; Wed, 31 Dec 2025 15:04:35 -0800 (PST) Received: from medusa.lab.kspace.sh ([208.88.152.253]) by smtp.googlemail.com with UTF8SMTPSA id 5a478bee46e88-2b05fe5653esm84386956eec.1.2025.12.31.15.04.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Dec 2025 15:04:34 -0800 (PST) Date: Wed, 31 Dec 2025 15:04:33 -0800 From: Mohamed Khalfella To: Sagi Grimberg Cc: Chaitanya Kulkarni , Christoph Hellwig , Jens Axboe , Keith Busch , Aaron Dailey , Randy Jennings , John Meneghini , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 07/14] nvme: Add RECOVERING nvme controller state Message-ID: <20251231230433.GO3864520-mkhalfella@purestorage.com> References: <20251126021250.2583630-1-mkhalfella@purestorage.com> <20251126021250.2583630-8-mkhalfella@purestorage.com> <20251225171709.GA8129-mkhalfella@purestorage.com> <20251231223652.GM3864520-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251231223652.GM3864520-mkhalfella@purestorage.com> On Wed 2025-12-31 14:36:53 -0800, Mohamed Khalfella wrote: > On Sat 2025-12-27 11:55:01 +0200, Sagi Grimberg wrote: > > > > > > On 25/12/2025 19:17, Mohamed Khalfella wrote: > > > On Thu 2025-12-25 15:29:52 +0200, Sagi Grimberg wrote: > > >> > > >> On 26/11/2025 4:11, Mohamed Khalfella wrote: > > >>> Add NVME_CTRL_RECOVERING as a new controller state to be used when > > >>> impacted controller is being recovered. A LIVE controller enters > > >>> RECOVERING state when an IO error is encountered. While recovering > > >>> inflight IOs will not be canceled if they timeout. These IOs will be > > >>> canceled after recovery finishes. Also, while recovering a controller > > >>> can not be reset or deleted. This is intentional because reset or delete > > >>> will result in canceling inflight IOs. When recovery finishes, the > > >>> impacted controller transitions from RECOVERING state to RESETTING state. > > >>> Reset codepath takes care of queues teardown and inflight requests > > >>> cancellation. > > >> Is RECOVERING really capturing the nature of this state? Maybe RESETTLING? > > >> or QUIESCING? > > > Naming is hard. QUIESCING sounds better, I will renaming it to > > > QUIESCING. > > > > I actually think that FENCING is probably best to describe what the > > state is used for... > > FENCING is used in HA clusters with persistent reservations. I find it > confusing to use it here. Let me know if you have strong preference. Nevermind, I will rename it to FENCING.