From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8714E224AF1 for ; Thu, 1 Jan 2026 17:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767288541; cv=none; b=AwJ+UrrRIezO/aRA2hhDGMv2dXQhiGEnjY8sU2yDpPhet68NILmx/g8TPYU/JjTa2K4Xc/fIvMl9iQ1rylDpBD5f5+cTzlBbW3EtL960gcru0U8u90Hh/HK7A/LoXT35aQWZxTg8HTutsszgogRhl2d8kqs9R8Pbj4CYVD1BY3w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767288541; c=relaxed/simple; bh=MV5n72uyCXTGufdfs+Tp7/c9h3fB3MkOv24cXNNb7zA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LGr6gYhQH0CUiDdwFn2XJ7SRLEcDXn9uvXy9Cg0SBuo4biOyaMa5LXdGimQU7p+mrCBXEoh8wdXck3IweJY+lCXkVuNNtfMvW3dleeyu7KC0uzu7pxn05rISlcXUbih+Mq15pl0xW4T366ru/26qjhjlhoqwSanCQB/XWv6C9dU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wr10RnHs; arc=none smtp.client-ip=209.85.215.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wr10RnHs" Received: by mail-pg1-f195.google.com with SMTP id 41be03b00d2f7-bfb84c2fe5eso4848287a12.1 for ; Thu, 01 Jan 2026 09:28:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767288538; x=1767893338; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KrW3GbVAxBV1YYnSWttRqVD3T0zt7/uD6xCGh6+826Q=; b=Wr10RnHsSBPVbzqfBwWSHlcnT17bzcG+lhsXgMZGTGJ9tfp7wJbHUQKlGO2Nn6+kKb Zv2p3dKZHn/rtuOZiFa7y6GlbyW5ZDwm2RwWa5DBXuTXqQ/Ik85Ho0NnXw5qJwCpEwqZ wZvGZAV00yZ45wA+7Po3ANq3aH5luFlpVj7sqTQ47VVs+BvioabY62W1Q//XSkWzrocP TRMurknADCypauRmCLiZ1P0ly03jKtuHxREXuHmFXeEa8803QROuWyjG8ufwbBjFSgyY MZQ2evJnpMFdGU1bNHSvQO6VIjVmGCeqf2g7bwykqEea/sk4DfdBfnQQwhVc5F6gK3Se ds2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767288538; x=1767893338; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KrW3GbVAxBV1YYnSWttRqVD3T0zt7/uD6xCGh6+826Q=; b=C+XaHSdQwU0+NWAKhCwHnih+Ci57ZtOPwM2WibohfewY9V/aVQ5zGk94TTXFgDS4R/ TLSkxuoybhymtnpIfwjgU769vUCa8/bt57JMrhNJrsxnDD2iz9XdErCZBZ8W/Cc+OAKA iVBF0ZzXOp6UA0CqrwsXTFNApRk9w6UnEFK81+w8WE2byl/fbSWuZlrBLnSbRgCQ62Ex E27xFAD0RgOwqf402V3DzXOnsA/A9Eb9/3t3ZXKZxAJ+s8DVYQZlNnoLwpgFrxekP+yh J6Pyrw0F0WJfQsLGOjuPOMCDvWgVzHPq5DuTfll2dOnJJLkO6DcUfNkEw0f4pHgLlGKQ KpPA== X-Forwarded-Encrypted: i=1; AJvYcCUeJ9KZmwYmM46rMVcc6hrGq/BsqAHf/aJWm6PCgJGW5dZSBO+P2Gu34u04oc4CAZr/WwaVGY87+dW9GBs=@vger.kernel.org X-Gm-Message-State: AOJu0Ywv67IlMaiPxplVid42qy92Xw4RBPrV0TsQ9JbboPCqxdpM6o2/ ErT7t1RyTiCp73wYq2FzDmmysuPb0ZMcAPsDzZ9KY2WscYvba0FPQYVo X-Gm-Gg: AY/fxX7v3z7t5jJUkX9pMisGrM9qJJypQVLcF/Zh8+UsUZrqtgeLE6Yq2564PlfE7Bq p0Kmg2+1dR3D3vDW30L6Hn+cOU0V8avm7muVx7M5fZVRfTXyXLftS7zl5NsjCQG8UznRGTuN40F TRvNJ6j1yTIyTnp8ygqSPAjGD3A2I4t7ws5HGyLXEuj2qsLhH7V4mXAGlPSlo9xfeGs9EKENMmi quu2JK46uhHUG8ZIb7uPBibLsuL5pN2AFkFHj3yAKTsVntSemEQHGna+tPBbRP4cqd4it1UuC/C gu2U7HTORIeOwK6nVfxD1/Hq6mSwC4TZ84VR6maQw7nxCCAhl7LLLOgLhGh6D0rSRdXbf8/Uw3X KWYD/at5h75iIpz6ObJE78KOBVYlSZqDKM84BBs3tURKznY6XFm1CkOvI2xYIpDijfxZWQkyD8q hVOI5q8/J36JwC/MVbXagSXKghtcH4QJZG3N9jQctN X-Google-Smtp-Source: AGHT+IFq/e0ejvWVIghaAdB4wbXdz4r0A1x/pqGUvUQjwWFjrtqQuvmu8127TTkEaqjZBtPm+dNKzw== X-Received: by 2002:a05:6a20:3d0b:b0:366:14b0:4b1b with SMTP id adf61e73a8af0-3769ff1bb74mr38532914637.38.1767288537751; Thu, 01 Jan 2026 09:28:57 -0800 (PST) Received: from fedora ([103.120.31.122]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1e79e05712sm33360272a12.14.2026.01.01.09.28.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jan 2026 09:28:56 -0800 (PST) From: Ankit Khushwaha To: Matthieu Baerts , Mat Martineau , Geliang Tang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman Cc: Shuah Khan , netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Ankit Khushwaha Subject: [PATCH net v3] selftests: mptcp: Mark xerror and die_perror __noreturn Date: Thu, 1 Jan 2026 22:58:40 +0530 Message-ID: <20260101172840.90186-1-ankitkhushwaha.linux@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Compiler reports potential uses of uninitialized variables in mptcp_connect.c when xerror() is called from failure paths. mptcp_connect.c:1262:11: warning: variable 'raw_addr' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] xerror() terminates execution by calling exit(), but it is not visible to the compiler & assumes control flow may continue past the call. Annotate xerror() with __noreturn so the compiler can correctly reason about control flow and avoid false-positive uninitialized variable warnings. Signed-off-by: Ankit Khushwaha --- changelog: v3: - also annotate 'die_perror()' with __noreturn - add CFLAGS at top of makefile - target this patch to net instead of net-next as suggested by Matthieu v2: https://lore.kernel.org/all/20251129043808.16714-1-ankitkhushwaha.linux@gmail.com/ - annotate 'xerror()' with __noreturn - remove defining 'raw_addr' to NULL v1: https://lore.kernel.org/all/20251126163046.58615-1-ankitkhushwaha.linux@gmail.com/ --- tools/testing/selftests/net/mptcp/Makefile | 1 + tools/testing/selftests/net/mptcp/mptcp_connect.c | 3 ++- tools/testing/selftests/net/mptcp/mptcp_diag.c | 3 ++- tools/testing/selftests/net/mptcp/mptcp_inq.c | 5 +++-- tools/testing/selftests/net/mptcp/mptcp_sockopt.c | 5 +++-- 5 files changed, 11 insertions(+), 6 deletions(-) diff --git a/tools/testing/selftests/net/mptcp/Makefile b/tools/testing/selftests/net/mptcp/Makefile index 15d144a25d82..4dd6278cd3dd 100644 --- a/tools/testing/selftests/net/mptcp/Makefile +++ b/tools/testing/selftests/net/mptcp/Makefile @@ -3,6 +3,7 @@ top_srcdir = ../../../../.. CFLAGS += -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include $(KHDR_INCLUDES) +CFLAGS += -I$(top_srcdir)/tools/include TEST_PROGS := \ diag.sh \ diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/testing/selftests/net/mptcp/mptcp_connect.c index 404a77bf366a..10f6f99cfd4e 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_connect.c +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c @@ -33,6 +33,7 @@ #include #include #include +#include extern int optind; @@ -140,7 +141,7 @@ static void die_usage(void) exit(1); } -static void xerror(const char *fmt, ...) +static void __noreturn xerror(const char *fmt, ...) { va_list ap; diff --git a/tools/testing/selftests/net/mptcp/mptcp_diag.c b/tools/testing/selftests/net/mptcp/mptcp_diag.c index e084796e804d..8e0b1b8d84b6 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_diag.c +++ b/tools/testing/selftests/net/mptcp/mptcp_diag.c @@ -5,6 +5,7 @@ #include #include #include +#include #include #include #include @@ -87,7 +88,7 @@ enum { #define rta_getattr(type, value) (*(type *)RTA_DATA(value)) -static void die_perror(const char *msg) +static void __noreturn die_perror(const char *msg) { perror(msg); exit(1); diff --git a/tools/testing/selftests/net/mptcp/mptcp_inq.c b/tools/testing/selftests/net/mptcp/mptcp_inq.c index 8e8f6441ad8b..5716998da192 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_inq.c +++ b/tools/testing/selftests/net/mptcp/mptcp_inq.c @@ -28,6 +28,7 @@ #include #include +#include #ifndef IPPROTO_MPTCP #define IPPROTO_MPTCP 262 @@ -40,7 +41,7 @@ static int pf = AF_INET; static int proto_tx = IPPROTO_MPTCP; static int proto_rx = IPPROTO_MPTCP; -static void die_perror(const char *msg) +static void __noreturn die_perror(const char *msg) { perror(msg); exit(1); @@ -52,7 +53,7 @@ static void die_usage(int r) exit(r); } -static void xerror(const char *fmt, ...) +static void __noreturn xerror(const char *fmt, ...) { va_list ap; diff --git a/tools/testing/selftests/net/mptcp/mptcp_sockopt.c b/tools/testing/selftests/net/mptcp/mptcp_sockopt.c index 286164f7246e..b6e58d936ebe 100644 --- a/tools/testing/selftests/net/mptcp/mptcp_sockopt.c +++ b/tools/testing/selftests/net/mptcp/mptcp_sockopt.c @@ -25,6 +25,7 @@ #include #include +#include static int pf = AF_INET; @@ -127,7 +128,7 @@ struct so_state { #define MIN(a, b) ((a) < (b) ? (a) : (b)) #endif -static void die_perror(const char *msg) +static void __noreturn die_perror(const char *msg) { perror(msg); exit(1); @@ -139,7 +140,7 @@ static void die_usage(int r) exit(r); } -static void xerror(const char *fmt, ...) +static void __noreturn xerror(const char *fmt, ...) { va_list ap; -- 2.52.0