Re: [PATCH net-next v2] page_pool: Add page_pool_release_stalled tracepoint

Steven Rostedt
2026-01-02T15:45:00Z

On Fri, 2 Jan 2026 14:17:18 +0800
Leon Hwang <leon.hwang@linux.dev> wrote:

> diff --git a/include/trace/events/page_pool.h b/include/trace/events/page_pool.h
> index 31825ed30032..c34de6a5ae80 100644
> --- a/include/trace/events/page_pool.h
> +++ b/include/trace/events/page_pool.h
> @@ -113,6 +113,30 @@ TRACE_EVENT(page_pool_update_nid,
> __entry->pool, __entry->pool_nid, __entry->new_nid)
> );
>
> +TRACE_EVENT(page_pool_release_stalled,
> +
> + TP_PROTO(const struct page_pool *pool, int inflight, int sec),
> +
> + TP_ARGS(pool, inflight, sec),
> +
> + TP_STRUCT__entry(
> + __field(const struct page_pool *, pool)
> + __field(u32, id)
> + __field(int, inflight)
> + __field(int, sec)
> + ),
> +
> + TP_fast_assign(
> + __entry->pool = pool;
> + __entry->id = pool->user.id;
> + __entry->inflight = inflight;
> + __entry->sec = sec;
> + ),
> +
> + TP_printk("page_pool=%p id=%d inflight=%d sec=%d",
> + __entry->pool, __entry->id, __entry->inflight, __entry->sec)
> +);
> +
> #endif /* _TRACE_PAGE_POOL_H */

From a tracing POV, I see nothing wrong with this.

Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>

-- Steve