From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F830262BD for ; Fri, 2 Jan 2026 09:38:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767346714; cv=none; b=IpPS7MA3Ml1OvHr16u9JAHurJYWhfnfXi6SFqdH/DEg6d3+5qkD11tVOHooepmSCLsdcSlszITgSHBI7aULPViZxAoKVL7mjTCp0DQ7s5xZqVf3v8JqHRGoJYtu/98i6aKHqcTPJfCqJ9XKio+LsPUHI0tb/+0OQw9Xz40dpYmw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767346714; c=relaxed/simple; bh=/MlRD0InWkExZI4u/g68IQqmlXqVlMBql1Qtyu6yVsw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=NPDhDuPXXFeDeHw+KIfKM72kkykoRjjZj7NKWgbcqCILw2xlAsIFTh9BrCkg7L7txCDB47fAwrcXIlNa6QOecynLNv3jFyHfpVz4L5lbIVzkPN5wcgs8Evel182558v6CTp3Mgcq6U3j5KN57P5aBAay2fFjI57Yc1s9h0FIUrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V7ozVSp2; arc=none smtp.client-ip=209.85.210.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V7ozVSp2" Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-7f121c00dedso15952155b3a.0 for ; Fri, 02 Jan 2026 01:38:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767346713; x=1767951513; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RwhWeUrUie5hyZYttQG7hPgt9HlHhLDOoPbYGUOuM7E=; b=V7ozVSp2FMH59tXL/RQqFZpdJ0UTjA+KzJZSx1XXpXh4RGjC9YbRtpRrkQ9BlgYTFi 8qcCMDcYe2vPy0naSGMuNK7cKiLfvzaeNQ/JhTT6L2FroKfZccT3+BIQwpqO0/qthcHN 2hqsFlCfCwus/B/kZFTnTzeSHHkS3KhwTZcgibtdYffJy0zGisoDh8PyFWmapamgcHxl i4yO23L7Z+Z30LRXr7w+NndyKyekMzTbQwnJthtt+XzWV5Kaoah3ccqN4kl6kcJxaau9 /QWUlAqOUaQ+iBNYjBREym90wiPGXN0U8mYsnijSq8+0L6v3SehHLthwOc5K80bRPrUy 2u4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767346713; x=1767951513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RwhWeUrUie5hyZYttQG7hPgt9HlHhLDOoPbYGUOuM7E=; b=cjZcsraPwIT/AmufA0jMzLDwxTEzau+cIV05ewy0xCYifxJ0vO2HuaS/T7K8hEA7RO 61oHiPzLuu1Y2kFC2az8yPoXTmuRX13BpIOP+giyRKZ/sa4OCzedyzqMKefIwhsL9c2I 9MdnH6vu/KRsHbxAPhsOCQ3F/C/nlHd5MGZv0iz1ox4N10Dieiu812fhHi7EzdwaGW62 gUTRbsuu9FLa7olJsFmXQkw2QUJpuyDaIUaJq4ZxvlpCi8cvpYKuHexs2VM08yb7PKFD GhAy68nR5GAQZIQykaDkrUP1Vm4LSJS8JrJihX1hVKQvhdC4i6iLiBgHdFAKyw7fAOmv 66yA== X-Forwarded-Encrypted: i=1; AJvYcCVirHIp57wEk6eWPWWlcqts3M9QBD/sVCfXN0CXnrbbbtblmX728Zudoa8e1XY3NGVFAdU+egtPVuvIYQw=@vger.kernel.org X-Gm-Message-State: AOJu0YwcyRbmJfYDQrouAQZB0/V92m5Pw+Ju2SaTFC5mbvrGFEFfM/Gr hkNVB2dXvDBsjht5mWpB1SOC8AmogFIRLlebTbClLzj6EKw3/V2Mbnzi X-Gm-Gg: AY/fxX6lu1h/foHulxkVO/bDpQI3bxw/Ojc7Z0K5QEsqdMeR/PyfZA8wBBtc0lxnLUo h/v+jQ/BEhe/8a4VfoGXC3aBKaMwjYhhJ/5HRfvcA3Ur+hCzsSH1kXvl8xMznSGgiseQ7JdAmMP rhO8kN1VcjtIv8+dD13ohKfwnvj7AkOq+1T1R6sTf14jgSVTwObJXHi2AEkFWNa76upNoQK3FO2 9PKBCBEGXqtYVu1e+S8YTIkRvk0yR+baJsxEtkCJCExsDVcUiaNIsmvMuZJDX7yCMRT6UTjeWD1 v+HLyaPQUv2sDiZbynl/41ExoM3ET8i3U0ccFDL7XxurTstVFCMWyeFW18iloLTKbzj+rzh0+az 9HnFWiSe7axSwNldc9jFOGiX+rvj8G1RZPP6d8jlxmJRChFwLZAxADQILnvG3lfZgr6ZEdZp59z 8dlDUOnMj6NWJetge1L/vFTnh0r5t2MFctps4L X-Google-Smtp-Source: AGHT+IEPKnJZiVW+ZjQMzr1s3UZY7zlimkXWRy8RZhKuALAzMn9XlNWaqI02+XA6z8lylihvHGysrw== X-Received: by 2002:a05:6a20:938e:b0:341:c4e5:f626 with SMTP id adf61e73a8af0-376a81e76a8mr39650137637.7.1767346712639; Fri, 02 Jan 2026 01:38:32 -0800 (PST) Received: from jvle-ThinkPad-X1-Carbon-Gen-8.. ([114.241.85.219]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c1e7cb01a9asm34594544a12.35.2026.01.02.01.38.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 01:38:32 -0800 (PST) From: Keke Ming To: sanjayembeddedse@gmail.com Cc: alex@ghiti.fr, anup@brainfault.org, aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, palmer@dabbelt.com, pjw@kernel.org, tglx@linutronix.de, virendrasinhchauhan1206@gmail.com, Keke Ming Subject: Re: [PATCH] irqchip/riscv-aplic: adapt to syscore API passing context data Date: Fri, 2 Jan 2026 17:37:41 +0800 Message-ID: <20260102093744.66053-1-ming.jvle@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <6eafdd754222e11a43be4bbc3652f7605d47afa6.1766559840.git.sanjayembeddedse@gmail.com> References: <6eafdd754222e11a43be4bbc3652f7605d47afa6.1766559840.git.sanjayembeddedse@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Wed, Dec 24, 2025 at 16:41:46 +0530, Sanjay Chitroda wrote: > The RISC-V APLIC driver started preserving state across suspend/resume, > but its syscore usage still assumed the old API. Building against > linux-next after a97fbc3ee3e2 fails because the callbacks don’t receive > the necessary driver context. Tested this on riscv64 (cross-compiled on x86_64) using linux-next (next-20251219). Without this patch, the build fails with: drivers/irqchip/irq-riscv-aplic-main.c:111:20: error: initialization of ‘int (*)(void *)’ from incompatible pointer type ‘int (*)(void)’ This patch correctly fixes the compilation error by updating the APLIC driver to the new syscore API. Tested-by: Keke Ming