* fs/file_attr.c:263:9: error: unexpected token, expected comma
@ 2026-01-01 1:41 kernel test robot
2026-01-02 9:31 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2026-01-01 1:41 UTC (permalink / raw)
To: Andrey Albershteyn
Cc: oe-kbuild-all, linux-kernel, Christian Brauner, Amir Goldstein,
Darrick J. Wong, Jan Kara
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9528d5c091c59b408a754a1823cf0942069867cc
commit: 2f952c9e8fe13c6ee15c05189f1f87c1a70b866c fs: split fileattr related helpers into separate file
date: 6 months ago
config: mips-randconfig-r051-20251231 (https://download.01.org/0day-ci/archive/20260101/202601010950.QjCTROwO-lkp@intel.com/config)
compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project f43d6834093b19baf79beda8c0337ab020ac5f17)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260101/202601010950.QjCTROwO-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601010950.QjCTROwO-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/file_attr.c:263:9: error: unexpected token, expected comma
263 | err = put_user(fa.flags, argp);
| ^
arch/mips/include/asm/uaccess.h:71:33: note: expanded from macro 'put_user'
71 | access_ok(__p, sizeof(*__p)) ? __put_user((x), __p) : -EFAULT; \
| ^
arch/mips/include/asm/uaccess.h:136:18: note: expanded from macro '__put_user'
136 | __put_data_asm(user_sw, __pu_ptr); \
| ^
<inline asm>:3:10: note: instantiated into assembly here
3 | .set eva
| ^
fs/file_attr.c:263:9: error: instruction requires a CPU feature not currently enabled
263 | err = put_user(fa.flags, argp);
| ^
arch/mips/include/asm/uaccess.h:71:33: note: expanded from macro 'put_user'
71 | access_ok(__p, sizeof(*__p)) ? __put_user((x), __p) : -EFAULT; \
| ^
arch/mips/include/asm/uaccess.h:136:18: note: expanded from macro '__put_user'
136 | __put_data_asm(user_sw, __pu_ptr); \
| ^
<inline asm>:4:2: note: instantiated into assembly here
4 | swe $2, 0($16)
| ^
fs/file_attr.c:276:8: error: unexpected token, expected comma
276 | err = get_user(flags, argp);
| ^
arch/mips/include/asm/uaccess.h:97:33: note: expanded from macro 'get_user'
97 | access_ok(__p, sizeof(*__p)) ? __get_user((x), __p) : \
| ^
arch/mips/include/asm/uaccess.h:183:23: note: expanded from macro '__get_user'
183 | __get_data_asm((x), user_lw, __gu_ptr); \
| ^
<inline asm>:3:10: note: instantiated into assembly here
3 | .set eva
| ^
fs/file_attr.c:276:8: error: instruction requires a CPU feature not currently enabled
276 | err = get_user(flags, argp);
| ^
arch/mips/include/asm/uaccess.h:97:33: note: expanded from macro 'get_user'
97 | access_ok(__p, sizeof(*__p)) ? __get_user((x), __p) : \
| ^
arch/mips/include/asm/uaccess.h:183:23: note: expanded from macro '__get_user'
183 | __get_data_asm((x), user_lw, __gu_ptr); \
| ^
<inline asm>:4:2: note: instantiated into assembly here
4 | lwe $20, 0($20)
| ^
4 errors generated.
vim +263 fs/file_attr.c
255
256 int ioctl_getflags(struct file *file, unsigned int __user *argp)
257 {
258 struct fileattr fa = { .flags_valid = true }; /* hint only */
259 int err;
260
261 err = vfs_fileattr_get(file->f_path.dentry, &fa);
262 if (!err)
> 263 err = put_user(fa.flags, argp);
264 return err;
265 }
266 EXPORT_SYMBOL(ioctl_getflags);
267
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: fs/file_attr.c:263:9: error: unexpected token, expected comma
2026-01-01 1:41 fs/file_attr.c:263:9: error: unexpected token, expected comma kernel test robot
@ 2026-01-02 9:31 ` Al Viro
2026-01-02 10:27 ` Al Viro
0 siblings, 1 reply; 3+ messages in thread
From: Al Viro @ 2026-01-02 9:31 UTC (permalink / raw)
To: kernel test robot
Cc: Andrey Albershteyn, oe-kbuild-all, linux-kernel,
Christian Brauner, Amir Goldstein, Darrick J. Wong, Jan Kara
On Thu, Jan 01, 2026 at 09:41:43AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 9528d5c091c59b408a754a1823cf0942069867cc
> commit: 2f952c9e8fe13c6ee15c05189f1f87c1a70b866c fs: split fileattr related helpers into separate file
> date: 6 months ago
> config: mips-randconfig-r051-20251231 (https://download.01.org/0day-ci/archive/20260101/202601010950.QjCTROwO-lkp@intel.com/config)
> compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project f43d6834093b19baf79beda8c0337ab020ac5f17)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260101/202601010950.QjCTROwO-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202601010950.QjCTROwO-lkp@intel.com/
It has nothing whatsoever to do with the commit in question; I would be
very surprised if the same build was not full of identical errors all
over the place, wherever we happen to use put_user() or get_user().
Basically, you've stumbled across a mips config that breaks something
in their asm/uaccess.h; apparently 32bit with EVA, bringing the macro
horrors from asm-eva.h into play.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: fs/file_attr.c:263:9: error: unexpected token, expected comma
2026-01-02 9:31 ` Al Viro
@ 2026-01-02 10:27 ` Al Viro
0 siblings, 0 replies; 3+ messages in thread
From: Al Viro @ 2026-01-02 10:27 UTC (permalink / raw)
To: kernel test robot
Cc: Andrey Albershteyn, oe-kbuild-all, linux-kernel,
Christian Brauner, Amir Goldstein, Darrick J. Wong, Jan Kara
On Fri, Jan 02, 2026 at 09:31:14AM +0000, Al Viro wrote:
> On Thu, Jan 01, 2026 at 09:41:43AM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 9528d5c091c59b408a754a1823cf0942069867cc
> > commit: 2f952c9e8fe13c6ee15c05189f1f87c1a70b866c fs: split fileattr related helpers into separate file
> > date: 6 months ago
> > config: mips-randconfig-r051-20251231 (https://download.01.org/0day-ci/archive/20260101/202601010950.QjCTROwO-lkp@intel.com/config)
> > compiler: clang version 22.0.0git (https://github.com/llvm/llvm-project f43d6834093b19baf79beda8c0337ab020ac5f17)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260101/202601010950.QjCTROwO-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202601010950.QjCTROwO-lkp@intel.com/
>
> It has nothing whatsoever to do with the commit in question; I would be
> very surprised if the same build was not full of identical errors all
> over the place, wherever we happen to use put_user() or get_user().
>
> Basically, you've stumbled across a mips config that breaks something
> in their asm/uaccess.h; apparently 32bit with EVA, bringing the macro
> horrors from asm-eva.h into play.
FWIW, error message is misleading - it's complaining about the stuff
coming out of inline asm; the token in question is assembler rather than
C one.
Does clang/mips even know about .set eva, seeing that it insists on examining
the inline asm for assembler validity?
Considering this
; cat >/tmp/foo.c <<'EOF'
void f(void)
{
asm volatile(".set push\n.set eva\n.set pop");
}
EOF
; clang --target=mipsel-linux-gnu -mabi=32 -EL -march=mips32r2 -c /tmp/foo.c
/tmp/foo.c:3:27: error: unexpected token, expected comma
3 | asm volatile(".set push\n.set eva\n.set pop");
| ^
<inline asm>:2:9: note: instantiated into assembly here
2 | .set eva
| ^
1 error generated.
;
I rather suspect that it doesn't... FWIW, replacing clang --target=mipsel-linux-gnu
with mips-linux-gnu-gcc works as expected. If you turn that mips32r2 into e.g.
mips32, gcc will spew
/tmp/ccGqqn3X.s: Assembler messages:
/tmp/ccGqqn3X.s:26: Warning: the `eva' extension requires MIPS32 revision 2 or greater
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-02 10:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-01 1:41 fs/file_attr.c:263:9: error: unexpected token, expected comma kernel test robot
2026-01-02 9:31 ` Al Viro
2026-01-02 10:27 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox