public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Srinivas Kandagatla <srini@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: [PATCH 4/4] ASoC: codecs: wsa883x: suppress variant printk
Date: Fri,  2 Jan 2026 12:14:13 +0100	[thread overview]
Message-ID: <20260102111413.9605-5-johan@kernel.org> (raw)
In-Reply-To: <20260102111413.9605-1-johan@kernel.org>

Drivers should generally be silent on successful probe.

Demote the codec variant printk to debug level and instead add a warning
in case an unknown variant is ever encountered.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 sound/soc/codecs/wsa883x.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/sound/soc/codecs/wsa883x.c b/sound/soc/codecs/wsa883x.c
index 3ffea56aeb0f..468d2b38a22a 100644
--- a/sound/soc/codecs/wsa883x.c
+++ b/sound/soc/codecs/wsa883x.c
@@ -1058,22 +1058,23 @@ static int wsa883x_init(struct wsa883x_priv *wsa883x)
 
 	switch (variant) {
 	case WSA8830:
-		dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8830\n",
-			 version);
+		dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8830\n",
+			version);
 		break;
 	case WSA8835:
-		dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835\n",
-			 version);
+		dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835\n",
+			version);
 		break;
 	case WSA8832:
-		dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8832\n",
-			 version);
+		dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8832\n",
+			version);
 		break;
 	case WSA8835_V2:
-		dev_info(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835_V2\n",
-			 version);
+		dev_dbg(wsa883x->dev, "WSA883X Version 1_%d, Variant: WSA8835_V2\n",
+			version);
 		break;
 	default:
+		dev_warn(wsa883x->dev, "unknown variant: %d\n", variant);
 		break;
 	}
 
-- 
2.51.2


  parent reply	other threads:[~2026-01-02 11:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-02 11:14 [PATCH 0/4] ASoC: codecs: wsa88xx: fix codec initialisation Johan Hovold
2026-01-02 11:14 ` [PATCH 1/4] ASoC: codecs: wsa883x: fix unnecessary initialisation Johan Hovold
2026-01-05  9:31   ` Krzysztof Kozlowski
2026-01-02 11:14 ` [PATCH 2/4] ASoC: codecs: wsa881x: " Johan Hovold
2026-01-05  9:32   ` Krzysztof Kozlowski
2026-01-02 11:14 ` [PATCH 3/4] ASoC: codecs: wsa884x: fix codec initialisation Johan Hovold
2026-01-02 11:31   ` Krzysztof Kozlowski
2026-01-02 11:43     ` Johan Hovold
2026-01-02 11:50       ` Krzysztof Kozlowski
2026-01-02 12:17         ` Johan Hovold
2026-01-02 12:26           ` Krzysztof Kozlowski
2026-01-05  9:30   ` Krzysztof Kozlowski
2026-01-02 11:14 ` Johan Hovold [this message]
2026-01-05  9:32   ` [PATCH 4/4] ASoC: codecs: wsa883x: suppress variant printk Krzysztof Kozlowski
2026-01-05 11:50 ` [PATCH 0/4] ASoC: codecs: wsa88xx: fix codec initialisation Srinivas Kandagatla
2026-01-06 18:48 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260102111413.9605-5-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=srini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox