From: Rob Herring <robh@kernel.org>
To: Pankaj Patil <pankaj.patil@oss.qualcomm.com>
Cc: maz@kernel.org, tglx@linutronix.de, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: interrupt-controller: arm: Drop redundant node name restrictions
Date: Fri, 2 Jan 2026 15:47:10 -0600 [thread overview]
Message-ID: <20260102214710.GA226653-robh@kernel.org> (raw)
In-Reply-To: <20251231113026.2480092-1-pankaj.patil@oss.qualcomm.com>
On Wed, Dec 31, 2025 at 05:00:26PM +0530, Pankaj Patil wrote:
> Drop the redundant 'false' patterns so that allowed names
> ('msi-controller', 'gic-its', and 'interrupt-controller') work as intended
>
> GICv3 binding currently disallows child nodes named 'gic-its@' and
> 'interrupt-controller@' via patternProperties set to 'false'. However,
> these names are already permitted (though not preferred) by a subsequent
> pattern that applies the correct schema.
>
> Since the 'false' patterns take precedence, valid nodes such as
> 'gic-its@<addr>' and 'interrupt-controller@<addr>' fail dtbs_check with
> "False schema does not allow" errors
The reason it is done this way is so that we both check the child nodes
and warn on deprecated names.
Fix your .dts files ITS node name to be "msi-controller".
If the node names are fixed everywhere now, then we could just change
this to "^msi-controller@[0-9a-f]+$".
Rob
next prev parent reply other threads:[~2026-01-02 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 11:30 [PATCH] dt-bindings: interrupt-controller: arm: Drop redundant node name restrictions Pankaj Patil
2026-01-02 21:47 ` Rob Herring [this message]
2026-01-05 13:26 ` Pankaj Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260102214710.GA226653-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=pankaj.patil@oss.qualcomm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox