From: David Laight <david.laight.linux@gmail.com>
To: Dipendra Khadka <kdipendra88@gmail.com>
Cc: dhowells@redhat.com, marc.dionne@auristor.com,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/afs: Remove unnecessary integer promotion in format strings
Date: Fri, 2 Jan 2026 22:40:06 +0000 [thread overview]
Message-ID: <20260102224006.39c8398e@pumpkin> (raw)
In-Reply-To: <20260102115749.43639-1-kdipendra88@gmail.com>
On Fri, 2 Jan 2026 11:57:40 +0000
Dipendra Khadka <kdipendra88@gmail.com> wrote:
> Remove 'h' length modifier from printk format strings where integer
> promotion makes it redundant. When short integers are passed to
> variadic functions like pr_notice(), they are automatically promoted
> to int, making the 'h' modifier unnecessary.
Fairly pointless churn for existing code.
The message isn't really right either, 'short integers' are always
promoted to 'int' whenever they are used.
There is nothing special about variadic functions.
David
next prev parent reply other threads:[~2026-01-02 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-02 11:57 [PATCH] fs/afs: Remove unnecessary integer promotion in format strings Dipendra Khadka
2026-01-02 22:40 ` David Laight [this message]
2026-01-03 9:05 ` Dipendra Khadka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260102224006.39c8398e@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=dhowells@redhat.com \
--cc=kdipendra88@gmail.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox