From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76341309DAB for ; Fri, 2 Jan 2026 22:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767393611; cv=none; b=tn+Gerh2n+u+NyAAM4cnR329DkKHRBVK+Ez328FH0gQj0G/8IG8grRYhas1BdcDmwmck5M6CciPnyAPTMkSNxO0EaJrDWr3gq/ZfKGfy5MBSgmDzEJg1nVlNy2SORdChl7l3BA7zkVyEotYJxkXSXJqlOAmxxcHRrauvm6rkSx8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767393611; c=relaxed/simple; bh=AB5d5x6xJ4VIzGgoaon1UxkIiC/MpPNIRf35vm3ikNU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hVbszSoC21C77vFmYQ9fN8UL+4ymuoJ4W20soim/63HUJK3Ul9BkyzC/uqP6TPiQ4hqHJbK2jHnbNvDXD6HBLKauY9trLu5ZMe5comyx2oWelA8txv2XSwq3U6fpC+BcMNl1r9jCTqxhGLWn2VRCIwO2khuT00NqWx+byMVlYY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kpOfmYw3; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kpOfmYw3" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-477a219dbcaso99712005e9.3 for ; Fri, 02 Jan 2026 14:40:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767393608; x=1767998408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/RZB+m5gnvudhaas8cNLQn777VqOfLzhrKTygDpBD/c=; b=kpOfmYw3+ogblcX7UD6fv43OzypImGNN7anoZ+z0YJBxlWAlXZ9aDz3aDbJJWnntKV 7c2X8gz6/EtEejaW6BgzCqWAmYpaU9NHAG013eUeiZcAFRCXlJ0txlU94k5r/4wtRCDb I9muBUBDrirQqCuZNVgAcvoX9VAtTDDxXEK84LO2DUL9jW6xrfAC5eGp13/fUu/TuboL fNFKiABoReZdtmitkpgh3XtvnWlPbw24l92HCeENpIkfudYXs6OzHDalU9AAvqtd6yw5 2rposwhp1mmJRekvXJmdW0ZtAhtN5Mkad7+BEifeY6FQLKsr2dzRPfOTegDxEpLIM5WA NukQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767393608; x=1767998408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/RZB+m5gnvudhaas8cNLQn777VqOfLzhrKTygDpBD/c=; b=mxnbY7e+CkkWKH4AlyyUd0sWWMSMDp+8ptC422/1DGZdDc6JPqlAuWlZLag0lBffrj de1M00Epcu8UUHTWi/k9Fi5ecXfdCDso6ctmkIn9qFWDDE4GBGSRAZUlPAuQ36fvOebS YuPRd6FkKbvo/QHCweBSn4on2PGzm/RD3mdRxkXkcJhd0H17rNFi4OOm6O5pRznVmT5j aYPv0O1yQ7F65mag3iBLI6FzAskxNiM2NGdIDv3vvqiq6fAPCbq4Uhm/5R9o2FHa/7nV BYlqvWT0aTzDKkvVxBODwJdSXV+NRQHeXkqWbSQaWqXPiScvYyUSB9UpJtWzyuE76YBm L3eA== X-Forwarded-Encrypted: i=1; AJvYcCXwmlDCfsPiXOYFMOE9osaNvYucGfjfl3qCb1YjKTrc0CzXc7/+RsHx+GkpD+MUAKXW9UErBGHsH+ArUOw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0wYjIVYHHNQ+kLpL6HVZyJXL+QIr347cbmV1DJcr8+8U2F7a0 89LyFY+xklB4DK6Bbd5kipyQbMZ4hfunDMoYzpu9mmJ/23vP/HJYkTIl X-Gm-Gg: AY/fxX5QsdFiSu7zR5DEFyno3rWa/AqAqZD0q8dZDclLHRVd83F8AVBzmZ4MB/YXszK KIG+LpGVQJrKALNV06ihJhRrE762QU/tj2Tz/SnhqqQt2MCJmfsup2/s+vLpBzkYJzMiEYiThsJ lQ5twXIEwgAz3A5UE6IQ8nY3lIoe0OBF/efKYeIFa6iy748pWU9GrUJxg8K0XE5nzON2cA0Rj9H hAY6f2xkJicrzl5k900mGM0BsXxmbzhBzEc8QZ9A9XQR7y9LpidT/NDq+OSU6IAQy/OvY10LsSB Nx/gNiHr5QVmUPnA6Wp66Tp7ANN6f62+ndIqVIeflCOTegFbdACm5uB+XYfo5enoqT+2IkcN6Lh Y1y6aN4B09sVpBAdKANzJscP/MeTqI8LBO2IUEjHAPtX3fLncV/qsEw8oBGSVa2D62gmOx7xEdu QjqTyd0LN2fgkGicnHadNIHeW/+v+Lf44RWUrf9dJvZthBV5Zp6vJz X-Google-Smtp-Source: AGHT+IGvndyr0aKSUbDWgCqxm7l0mGTRyavS0J073BKaC2P5eQTFjyXTDQnfPjmHYeGCWf4TpdV8Ng== X-Received: by 2002:a05:600c:8107:b0:477:a54a:acba with SMTP id 5b1f17b1804b1-47d19595f6dmr560514885e9.17.1767393607594; Fri, 02 Jan 2026 14:40:07 -0800 (PST) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d6be53a0csm5159685e9.3.2026.01.02.14.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jan 2026 14:40:07 -0800 (PST) Date: Fri, 2 Jan 2026 22:40:06 +0000 From: David Laight To: Dipendra Khadka Cc: dhowells@redhat.com, marc.dionne@auristor.com, linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/afs: Remove unnecessary integer promotion in format strings Message-ID: <20260102224006.39c8398e@pumpkin> In-Reply-To: <20260102115749.43639-1-kdipendra88@gmail.com> References: <20260102115749.43639-1-kdipendra88@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 2 Jan 2026 11:57:40 +0000 Dipendra Khadka wrote: > Remove 'h' length modifier from printk format strings where integer > promotion makes it redundant. When short integers are passed to > variadic functions like pr_notice(), they are automatically promoted > to int, making the 'h' modifier unnecessary. Fairly pointless churn for existing code. The message isn't really right either, 'short integers' are always promoted to 'int' whenever they are used. There is nothing special about variadic functions. David