Re: [syzbot] [mm?] WARNING in folio_remove_rmap_ptes

[Jeongjun Park <aha310510@gmail.com>]

#syz test upstream master

---
 mm/vma.c | 58 ++++++++++++++++++++++++++++++++++++++++++--------------
 mm/vma.h |  3 +++
 2 files changed, 47 insertions(+), 14 deletions(-)

diff --git a/mm/vma.c b/mm/vma.c
index 6377aa290a27..2268f518a89b 100644
--- a/mm/vma.c
+++ b/mm/vma.c
@@ -1130,26 +1130,50 @@ int vma_expand(struct vma_merge_struct *vmg)
        mmap_assert_write_locked(vmg->mm);

        vma_start_write(target);
-       if (next && (target != next) && (vmg->end == next->vm_end)) {
+       if (next && vmg->end == next->vm_end) {
+               struct vm_area_struct *copied_from = vmg->copied_from;
                int ret;

-               sticky_flags |= next->vm_flags & VM_STICKY;
-               remove_next = true;
-               /* This should already have been checked by this point. */
-               VM_WARN_ON_VMG(!can_merge_remove_vma(next), vmg);
-               vma_start_write(next);
-               /*
-                * In this case we don't report OOM, so vmg->give_up_on_mm is
-                * safe.
-                */
-               ret = dup_anon_vma(target, next, &anon_dup);
-               if (ret)
-                       return ret;
+               if (target != next) {
+                       sticky_flags |= next->vm_flags & VM_STICKY;
+                       remove_next = true;
+                       /* This should already have been checked by this point. */
+                       VM_WARN_ON_VMG(!can_merge_remove_vma(next), vmg);
+                       vma_start_write(next);
+                       /*
+                        * In this case we don't report OOM, so vmg->give_up_on_mm is
+                        * safe.
+                        */
+                       ret = dup_anon_vma(target, next, &anon_dup);
+                       if (ret)
+                               return ret;
+               } else if (copied_from) {
+                       vma_start_write(next);
+
+                       /*
+                        * We are copying from a VMA (i.e. mremap()'ing) to
+                        * next, and thus must ensure that either anon_vma's are
+                        * already compatible (in which case this call is a nop)
+                        * or all anon_vma state is propagated to next
+                        */
+                       ret = dup_anon_vma(next, copied_from, &anon_dup);
+                       if (ret)
+                               return ret;
+               } else {
+                       /* In no other case may the anon_vma differ. */
+                       VM_WARN_ON_VMG(target->anon_vma != next->anon_vma, vmg);
+               }
        }

        /* Not merging but overwriting any part of next is not handled. */
        VM_WARN_ON_VMG(next && !remove_next &&
                       next != target && vmg->end > next->vm_start, vmg);
+       /*
+        * We should only see a copy with next as the target on a new merge
+        * which sets the end to the next of next.
+        */
+       VM_WARN_ON_VMG(target == next && vmg->copied_from &&
+                      vmg->end != next->vm_end, vmg);
        /* Only handles expanding */
        VM_WARN_ON_VMG(target->vm_start < vmg->start ||
                       target->vm_end > vmg->end, vmg);
@@ -1807,6 +1831,13 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap,
        VMA_ITERATOR(vmi, mm, addr);
        VMG_VMA_STATE(vmg, &vmi, NULL, vma, addr, addr + len);

+       /*
+        * VMG_VMA_STATE() installs vma in middle, but this is a new VMA, inform
+        * merging logic correctly.
+        */
+       vmg.copied_from = vma;
+       vmg.middle = NULL;
+
        /*
         * If anonymous vma has not yet been faulted, update new pgoff
         * to match new location, to increase its chance of merging.
@@ -1828,7 +1859,6 @@ struct vm_area_struct *copy_vma(struct vm_area_struct **vmap,
        if (new_vma && new_vma->vm_start < addr + len)
                return NULL;    /* should never get here */

-       vmg.middle = NULL; /* New VMA range. */
        vmg.pgoff = pgoff;
        vmg.next = vma_iter_next_rewind(&vmi, NULL);
        new_vma = vma_merge_new_range(&vmg);
diff --git a/mm/vma.h b/mm/vma.h
index e4c7bd79de5f..50f0bdb0eb79 100644
--- a/mm/vma.h
+++ b/mm/vma.h
@@ -106,6 +106,9 @@ struct vma_merge_struct {
        struct anon_vma_name *anon_name;
        enum vma_merge_state state;

+       /* If we are copying a VMA, which VMA are we copying from? */
+       struct vm_area_struct *copied_from;
+
        /* Flags which callers can use to modify merge behaviour: */

        /*
--