From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A43513A86C for ; Sun, 4 Jan 2026 14:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767535398; cv=none; b=XEq+/6Az4CqJ73KlJIrn4yYkbQo+HHY0ElWkhvpj+Tl8lZG9qEHmr6oJJtCXdvIgPBk762Zlu8jq7MIPHeSj+Ro+I/gkcUsFRDtsvFDE64yAiuzVnTg3Oa1l486UOlwq/CF8ua+le23kXJG029oS8G/AnvmQdoO3a7L3LRJEFnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767535398; c=relaxed/simple; bh=Mcb0xRQEqWTTD4csAB6KKuBmISFxJYmZyIhRohkCzEw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nNKEYG7EjjB/TN+UukvM8vJPNenV1+mlrCb2wYdnt4Cn8Bmm73SlhbhPJeuGsPpNvXNZRApIa3VrWmMnGwijShXo4lrlFcD6OXlc2UlszsCAUFZxbY+z4LCGhgEP/OrPZwMXFmzouvie+KywPSYE44Txca8NqO2HMv4ZfweOh0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Da2gClUK; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CflzdpUw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Da2gClUK"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CflzdpUw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767535394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1WmKWHjTK9kQE8cov6ad+xozYqmDEFZuRGy+ZcYHfU4=; b=Da2gClUK0178pRz9OrstHo+oDefJkX+fh1onh2hS4d/P2tTG8IgkqrujyUmMPIxgKRsEVN Zqc+YQH5T+YLOY1Doop/FobKHzcygVQ83g+gfk+b6gQLceDG9XzZOxlSszfgA6Evz8Svmm mPtmrAFtDyOmK6k6CrjNXXrZrLCeLvo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-DRVy7uYDMYWJCKTg6irJ2g-1; Sun, 04 Jan 2026 09:03:12 -0500 X-MC-Unique: DRVy7uYDMYWJCKTg6irJ2g-1 X-Mimecast-MFC-AGG-ID: DRVy7uYDMYWJCKTg6irJ2g_1767535392 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4779d8fd4ecso6638085e9.1 for ; Sun, 04 Jan 2026 06:03:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767535392; x=1768140192; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=1WmKWHjTK9kQE8cov6ad+xozYqmDEFZuRGy+ZcYHfU4=; b=CflzdpUwEZtg5SA+Zs6HllHUel1VxpHlsAZ4zysGOdVNRzLy5zO+Q0A98PTOegjzdf vZOWTzqmDl3APz7AzfDdbmjXQC9iltuX0C8CIhRgu7iQ9STBHppUQpIVg+R0Oz+xHdQQ 4ue4m7iJlN/WjlQKvsXBMXS7wEy3kN6RWzb1nZcWT9d1pUewzYBHRnIk9ZXKp8rz0kED zSPYT/uiWUS/+EgV5x54mwLwKQrxuawDo4j8T4NI8T90SScRz4lwG9yuR29e8fG+re0s 41rugxP+qQtN/SAr2ApdpiQkwktin2vwT10dpCYOfxPiJ7OCGdwJr9wmitaV5CACF2M6 VlBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767535392; x=1768140192; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1WmKWHjTK9kQE8cov6ad+xozYqmDEFZuRGy+ZcYHfU4=; b=V/DvfqFyFVLpvSZI49yQxrzSBt3/hPFc3WhfdLnuugNKhKKPES7tVZcob5zdJZSh6v SDjuBZ3Ltl46yfHyLiKAk/Zppp/0XDv0scK59f9IVkGbWD92LnVAMfHy0QoVKCJLKQOo cZBpXY2sCnuJ8c1c66pbehitcQUYB6tddB4q9eotQA3LYPUzc9RNpqrNXHwUZK1mIxyi AqDcfhQ3lIOTx5MwOIu3heAbO3Vp9wrvEx8lft790ifJArFF8CsZnKxTUJYdzIWmeJR+ NgDejwGZsbndQc0j1p425vHPNkRqH47uqkjLpEa4FEZI1mgsJiwHSmNS/HWPQQsRGeKm H1Pg== X-Forwarded-Encrypted: i=1; AJvYcCXUb9Wvk3G48qOd34/JYUb7vAPhNtzwRjpEkTCraUdEt+NOqLWqxZEuNcIeVPp+EyBLrYLKD+1alpeco/I=@vger.kernel.org X-Gm-Message-State: AOJu0YyC0ZGdYWdD6u8H9MWH0eLJRTrumdWIAlOmlqD81902DUpt15OC j7JaySo+NyiHbVsUKXrXohc44YGwWJOGx3HGlxS0lbU3sLHZjw+FBrMrFyDJWxVDkXLV7v+b3nv lI4DniP5p5G/Tfekub/EGi7FgWJdLHrr2mMNWk+YOoi640Ns8XLK9kM41x5PnKix5+Q== X-Gm-Gg: AY/fxX4UCrjnAek8xaEZ45iAQCzG8QIkrgCYsyfBJ9UUAudJHVcoA11ILzV3gZ/7avB TeIZh5o+RCx/XvWJLFuoakWUwlGIVhs6VIn7Ba00NBb/GNK2SfRQi/lXt6yKecwwZi3yFgiayX2 XaViW7LcjtH6UV7vifjuOX1AadZVCbIgZHEeLgTAQSvnhNDYsvBlrmzvHvN1GpAZjxfV0qsghkS ls9V+wuGPVVgV2ovRL0a1bbCdBCXe6M7FD2xP/8tbQlEFXA4b+xUDq7drZmtLbd0P4pPx9B+As4 Ano4plTqbcQuaORGG/9GSnEWKrmwGquCAkFPsJiYW8QA554TdP9Vq3DMdN+4WpgjvdB/rIEducb X7QQ5p1FMraLFxkfNSrkja3xD6v6J6Qx6wg== X-Received: by 2002:a05:600c:1f0f:b0:475:ddad:c3a9 with SMTP id 5b1f17b1804b1-47d6ba88537mr68390905e9.13.1767535391457; Sun, 04 Jan 2026 06:03:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IFUGdUDvh1D/AAd/73vhi+i7WC7g6t/YWcLmIxzwKqgOiJl8nVvOTHVTG0aB3EomaU37dw0yw== X-Received: by 2002:a05:600c:1f0f:b0:475:ddad:c3a9 with SMTP id 5b1f17b1804b1-47d6ba88537mr68390295e9.13.1767535390916; Sun, 04 Jan 2026 06:03:10 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d6d1490efsm94869865e9.7.2026.01.04.06.03.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 06:03:10 -0800 (PST) Date: Sun, 4 Jan 2026 09:03:06 -0500 From: "Michael S. Tsirkin" To: Bui Quang Minh Cc: Jason Wang , netdev@vger.kernel.org, Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net v2 1/3] virtio-net: don't schedule delayed refill worker Message-ID: <20260104085846-mutt-send-email-mst@kernel.org> References: <20260102152023.10773-1-minhquangbui99@gmail.com> <20260102152023.10773-2-minhquangbui99@gmail.com> <6bac1895-d4a3-4e98-8f39-358fa14102db@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6bac1895-d4a3-4e98-8f39-358fa14102db@gmail.com> On Sun, Jan 04, 2026 at 03:34:52PM +0700, Bui Quang Minh wrote: > On 1/4/26 13:09, Jason Wang wrote: > > On Fri, Jan 2, 2026 at 11:20 PM Bui Quang Minh wrote: > > > When we fail to refill the receive buffers, we schedule a delayed worker > > > to retry later. However, this worker creates some concurrency issues > > > such as races and deadlocks. To simplify the logic and avoid further > > > problems, we will instead retry refilling in the next NAPI poll. > > > > > > Fixes: 4bc12818b363 ("virtio-net: disable delayed refill when pausing rx") > > > Reported-by: Paolo Abeni > > > Closes: https://netdev-ctrl.bots.linux.dev/logs/vmksft/drv-hw-dbg/results/400961/3-xdp-py/stderr > > > Cc: stable@vger.kernel.org > > > Suggested-by: Xuan Zhuo > > > Signed-off-by: Bui Quang Minh > > > --- > > > drivers/net/virtio_net.c | 55 ++++++++++++++++++++++------------------ > > > 1 file changed, 30 insertions(+), 25 deletions(-) > > > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > > index 1bb3aeca66c6..ac514c9383ae 100644 > > > --- a/drivers/net/virtio_net.c > > > +++ b/drivers/net/virtio_net.c > > > @@ -3035,7 +3035,7 @@ static int virtnet_receive_packets(struct virtnet_info *vi, > > > } > > > > > > static int virtnet_receive(struct receive_queue *rq, int budget, > > > - unsigned int *xdp_xmit) > > > + unsigned int *xdp_xmit, bool *retry_refill) > > > { > > > struct virtnet_info *vi = rq->vq->vdev->priv; > > > struct virtnet_rq_stats stats = {}; > > > @@ -3047,12 +3047,8 @@ static int virtnet_receive(struct receive_queue *rq, int budget, > > > packets = virtnet_receive_packets(vi, rq, budget, xdp_xmit, &stats); > > > > > > if (rq->vq->num_free > min((unsigned int)budget, virtqueue_get_vring_size(rq->vq)) / 2) { > > > - if (!try_fill_recv(vi, rq, GFP_ATOMIC)) { > > > - spin_lock(&vi->refill_lock); > > > - if (vi->refill_enabled) > > > - schedule_delayed_work(&vi->refill, 0); > > > - spin_unlock(&vi->refill_lock); > > > - } > > > + if (!try_fill_recv(vi, rq, GFP_ATOMIC)) > > > + *retry_refill = true; > > > } > > > > > > u64_stats_set(&stats.packets, packets); > > > @@ -3129,18 +3125,18 @@ static int virtnet_poll(struct napi_struct *napi, int budget) > > > struct send_queue *sq; > > > unsigned int received; > > > unsigned int xdp_xmit = 0; > > > - bool napi_complete; > > > + bool napi_complete, retry_refill = false; > > > > > > virtnet_poll_cleantx(rq, budget); > > > > > > - received = virtnet_receive(rq, budget, &xdp_xmit); > > > + received = virtnet_receive(rq, budget, &xdp_xmit, &retry_refill); > > I think we can simply let virtnet_receive() to return the budget when > > reill fails. > > That makes sense, I'll change it. > > > > > > rq->packets_in_napi += received; > > > > > > if (xdp_xmit & VIRTIO_XDP_REDIR) > > > xdp_do_flush(); > > > > > > /* Out of packets? */ > > > - if (received < budget) { > > > + if (received < budget && !retry_refill) { > > > napi_complete = virtqueue_napi_complete(napi, rq->vq, received); > > > /* Intentionally not taking dim_lock here. This may result in a > > > * spurious net_dim call. But if that happens virtnet_rx_dim_work > > > @@ -3160,7 +3156,7 @@ static int virtnet_poll(struct napi_struct *napi, int budget) > > > virtnet_xdp_put_sq(vi, sq); > > > } > > > > > > - return received; > > > + return retry_refill ? budget : received; > > > } > > > > > > static void virtnet_disable_queue_pair(struct virtnet_info *vi, int qp_index) > > > @@ -3230,9 +3226,11 @@ static int virtnet_open(struct net_device *dev) > > > > > > for (i = 0; i < vi->max_queue_pairs; i++) { > > > if (i < vi->curr_queue_pairs) > > > - /* Make sure we have some buffers: if oom use wq. */ > > > - if (!try_fill_recv(vi, &vi->rq[i], GFP_KERNEL)) > > > - schedule_delayed_work(&vi->refill, 0); > > > + /* If this fails, we will retry later in > > > + * NAPI poll, which is scheduled in the below > > > + * virtnet_enable_queue_pair > > > + */ > > > + try_fill_recv(vi, &vi->rq[i], GFP_KERNEL); > > Consider NAPI will be eventually scheduled, I wonder if it's still > > worth to refill here. > > With GFP_KERNEL here, I think it's more likely to succeed than GFP_ATOMIC in > NAPI poll. Another small benefit is that the actual packet can happen > earlier. In case the receive buffer is empty and we don't refill here, the > #1 NAPI poll refill the buffer and the #2 NAPI poll can receive packets. The > #2 NAPI poll is scheduled in the interrupt handler because the #1 NAPI poll > will deschedule the NAPI and enable the device interrupt. In case we > successfully refill here, the #1 NAPI poll can receive packets right away. > Right. But I think this is a part that needs elucidating, not error handling. /* Pre-fill rq agressively, to make sure we are ready to get packets * immediately. * */ > > > > > err = virtnet_enable_queue_pair(vi, i); > > > if (err < 0) > > > @@ -3473,15 +3471,15 @@ static void __virtnet_rx_resume(struct virtnet_info *vi, > > > bool refill) > > > { > > > bool running = netif_running(vi->dev); > > > - bool schedule_refill = false; > > > > > > - if (refill && !try_fill_recv(vi, rq, GFP_KERNEL)) > > > - schedule_refill = true; > > > + if (refill) > > > + /* If this fails, we will retry later in NAPI poll, which is > > > + * scheduled in the below virtnet_napi_enable > > > + */ > > > + try_fill_recv(vi, rq, GFP_KERNEL); > > and here. > > > > > + > > > if (running) > > > virtnet_napi_enable(rq); here the part that isn't clear is why are we refilling if !running and what handles failures in that case. > > > - > > > - if (schedule_refill) > > > - schedule_delayed_work(&vi->refill, 0); > > > } > > > > > > static void virtnet_rx_resume_all(struct virtnet_info *vi) > > > @@ -3777,6 +3775,7 @@ static int virtnet_set_queues(struct virtnet_info *vi, u16 queue_pairs) > > > struct virtio_net_rss_config_trailer old_rss_trailer; > > > struct net_device *dev = vi->dev; > > > struct scatterlist sg; > > > + int i; > > > > > > if (!vi->has_cvq || !virtio_has_feature(vi->vdev, VIRTIO_NET_F_MQ)) > > > return 0; > > > @@ -3829,11 +3828,17 @@ static int virtnet_set_queues(struct virtnet_info *vi, u16 queue_pairs) > > > } > > > succ: > > > vi->curr_queue_pairs = queue_pairs; > > > - /* virtnet_open() will refill when device is going to up. */ > > > - spin_lock_bh(&vi->refill_lock); > > > - if (dev->flags & IFF_UP && vi->refill_enabled) > > > - schedule_delayed_work(&vi->refill, 0); > > > - spin_unlock_bh(&vi->refill_lock); > > > + if (dev->flags & IFF_UP) { > > > + /* Let the NAPI poll refill the receive buffer for us. We can't > > > + * safely call try_fill_recv() here because the NAPI might be > > > + * enabled already. > > > + */ > > > + local_bh_disable(); > > > + for (i = 0; i < vi->curr_queue_pairs; i++) > > > + virtqueue_napi_schedule(&vi->rq[i].napi, vi->rq[i].vq); > > > + > > > + local_bh_enable(); > > > + } > > > > > > return 0; > > > } > > > -- > > > 2.43.0 > > > > > Thanks > > > > Thanks, > Quang Minh.