From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41CE3D27E for ; Mon, 5 Jan 2026 00:02:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767571355; cv=none; b=j5RvGAo05CshuZ/D3m4CUKLGHzEd8SmzBqbd3Oo9Bltp5QWQ+IEc6zH+rQk+bnU3lYxq6OsSMPXBrhLtPMWJSexH6WuRmjBPGKOMzs7ZfMTzN31fOG0JDZGUIRZUoEdTTBflrv1C1tzfhrubzbDc0gkdUTmLBEE3QqoFUWqhHtA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767571355; c=relaxed/simple; bh=5Pd8XHirDAvBeGnaTQQoB4X3T4keVMq6ZwvkHBRkwKA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FWgJ1Ir1+03BkQmQNAR/dHhzf2RwE6nSUNs/CJZP0glMHUcsyxXePMLs4+5k8Zb4uyzvuWj0lC3wA2jc5w9b3TdZODjXkbb+gwTBsOqfzlNXiF7NHKMwJb6DUaYGnzaPkX0UfOFa1+M2IsFKd4rpSnKK70uhR2U0wuGCnNuX7PQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=emmKnoUm; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="emmKnoUm" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-8be92e393f8so157500485a.1 for ; Sun, 04 Jan 2026 16:02:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1767571351; x=1768176151; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8+jSiPWTak82xdkGqmhBxUT/Rw7weH7GEOHsr3Ick4Q=; b=emmKnoUmWyUMPTZnoiMQ2YplhNwQ4YrMV2CTkgvY75AZb7tEVNxHGroI1FPmSnx5D3 hDWaZYAFW4XHMGlccEOpeCRmgWsLoQOyrvvYa4PBy8bki/RomRSnT4yHAuJNOMEvr73P +IYULscK+k0h5QFac9hE/sXqN9+E7uLxFxL+21zw4gc/ktGo7/ZgO1OOrE93dSLUi1e3 gDVaxAxzd/xsALH2vsF7zp9OY5fVaDPDSxWVqHoZRVwvgh9RBJMxnebcuAtJ7Nt/LkjB 7XzLaZkQqpGmLNTIibDLLH7NspR3wBc5vkqWofTUknHCe7CRBW2T5QkqCpBZ4GnXmKHD R4EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767571351; x=1768176151; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8+jSiPWTak82xdkGqmhBxUT/Rw7weH7GEOHsr3Ick4Q=; b=fYcYGQ4qD1hSxINs5ilb8o5w4MPksG4fXTinXooAOmOvyRz/MU59/eEyBqaGwzKthi nZVCVEBaKpjvkpCCYebAyfHRlAwTEoHUvmZ+/8BQ31ffiYeWlDpQTBaPiFIX60d9+8vA VDh6t/4ME29c1/otfhFqOpuf8bT3Xb3eTziisVF9YwkxbQHo09SBOpU42qPveX35TXvt Lu85EpYS2scKQhn9D6+FuUsEFiQpITsyIT5uTSLj9d4uf0cvwz5LpKcfbyemXjSfdpH8 75hke7qcLzPj8LBiuT9OCL1MZjxzx9bTCzHaeG/0HiVMnBQWV19iG0WPBmLhlO8UbfNX V5EA== X-Forwarded-Encrypted: i=1; AJvYcCVwCMtftIvU2AeRx8rFwGb7Gqo60Mr5J8DssNOn/w3f/VHRpb77WrQPtajXA6PatNiIm1RdL3/8dih8nXg=@vger.kernel.org X-Gm-Message-State: AOJu0YxbhKsgmZ7OElFx3QWbPor/HLr54oJQ9WNGX0ee3kF3zDC9VbXD KQdty6KZS2LZTK3JDgb5KQI5a0oEKsRo6LNCx14pDj5t7TPth0CuhGf7bQPaRBhx7z4= X-Gm-Gg: AY/fxX4VBD9nq/NhFXjCyb6SanWOLAjnZ2kvaXfVTY9UT2Zsj0jqZG2lkqWx9Tqsc/l vzUjZKM45fbvHFiDknU1lTctrLZ+C8NI5u5Z5mmkcq8ToEX3mbn0QedT4iICtUITVEXnh3vdHRL Cs4yQO/ZbDEnlKbhabTk7PTEyjxzJP/T+IsIzypk/HUoD9Vr7erZ71lyLx4FupvqTSxOgrZ8tIx hDjC2vNjtKpbqQLzcJIE3M5pgCH6kl7fPt3b567H/OBcy4Df8VKI8KnsgDLo3zJ0LDRuEQAGYjS 0CJlg9L+ux+d+UeeTdpFOY2n28M3/9hn2BATTHGmUtBOLcmaKuCNxwSf+k81MK9bV88vY5h7muo VcLVenfJIQFHnF5T3BncOpBcrPc0Xu4SejFoQRxadPinsZytqX32/gD4y1cU1zolEtxI0D75jxU fMUQtvfrrBPC4mDqFoatc+Wp+097K2tHZZojAfVYBT1vQ8VCGwejGoj+VSYNR/Ib+peTU= X-Google-Smtp-Source: AGHT+IGiRum5OAeqK7KwLoeA3fYC8uB4/qk0h6ByodkxfauKgGSblQTUCpTabkdDEAjM1i6E2aZiIQ== X-Received: by 2002:a05:620a:440b:b0:8a2:595f:657 with SMTP id af79cd13be357-8c356f10068mr814244585a.21.1767571350945; Sun, 04 Jan 2026 16:02:30 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-162-112-119.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.112.119]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c09688e3d4sm3545746985a.13.2026.01.04.16.02.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jan 2026 16:02:30 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1vcY3J-0000000156c-2OeL; Sun, 04 Jan 2026 20:02:29 -0400 Date: Sun, 4 Jan 2026 20:02:29 -0400 From: Jason Gunthorpe To: Dawei Li Cc: will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, set_pte_at@outlook.com, stable@vger.kernel.org Subject: Re: [PATCH] iommu/arm-smmu-v3: Maintain valid access attributes for non-coherent SMMU Message-ID: <20260105000229.GC125261@ziepe.ca> References: <20251229002354.162872-1-dawei.li@linux.dev> <20260102184113.GA125261@ziepe.ca> <20260104133532.GA173992@wendao-VirtualBox> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260104133532.GA173992@wendao-VirtualBox> > > /* DMA for "CMDQ MSI" which targets q->base_dma allocated by arm_smmu_init_one_queue() */ > > > > > @@ -1612,11 +1624,18 @@ void arm_smmu_make_cdtable_ste(struct arm_smmu_ste *target, > > > (cd_table->cdtab_dma & STRTAB_STE_0_S1CTXPTR_MASK) | > > > FIELD_PREP(STRTAB_STE_0_S1CDMAX, cd_table->s1cdmax)); > > > > > > + if (smmu_coherent(smmu)) { > > > + val = FIELD_PREP(STRTAB_STE_1_S1CIR, STRTAB_STE_1_S1C_CACHE_WBRA) | > > > + FIELD_PREP(STRTAB_STE_1_S1COR, STRTAB_STE_1_S1C_CACHE_WBRA) | > > > + FIELD_PREP(STRTAB_STE_1_S1CSH, ARM_SMMU_SH_ISH); > > > + } else { > > > + val = FIELD_PREP(STRTAB_STE_1_S1CIR, STRTAB_STE_1_S1C_CACHE_NC) | > > > + FIELD_PREP(STRTAB_STE_1_S1COR, STRTAB_STE_1_S1C_CACHE_NC) | > > > + FIELD_PREP(STRTAB_STE_1_S1CSH, ARM_SMMU_SH_OSH); > > > + } > > > > This one is "CD fetch" allocated by arm_smmu_alloc_cd_ptr() > > > > etc > > > > And note that the above will need this hunk too: > > > > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3-iommufd.c > > @@ -432,6 +432,14 @@ size_t arm_smmu_get_viommu_size(struct device *dev, > > !(smmu->features & ARM_SMMU_FEAT_S2FWB)) > > return 0; > > > > + /* > > + * When running non-coherent we can't suppot S2FWB since it will also > > + * force a coherent CD fetch, aside from the question of what > > + * S2FWB/CANWBS even does with non-coherent SMMUs. > > + */ > > + if (!smmu_coherent(smmu)) > > + return 0; > > I was wondering why S2FWB can affect CD fetching before reading 13.8. Yeah, that table is super useful > + if (!fwb) { > + val = FIELD_PREP(STRTAB_STE_1_S1CIR, STRTAB_STE_1_S1C_CACHE_NC) | > + FIELD_PREP(STRTAB_STE_1_S1COR, STRTAB_STE_1_S1C_CACHE_NC) | > + FIELD_PREP(STRTAB_STE_1_S1CSH, ARM_SMMU_SH_OSH); > + } else { > + dev_warn(&smmu->dev, "Inconsitency between COHACC & S2FWB\n"); > + /* FIX ME */ > + return; I prefer we block it as I showed instead of printing a warning, cache inconsistencies in virtualization can become security problems. Though it is probably good to add a comment here about s2fwb also Jason