Re: [PATCH v2] perf symbol: remove Rust symbol workarounds

Namhyung Kim
2026-01-07T18:18:21Z

On Wed, Jan 07, 2026 at 10:38:40AM -0300, Arnaldo Carvalho de Melo wrote:
> On Wed, Jan 07, 2026 at 12:04:32AM -0800, Namhyung Kim wrote:
> > On Mon, Jan 05, 2026 at 12:50:15PM -0300, Arnaldo Carvalho de Melo wrote:
> > > On Mon, Jan 05, 2026 at 03:00:57PM +0000, Gary Guo wrote:
> > > > Due to an off-by-one error introduced in commit 73bbb94466fd ("kallsyms:
> > > > support "big" kernel symbols"), long symbols (which are currently only
> > > > produced by Rust) can have their symbol type being wrongly parsed by
> > > > kernel/kallsyms.c.
>
> > > Looks sane, applied to perf-tools-next,
>
> > I'm afraid there may be some outdated kernels which don't have the fix
> > yet. Maybe make sense to wait some more time for them to disappear?
>
> Right, I took it more as it seems to be just a blip in time, something
> that came and went quickly and that most likely will not cause problems,
> i.e. just a handful of extra symbols in the lookup data structures in
> those particular kernels and a new 'perf test' tool with these reverts,
> if run on those particular kernels would then fail for that particular
> test case, for a known reason.
>
> So with the above rationale you still feel strongly about having it
> applied?

No, it's good to go. Thanks for the explanation!

Namhyung