The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Florian Fainelli <florian.fainelli@broadcom.com>,
	 Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	 Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>
Cc: devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 02/13] ARM: dts: broadcom: bcm2835-rpi: Move non simple-bus nodes to root level
Date: Tue, 06 Jan 2026 20:09:41 -0600	[thread overview]
Message-ID: <20260106-dt-dtbs-broadcom-fixes-v1-2-ba45874e4553@kernel.org> (raw)
In-Reply-To: <20260106-dt-dtbs-broadcom-fixes-v1-0-ba45874e4553@kernel.org>

The 'gpu' and 'firmware' nodes are not MMIO devices, so they should not be
under a 'simple-bus'. Additionally, the "raspberrypi,bcm2835-power" node
is part of the firmware, so move it under the /firmware node.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 arch/arm/boot/dts/broadcom/bcm2835-common.dtsi |  7 ++++---
 arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi    | 16 ++++++++--------
 2 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/arch/arm/boot/dts/broadcom/bcm2835-common.dtsi b/arch/arm/boot/dts/broadcom/bcm2835-common.dtsi
index 9261b67dbee1..1e76b290510d 100644
--- a/arch/arm/boot/dts/broadcom/bcm2835-common.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm2835-common.dtsi
@@ -141,9 +141,10 @@ v3d: v3d@7ec00000 {
 			interrupts = <1 10>;
 		};
 
-		vc4: gpu {
-			compatible = "brcm,bcm2835-vc4";
-		};
+	};
+
+	vc4: gpu {
+		compatible = "brcm,bcm2835-vc4";
 	};
 };
 
diff --git a/arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi b/arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi
index e9bf41b9f5c1..9ab70b519a63 100644
--- a/arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm2835-rpi.dtsi
@@ -1,15 +1,13 @@
 #include <dt-bindings/power/raspberrypi-power.h>
 
 / {
-	soc {
-		firmware: firmware {
-			compatible = "raspberrypi,bcm2835-firmware", "simple-mfd";
-			mboxes = <&mailbox>;
+	firmware: firmware {
+		compatible = "raspberrypi,bcm2835-firmware", "simple-mfd";
+		mboxes = <&mailbox>;
 
-			firmware_clocks: clocks {
-				compatible = "raspberrypi,firmware-clocks";
-				#clock-cells = <1>;
-			};
+		firmware_clocks: clocks {
+			compatible = "raspberrypi,firmware-clocks";
+			#clock-cells = <1>;
 		};
 
 		power: power {
@@ -17,7 +15,9 @@ power: power {
 			firmware = <&firmware>;
 			#power-domain-cells = <1>;
 		};
+	};
 
+	soc {
 		vchiq: mailbox@7e00b840 {
 			compatible = "brcm,bcm2835-vchiq";
 			reg = <0x7e00b840 0x3c>;

-- 
2.51.0


  parent reply	other threads:[~2026-01-07  2:10 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-07  2:09 [PATCH 00/13] dts: broadcom: Fix remaining DT warnings Rob Herring (Arm)
2026-01-07  2:09 ` [PATCH 01/13] ARM: dts: broadcom: bcm2711: Fix 'simple-bus' node names Rob Herring (Arm)
2026-01-08 17:32   ` Florian Fainelli
2026-01-07  2:09 ` Rob Herring (Arm) [this message]
2026-01-08 17:32   ` [PATCH 02/13] ARM: dts: broadcom: bcm2835-rpi: Move non simple-bus nodes to root level Florian Fainelli
2026-01-09 12:01   ` Marek Szyprowski
2026-01-12 18:09     ` Rob Herring
2026-01-16 21:49       ` Florian Fainelli
2026-01-07  2:09 ` [PATCH 03/13] arm64: dts: broadcom: bcm2712: " Rob Herring (Arm)
2026-01-08 17:33   ` Florian Fainelli
2026-01-16 21:49     ` Florian Fainelli
2026-01-07  2:09 ` [PATCH 04/13] arm64: dts: broadcom: Remove unused and undocumented nodes Rob Herring (Arm)
2026-01-08 17:33   ` Florian Fainelli
2026-01-07  2:09 ` [PATCH 05/13] arm64: dts: broadcom: stingray: Rework clock nodes Rob Herring (Arm)
2026-01-08 17:34   ` Florian Fainelli
2026-01-07  2:09 ` [PATCH 06/13] arm64: dts: broadcom: stingray: Fix 'simple-bus' node names Rob Herring (Arm)
2026-01-08 17:34   ` Florian Fainelli
2026-01-07  2:09 ` [PATCH 07/13] arm64: dts: broadcom: stingray: Move raid nodes out of bus Rob Herring (Arm)
2026-01-08 17:34   ` Florian Fainelli
2026-01-07  2:09 ` [PATCH 08/13] arm64: dts: broadcom: Use preferred node names Rob Herring (Arm)
2026-01-08 17:35   ` Florian Fainelli
2026-01-07  2:09 ` [PATCH 09/13] arm64: dts: broadcom: ns2-svk: Use non-deprecated at25 properties Rob Herring (Arm)
2026-01-08 17:35   ` Florian Fainelli
2026-01-07  2:09 ` [PATCH 10/13] arm64: dts: broadcom: northstar2: Rework clock nodes Rob Herring (Arm)
2026-01-08 17:36   ` Florian Fainelli
2026-01-07  2:09 ` [PATCH 11/13] arm64: dts: broadcom: northstar2: Drop unused and undocumented "brcm,pcie-ob-oarr-size" properties Rob Herring (Arm)
2026-01-08 17:36   ` Florian Fainelli
2026-01-07  2:09 ` [PATCH 12/13] arm64: dts: broadcom: northstar2: Drop QSPI "clock-names" Rob Herring (Arm)
2026-01-08 17:36   ` Florian Fainelli
2026-01-07  2:09 ` [PATCH 13/13] arm64: dts: broadcom: northstar2: Drop "arm,cci-400-pmu" fallback compatible Rob Herring (Arm)
2026-01-08 17:36   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260106-dt-dtbs-broadcom-fixes-v1-2-ba45874e4553@kernel.org \
    --to=robh@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox