From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A1393246ED for ; Tue, 6 Jan 2026 07:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767686242; cv=none; b=KjefFJvftl0DgCkXb+fBjb6R+ACzfQdEhyWk/qyWSD0fs6w3vXqjxUd2QdoylM74EMK16qT+gcB7NCtlyoKN5ahNRocjMcXRdSqY/AmXwM5m51zxrMSzv5pBxwlQh2vO/LgW1TxIkCs3PWTmLOb4RkoQUBRfFXAO4E2RmjgVDko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767686242; c=relaxed/simple; bh=2dfXE3T5FZ6K7+lqEmh5QGLTAful/RxL5/OXaLyX+Qg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kW8mQ0gBphQ7SC8oeRnAjA3LJPNy++gm8zdzHnmnwhb+oEuKkWAYHH8cj+UZC+vhESPNcIHzXPpXa/NPna9hL61SWHAUWMUIQropfD8PT0iHgthLB7/nbrb8ONhD7KcMnIAWvQ8t6wGsWvF9kEp8lOqXCxS6jNgXtxoTal7lX4M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Jw29zZzF; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LeDenq8S; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Jw29zZzF"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LeDenq8S" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767686240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I4TYkMIrp7AW9u8pmueM8oRPi406uK0ebNKTuLEzFRw=; b=Jw29zZzFglG919JgI7i0xklQ2oObYZyc5leVLnIfHti9CJweJNPNRzG8C5PabdVmP4/3fY M+7UoQk0lJjSmBkBb7s9m1F/B8AYBTpQLUP/nNuyP4dtnrpMhO1TRrPHTSZfGnUDm1nqke v82l+dtoQG1lYYlghba+tsFch4GvB/Y= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-Q2cn7TcKNjynIfO2jwQVzw-1; Tue, 06 Jan 2026 02:57:18 -0500 X-MC-Unique: Q2cn7TcKNjynIfO2jwQVzw-1 X-Mimecast-MFC-AGG-ID: Q2cn7TcKNjynIfO2jwQVzw_1767686238 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-43284f60a8aso339388f8f.3 for ; Mon, 05 Jan 2026 23:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767686237; x=1768291037; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=I4TYkMIrp7AW9u8pmueM8oRPi406uK0ebNKTuLEzFRw=; b=LeDenq8S5nv1p5lbaG6bd7qQ738zFIig+xqeNByShq94AUmv6LVa9pKSf9J1W5Rvyp a4bTksPldxgUqtTtC3rXjxeQHKFhiLku4vgmYc9HxnpTLP59/URIqLJO9V00xk0mypr2 lAAYI8KGC1JW4u9BdcckgkMZjVkbidLQPY/AciyE/XdkY8aGcIpOs8W57Qzbf07TZZTG Awn1QX64ukazoBaBWNdki2gL8VgOqTxh5NiZD7j8r+6gi1TQNDHg7i8JZVv8RXXO+v/D +ZD0joO/4c/Cv65l7kfapujl4m6N+i+k0xozFpjQIi82BEqVNieCIo11+WtDdJSlvFpL KJfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767686237; x=1768291037; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I4TYkMIrp7AW9u8pmueM8oRPi406uK0ebNKTuLEzFRw=; b=eoMoTumJa+JKFmvVy+HWGT7mszO9VkOMJ+oPXFXuTqTy1h5k0VnN2FSTiCRqqNCnP0 m/vtlSHm2QhLKjE0LmknjVb5Q2FqElS3RW2MtNT/zxoqCgRAMNGYp2yEgtqXRFkxN4Ha 70YTANiCYUTF04z5/1bCgWzTIAh9auh45zvWBalgiLH2Y49OfcJYTpPjeCL+7nRkVNe8 1ZMYdyKJc5T8EBjYsulJJp/SEjp6YgQgXOiGmNZCidGV8mF2zk1gdQnu6Za2B+LUmqs/ /g8haa+hLDnSJ6UlFB80gCd7Vc581i2JTPk7IDNhqkGWrIFkh/nY8oW/BNGCYzfyfqbt MNTQ== X-Forwarded-Encrypted: i=1; AJvYcCXKuSqEs45L/J/BIvzwp6ReMDhWWDhkIiUX8pC34cGj3liZTN6gpblRAxsl0VXChOfJ1SeRRS/G5ZgNhho=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf+Xqa9+Q3myeMVA++geTkLgTUOkg5cQOMEhjag6s6u5AxuBV5 eMFRBTQ/+V+a/ERsjpDaeWOVw6mJrAem9tcIq35A+HEDpLkGgOZvEZAU4bxOE1hZQMBuyuT+sIo ll4tnVKSZSESbQ7MNh13qfkfSspnwyCOuXCvLu6j2XnVijt9pfNEGKRXI0Dqm4S6NiA== X-Gm-Gg: AY/fxX7SQN/51yRA+dGwjUn1VB6uewJS5KgzR48Y97sHJzxsH7fywIYBY6E9tA3mrcZ MZADtj5xT0vt+rUx9E+V+Hzcel/KOksxGEo3FGZyiCBIL/4NvuaBj6tIcP7kiOfRjlm2KgCZyjN D3gi8OfRMsGStchmGR20mOF9AlyPv6rGS1D4iAd/1pBTUuLeG73N0zDCoocNplnEziEeh4YKdll j9T7JNIYH2WOSs9Ld9zh5gcU/Y3y0ALAyxACxqDcHLCNV7gNERXt8NUgXU2wX4UChB/deOV4pQf D2v5hNpjYc/A5AYaRIalrfhclD0GgYggufH8bKK2XeF7G/eu95lv/a4JE0yZMo+SiayK1Dr8lD0 4EVqu4EZhXXT86sxd4/hy7w4BK6nfgyyXCw== X-Received: by 2002:a05:600c:444d:b0:46e:32d4:46a1 with SMTP id 5b1f17b1804b1-47d7f09ca36mr23148195e9.22.1767686237595; Mon, 05 Jan 2026 23:57:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHkOtxCvNvgEtYJhHLldkg64fSo56Dqfda5jX1IeA0WMV+CtMRCrIRIjLAWwju8ZN5FopMEIQ== X-Received: by 2002:a05:600c:444d:b0:46e:32d4:46a1 with SMTP id 5b1f17b1804b1-47d7f09ca36mr23148085e9.22.1767686237184; Mon, 05 Jan 2026 23:57:17 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d7f65d9f0sm28518895e9.12.2026.01.05.23.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 23:57:16 -0800 (PST) Date: Tue, 6 Jan 2026 02:57:14 -0500 From: "Michael S. Tsirkin" To: Hillf Danton Cc: syzbot , eperezma@redhat.com, jasowang@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com, virtualization@lists.linux.dev Subject: Re: [syzbot] INFO: task hung in vhost_worker_killed (2) Message-ID: <20260106024033-mutt-send-email-mst@kernel.org> References: <695b796e.050a0220.1c9965.002a.GAE@google.com> <20260106014632.2007-1-hdanton@sina.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260106014632.2007-1-hdanton@sina.com> On Tue, Jan 06, 2026 at 09:46:30AM +0800, Hillf Danton wrote: > > taking vq mutex in a kill handler is probably not wise. > > we should have a separate lock just for handling worker > > assignment. > > > Better not before showing us the root cause of the hung to > avoid adding a blind lock. Well I think it's pretty clear but the issue is that just another lock is not enough, we have bigger problems with this mutex. It's held around userspace accesses so if the vhost thread gets into uninterruptible sleep holding that, a userspace thread trying to take it with mutex_lock will be uninterruptible. So it propagates the uninterruptible status between vhost and a userspace thread. It's not a new issue but the new(ish) thread management APIs make it more visible. Here it's the kill handler that got hung but it's not really limited to that, any ioctl can do that, and I do not want to add another lock on data path. -- MST