From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 965E732938A for ; Tue, 6 Jan 2026 14:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767711118; cv=none; b=bbhTpzfBB51dPai0GpSdvmI00/XsilWFREjIjvOY07oj4U0lvYLuMTULR0fsPiNyO2cE4QZjmjN+fQEhyeHNGJCqqZtKP3PLlFX513I9cU4Dn8qjj8tM4agUZUi97pVA/CV4hgSnBUiXsjNpvMmHzS7gJuRHLy7H0tVMcGHjWCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767711118; c=relaxed/simple; bh=OtGN4S8+ZWGuAfn6+2YZp7eQlkz7c6TNLgozVUvUCR0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nTjHeGJYQVUtWKX3FWjojlR+1dV1bOZBZLUcSdYCd04BapyYPZW+Rd8x7xSGn5c6o/UYETiZFCq1IPEl2KWP2nj6cm9/a8vWc/3NFgd9Q46s0nkThfMjAvphyUsoFpdlnhORV5WrylaSqzbENPrGlbHwTrb9sYWNEgoW3fDMAm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y84Qqx31; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qK2Qsck7; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y84Qqx31"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qK2Qsck7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767711115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v8xGpc9e0AHSzqXJdY4dTy2UmvNhNHIufeUOIUm/LzQ=; b=Y84Qqx31I5wMPYwVs5CMOtq8M+c9qrucIU9n78Lo2w7B1rM14bdeV9HFLtzww6UMT+cZAQ Xa+pSSgZVYvA9JqOmVb0NO3ye1HGgHrgVnPVBbjaKLw4jsswsfgAoh++WDRZYDf/XJrx5E 0KBNtav4ZrPKrqi8dPU21J4JDgFZdZY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-232-zIyVX-nZMdKDDHXJ4sARHg-1; Tue, 06 Jan 2026 09:51:54 -0500 X-MC-Unique: zIyVX-nZMdKDDHXJ4sARHg-1 X-Mimecast-MFC-AGG-ID: zIyVX-nZMdKDDHXJ4sARHg_1767711113 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-430f4609e80so488369f8f.3 for ; Tue, 06 Jan 2026 06:51:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767711113; x=1768315913; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=v8xGpc9e0AHSzqXJdY4dTy2UmvNhNHIufeUOIUm/LzQ=; b=qK2Qsck7SHm9l9amUCXbzXhfGTo51UVsXNbEZWwSCLJfQXjy/yearpLDEmbyjchBx3 hqhWOgytwsbrcuTkzheHIooAPrAx0r8uBW99mKgl3syzJbQ1Uroo9/ZcN1TaFy6qwmcl 4uEBoR7wXUurjniTTPFPG2rXVNX9KN/zEIrR5jvwof3WqR5H7sAam1ZlJ5mRYgtJpbeg LkRFawlvMm3iDJLrFjZw4MAklUCWcN3wlf1SPrXdeD69a8PtrzaseIL/uuBqJDtlBc6w wS2Za2/DaHS4x1grRwTIkCVRN/uwgSn4J+imtwI4VQQiMTOshfIn8/rvWEN9wux9yAg6 KDpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767711113; x=1768315913; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v8xGpc9e0AHSzqXJdY4dTy2UmvNhNHIufeUOIUm/LzQ=; b=tNaC8t+NI+NTXGZ/aohsvuPLRI9moeFQCrAILf4uxhCW52n4xOhvw1OlyoZf5sbcsu GXQ1DeJjBZQngms4gI32xLrAmgTzFvTZxzK8WYmSb4pc5c/elWwAkeLSma7yd7Z61ncM sr7dM3OtYevEDTdY7mR9AgUIpKvJQRpY13cVNVDqf7dUf2F+ozzz63sbzvF2/lMmsZr3 FGeCiHG4JFIdxFRxoENQMbQAXqyJpEuKPINDDiXjuJw8WEn0frbbQNKXoCqFCvkMDfLV i8JlC1SMGY3TmTTfHJzPNf4Cwaxcqj3AEyVN5oZg9oc7KNNkPMv7RKr9qACs0foIoKHh KzMA== X-Gm-Message-State: AOJu0YwDoICitD4KTOXXyy2xyC8RTYxCcgX0T1xwu28q7U1V0XQDsO7j bcPN22E7mz3HxPkuj8TquNQJoSTIKF6t3WQrXKnxPJ2NPgSwjG3jVNoq7h1XcymgpWspgdl1qqL 1ViGHjcXB2ifnzqjokdkPot29rqX+nI84lPAeHv0FXCCOhIcrK2PjmagtixUimUAl1Q== X-Gm-Gg: AY/fxX4mbFiXbC/7w66Jffsk/26MfAbGTrf5wpdJX6yejv1UOoeBHOvm0VPp36ozWWd zeTi211X9jW5MpdIHFGvlSCfTdin+Y1dUEcxPpIkogmEl/vPb1I3/eCXdv9oV/Y2SW5/zHRS7ef /jOCa9XA52vxKN0yNg040MRzSkneiqhhimXV9uWlNVe1dgM2swsNFiifNfVYn+hc4GIOIxlV0/1 Lw5Zl6a1Myr3nzxtgzE+ANSlR6gBApuTs8f2Dh2pfIEeH7dYn/gi2GJ6CJv6YHDqVk3IrkB8Yye zn759UXUjFkpgU3sZ/uCM0biHV5hRkWv2qcQz3oV5y9m2lZ/F8hK7yy7kkGWdHCVIExLtbyWbFP 0gsUhIGwJ7MK98bW+RzEdsELplTbLjABeqw== X-Received: by 2002:a05:6000:200f:b0:431:b6e:8be3 with SMTP id ffacd0b85a97d-432bc9f6dccmr4753197f8f.38.1767711112117; Tue, 06 Jan 2026 06:51:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOynDA9QP29UwN/sUhG6OCzOdNXrD0Y6rHdaimQHcJZW2G3EKin+vfxrhBk6BDORYTgSmwkg== X-Received: by 2002:a05:6000:200f:b0:431:b6e:8be3 with SMTP id ffacd0b85a97d-432bc9f6dccmr4753140f8f.38.1767711111656; Tue, 06 Jan 2026 06:51:51 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd5ede7esm4752453f8f.32.2026.01.06.06.51.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 06:51:51 -0800 (PST) Date: Tue, 6 Jan 2026 09:51:46 -0500 From: "Michael S. Tsirkin" To: Stefan Hajnoczi Cc: linux-kernel@vger.kernel.org, Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Eugenio =?iso-8859-1?Q?P=E9rez?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Petr Tesarik , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2 10/15] virtio_scsi: fix DMA cacheline issues for events Message-ID: <20260106095044-mutt-send-email-mst@kernel.org> References: <8801aeef7576a155299f19b6887682dd3a272aba.1767601130.git.mst@redhat.com> <20260105181939.GA59391@fedora> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260105181939.GA59391@fedora> On Mon, Jan 05, 2026 at 01:19:39PM -0500, Stefan Hajnoczi wrote: > On Mon, Jan 05, 2026 at 03:23:29AM -0500, Michael S. Tsirkin wrote: > > @@ -61,7 +62,7 @@ struct virtio_scsi_cmd { > > > > struct virtio_scsi_event_node { > > struct virtio_scsi *vscsi; > > - struct virtio_scsi_event event; > > + struct virtio_scsi_event *event; > > struct work_struct work; > > }; > > > > @@ -89,6 +90,11 @@ struct virtio_scsi { > > > > struct virtio_scsi_vq ctrl_vq; > > struct virtio_scsi_vq event_vq; > > + > > + __dma_from_device_group_begin(); > > + struct virtio_scsi_event events[VIRTIO_SCSI_EVENT_LEN]; > > + __dma_from_device_group_end(); > > If the device emits two events in rapid succession, could the CPU see > stale data for the second event because it already holds the cache line > for reading the first event? > > In other words, it's not obvious to me that the DMA warnings are indeed > spurious and should be silenced here. > > It seems safer and simpler to align and pad the struct virtio_scsi_event > field in struct virtio_scsi_event_node rather than packing these structs > into a single array here they might share cache lines. > > Stefan To add to what I wrote, that's a lot of overhead: 8 * 128 - about 1K on some platforms, and these happen to be low end ones. -- MST