public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ionut Nechita (Sunlight Linux)" <sunlightlinux@gmail.com>
To: Jiri Kosina <jikos@kernel.org>,
	Benjamin Tissoires <bentiss@kernel.org>,
	Mario Limonciello <superm1@kernel.org>,
	Ionut Nechita <ionut_n2001@yahoo.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/1] HID: asus: Add ROG laptop HID code filtering and fan control
Date: Tue,  6 Jan 2026 16:04:50 +0200	[thread overview]
Message-ID: <20260106140449.90506-3-sunlightlinux@gmail.com> (raw)

From: Ionut Nechita <ionut_n2001@yahoo.com>

Hi,

This patch addresses two issues with Asus ROG G14/G15 laptops:

1. Kernel log spam from unmapped HID vendor codes
2. Non-functional Fn+F5 fan control key

Problem:
--------
Asus ROG G14 and G15 laptops send several HID vendor usage codes (0xea,
0xec, 0x02, 0x8a, 0x9e) during normal keypresses with no clear purpose.
This generates continuous "Unmapped Asus vendor usagepage code" warnings
in dmesg, cluttering the kernel log.

Additionally, the Fn+F5 key (code 0xae) which should cycle through fan
modes is not handled, preventing users from controlling fan behavior
through the keyboard shortcut.

Solution:
---------
- Filter out the spurious HID codes for ROG N-Key keyboards to eliminate
  log spam
- Add asus_wmi_send_event() function to enable communication between
  hid-asus and asus-wmi drivers
- Implement Fn+F5 (0xae) handler that triggers WMI events to toggle fan
  modes
- Replace magic number with HID_UP_ASUSVENDOR constant for clarity

Testing:
--------
Tested on Asus ROG G14 (2021) and G15 (2022) models:
- Kernel log no longer shows unmapped vendor code warnings
- Fn+F5 key now cycles through fan modes (silent/balanced/performance)
- No regressions observed with other keyboard functionality

Impact:
-------
Affects Asus ROG laptop users who experience:
- Cluttered kernel logs from HID warnings
- Non-functional fan control hotkey

Ionut Nechita (1):
  HID: asus: Filter HID vendor codes and add WMI fan control support
    for ROG laptops

 drivers/hid/hid-asus.c                     | 48 +++++++++++++++++++++-
 include/linux/platform_data/x86/asus-wmi.h |  2 +
 2 files changed, 49 insertions(+), 1 deletion(-)

--
2.52.0


             reply	other threads:[~2026-01-06 14:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-06 14:04 Ionut Nechita (Sunlight Linux) [this message]
2026-01-06 14:04 ` [PATCH] HID: asus: Filter HID vendor codes and add WMI fan control support for ROG laptops Ionut Nechita (Sunlight Linux)
2026-01-06 16:18   ` Mario Limonciello (AMD) (kernel.org)
2026-01-07 11:19     ` [PATCH v2 0/4] HID: asus: Filter HID codes and add WMI fan control " Ionut Nechita (Sunlight Linux)
2026-01-07 11:19       ` [PATCH 1/4] HID: asus: Replace magic number with HID_UP_ASUSVENDOR constant Ionut Nechita (Sunlight Linux)
2026-01-07 13:00         ` Denis Benato
2026-01-07 15:13           ` Mario Limonciello
2026-01-07 11:19       ` [PATCH 2/4] HID: asus: Filter spurious HID vendor codes on ROG laptops Ionut Nechita (Sunlight Linux)
2026-01-07 13:02         ` Denis Benato
2026-01-07 15:12         ` Mario Limonciello
2026-01-07 11:19       ` [PATCH 3/4] HID: asus: Add WMI communication infrastructure Ionut Nechita (Sunlight Linux)
2026-01-07 13:07         ` Denis Benato
2026-01-07 15:14           ` Mario Limonciello
2026-01-07 15:20             ` Denis Benato
2026-01-07 11:19       ` [PATCH 4/4] HID: asus: Implement Fn+F5 fan control key handler Ionut Nechita (Sunlight Linux)
2026-01-07 13:10         ` Denis Benato
2026-01-07 13:00       ` [PATCH v2 0/4] HID: asus: Filter HID codes and add WMI fan control for ROG laptops Denis Benato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260106140449.90506-3-sunlightlinux@gmail.com \
    --to=sunlightlinux@gmail.com \
    --cc=bentiss@kernel.org \
    --cc=ionut_n2001@yahoo.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=superm1@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox