From: Sean Anderson <sean.anderson@linux.dev>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Cc: Simona Vetter <simona@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>,
linux-arm-kernel@lists.infradead.org,
Michal Simek <michal.simek@amd.com>,
Anatoliy Klymenko <anatoliy.klymenko@amd.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Mike Looijmans <mike.looijmans@topic.nl>,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH v2 2/4] drm: zynqmp: Check property creation status
Date: Tue, 6 Jan 2026 11:42:45 -0500 [thread overview]
Message-ID: <20260106164247.472544-3-sean.anderson@linux.dev> (raw)
In-Reply-To: <20260106164247.472544-1-sean.anderson@linux.dev>
Make sure to return an error in the event that we can't create our
properties.
Fixes: 650f12042b85 ("drm: xlnx: zynqmp_dpsub: Add global alpha support")
Fixes: 8c772f0b2b8e ("drm: xlnx: zynqmp_dpsub: Expose plane ordering to userspace")
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
Reviewed-by: Anatoliy Klymenko <anatoliy.klymenko@amd.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
---
(no changes since v1)
drivers/gpu/drm/xlnx/zynqmp_kms.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c
index 02f3a7d78cf8..816bea4ea986 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_kms.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c
@@ -175,9 +175,15 @@ static int zynqmp_dpsub_create_planes(struct zynqmp_dpsub *dpsub)
drm_plane_helper_add(plane, &zynqmp_dpsub_plane_helper_funcs);
- drm_plane_create_zpos_immutable_property(plane, i);
- if (i == ZYNQMP_DPSUB_LAYER_GFX)
- drm_plane_create_alpha_property(plane);
+ ret = drm_plane_create_zpos_immutable_property(plane, i);
+ if (ret)
+ return ret;
+
+ if (i == ZYNQMP_DPSUB_LAYER_GFX) {
+ ret = drm_plane_create_alpha_property(plane);
+ if (ret)
+ return ret;
+ }
}
return 0;
--
2.35.1.1320.gc452695387.dirty
next prev parent reply other threads:[~2026-01-06 16:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 16:42 [PATCH v2 0/4] drm: zynqmp: Make the video plane primary Sean Anderson
2026-01-06 16:42 ` [PATCH v2 1/4] drm/drm_blend: Allow specifying blend mode default Sean Anderson
2026-01-06 16:42 ` Sean Anderson [this message]
2026-01-06 16:42 ` [PATCH v2 3/4] drm: zynqmp: Make the video plane primary Sean Anderson
2026-01-06 16:42 ` [PATCH v2 4/4] drm: zynqmp: Add blend mode property to graphics plane Sean Anderson
2026-01-22 13:48 ` [PATCH v2 0/4] drm: zynqmp: Make the video plane primary Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260106164247.472544-3-sean.anderson@linux.dev \
--to=sean.anderson@linux.dev \
--cc=airlied@gmail.com \
--cc=anatoliy.klymenko@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mike.looijmans@topic.nl \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox