From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E69827877F for ; Wed, 7 Jan 2026 08:29:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767774566; cv=none; b=ufjD/fbKAhI4dPt3x7/4meteGlzhA7FZ6/wuKNUWeztf8M2UuiTPf8rhEa35IYKtFZW43qPY5cgUj62rm656Xj6uXiIeyaQsnBGRZh9FJ5TT4yFu3tn8tnsxpntOwwZttZBMYbTRjKZq84zf/uxlyHpRaPdTet0vRUU2Yic3Uag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767774566; c=relaxed/simple; bh=Mg00K9PwbyrkiuHwFuf0JzVO3VWZFdCmsSSxAkDeO/U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pmez+J+WJK44Hu24H47GOBqepP6DbSK5e2okmaWW8Npk6evqYZ+jRuG8dDwauV69dzrFANfgcKACD+Oz6yGGOieV1DnChY0yUK5e1IGtOAmlHkAYNJP6WX14fSetGb3lEa6q36Tw1o8F+Ekwc6KwoxT1VyCAYiIPtCxBG9zo4yY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=S4cFPih+; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=lUzZC1qc; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S4cFPih+"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="lUzZC1qc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767774561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cunsvOyBEpA2jF2JmeSIYeJboZyz9iSoN1/dk/+Kvfw=; b=S4cFPih+IQ+xSe394cTCLlJxV7Z4Lidfzh/MHce0eC1lSAldEdpn18FLflMSpuxFxiecLD sM52gCOSxcBQy+lDv8Wa/r4ju+7duq4FEkR9sPlzhVMnR6tQMaFRUwwo6hS4txgtPTmhBP YkcKTpWq5nG+dkNXThS7TkUyX8SqiUk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-511-fRLPPOTEMRGswVeieM2xjQ-1; Wed, 07 Jan 2026 03:28:10 -0500 X-MC-Unique: fRLPPOTEMRGswVeieM2xjQ-1 X-Mimecast-MFC-AGG-ID: fRLPPOTEMRGswVeieM2xjQ_1767774490 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-47d5c7a2f5dso14773425e9.2 for ; Wed, 07 Jan 2026 00:28:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767774489; x=1768379289; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cunsvOyBEpA2jF2JmeSIYeJboZyz9iSoN1/dk/+Kvfw=; b=lUzZC1qc5IrPo+gs8ileoyOQ1gKGKaBYmyPVZtzm4wWI7ZvpNJHCbIvESzvb/6Z8V+ 49GAraZ8zTBr0fqE8qggdfI1DfWuwETkXj1st2FQm9UI3+/gHkta7aTjC1s2mL1+V57A pQUp53CJsaEYopLq8f8MO8cC9lnP6UweLh8YyrdZYwb6Kbt9p7TL4sR8fuH2BdS7wN8w OdATJ938+ogsCulb0OKiV12gHvzBexeCOUiMdVlwOv0DowtS3eHzpKiouD3AU8dwIU9w E2zJBs/WkqqkzJ6UIVLNayXUnqL5zCrd2hUEdZcBPpdJeH+Pd92AI/3OBItb5blRVwgS BK4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767774489; x=1768379289; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cunsvOyBEpA2jF2JmeSIYeJboZyz9iSoN1/dk/+Kvfw=; b=gK0jxpL2lmIXuliWIDnwCLwKMhUlPixkFe/W2nFYaoCgKnO/YmIW+R13AY9+fmS6p7 1n9/KXqXmIUOGcUH1ysQ2QDCce507AMMtQ+JaxBLtnsu9EBfhqtOPNZpMxBaqZSr8JYP kZh0rIXW/Z/p8tM1ZpjtbwznpkjlVlE1HpYtOfoxbLH1QuG2TdsetPgBTWJz2KJufCtw 5ZKe/a6J/6xOO6xnlUsn4Cg8reVt/A8YpzZDp81FXZ6q4VezX8C2afdfb9O+rkj8oG69 BHYmoo2VM6qFHwaqlJmmkDT71Q1sHZOEjRwbhao2TRpsj3C7yFjqqTkCPXB9Sn6nMtb0 oMAQ== X-Forwarded-Encrypted: i=1; AJvYcCVC0f9/bMcUPCuqNFP3wMPWPV+WTavMZJBzisQTpcSQZM9Q4duAx8JIMZc+/TLYBhoohKYl8GZvMpiFM+0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0XR8/q2NSrVQoUsqO42zVGIcClUuC81nMStGe0v3HVdlsP+g0 JL+XdueKWxDsChJ4j25VUjMVVoe9kEIQ9fx4StGrmCS8nHNorkKIqGU12bgGrJq7uHvek7xZjV/ XeynQqaSk6vozbQWx72gvCyoYrTBHZrGO2LqGZE+d40Sm35z55e4gsr8rN23xsZLQyQ== X-Gm-Gg: AY/fxX7eCygyW7qjpsnVe9/hNAHeDlqSXd6FptOxuP/7Lvw7x281CLGIL1RqlKvF5dx wbd0jTElann/h/e/Xr355gAAwezQCDbdxJ+ya1nAEE6iw7SzZpyIFkWzMxJK8MPgMMj2NnrWZNc q5KXEP9nr9zsgA2jJBfkQf0FFF3RdZLw/ZurgZ3qFk6RAs+NVWSSoabCEvf++jyTM82VoG911lo vBFoW4Zy+QqthOHd5zYnwPs/HtPWJxJC4GePbtezorVkZClerPaWQbolWqYfBmhmwiCGuqIeHR6 +rvBaYyt8hnn2fpVP7AojwFB/6x/6RiEc9PJOBpY+ZG16YE2mKeFuvFC9nKU9VYUiMm5S4LSyxS RKlDFloMKJmZySElnLX9Gk5SsVLFFb7cBYw== X-Received: by 2002:a05:600c:1d0a:b0:477:8b77:155e with SMTP id 5b1f17b1804b1-47d84b17b55mr17590635e9.15.1767774489510; Wed, 07 Jan 2026 00:28:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfTqFw1RFyOrDz3FTYetJ0O3Wwz0Nw74F1etDtvhfpLP8L/Oa0ngtxX/fuOMspIpUKEWiHKw== X-Received: by 2002:a05:600c:1d0a:b0:477:8b77:155e with SMTP id 5b1f17b1804b1-47d84b17b55mr17590255e9.15.1767774488997; Wed, 07 Jan 2026 00:28:08 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8636cb0dsm9019575e9.0.2026.01.07.00.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 00:28:08 -0800 (PST) Date: Wed, 7 Jan 2026 03:28:05 -0500 From: "Michael S. Tsirkin" To: Vishwanath Seshagiri Cc: Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Wei , netdev@vger.kernel.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] virtio_net: add page_pool support Message-ID: <20260107032738-mutt-send-email-mst@kernel.org> References: <20260106221924.123856-1-vishs@meta.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260106221924.123856-1-vishs@meta.com> On Tue, Jan 06, 2026 at 02:19:22PM -0800, Vishwanath Seshagiri wrote: > Introduce page_pool support in virtio_net driver in order to recycle > pages in RX buffer allocation and avoid reallocating through the page > allocator. This applies to mergeable and small buffer modes. > > The patch has been tested using the included selftests and additional > edge case scripts covering device unbind/bind cycles, rapid interface > open/close, traffic during close, ethtool stress with feature toggling, > close with pending refill work, and data integrity verification. Yay! thanks for working on this! Could you share perf data please? After all, page pool is an optimization. > Vishwanath Seshagiri (2): > virtio_net: add page pool support for buffer allocation > selftests: virtio_net: add buffer circulation test > > drivers/net/virtio_net.c | 246 +++++++++++++++--- > .../drivers/net/virtio_net/basic_features.sh | 70 +++++ > 2 files changed, 275 insertions(+), 41 deletions(-) > > -- > 2.47.3