From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A895629CE9 for ; Wed, 7 Jan 2026 03:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767756638; cv=none; b=aaLKfj4MlwGICHmGzhP0PjaTIPCBTFNc98OhLJyyaUZVRHE4am3zsJnBO+GaLDQUVo26xTpCdOWnZP3jIiRLW12fbvRz7mpETHo66/mUBO0sjIhdba94L8qEJW4e3iGARCiK5jJZ6es5MeaKJciQFaZSr91pIX5osH22NyF0hNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767756638; c=relaxed/simple; bh=XgHCoPvK3XE9D7QOWwmpJCKIKXSiFeDufODLWy7W/ck=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VWXSnY3NQgxRsPsY4B09tCtqNsMarSAV1Mb/YemChuLg42ns2dcDvEoVbVrhnygUKFnqgGWr7+1bLtYhvUnHbxOuDwvdAONnMNDq6Ak4+UaAYw5UXVHPx6eMbpDKPOR9vmqNk1LuUPJAWSfvw6teZER1lHvCMaQk6fQUkvaET5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l9Z+TiI2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l9Z+TiI2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8B60C4CEF7; Wed, 7 Jan 2026 03:30:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767756638; bh=XgHCoPvK3XE9D7QOWwmpJCKIKXSiFeDufODLWy7W/ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l9Z+TiI265Gxn65bnr2dJM0OByHyuObK0MWt3wcTJKBQ6bVevx1UCB+Lk/ZTS8T8X rk0WYfdePqv/Xub2mLg2xD6w1k5fMivMft2JBfbsAwI4E/CejyZocrI1J7tnRBKVd5 SKglQmbftUW/Y53ueia8xoiLfrIiXpIZDIAr07Gn0OSqGnCvnyjlZ6W8uhyP2+z6Ql QJAkX00nacdQBpUAUHqk7QIcUPCpznag8vYV5XUl179/0L/BnZlQhj9j+xEyADIM7/ Ntezm79Gxcc/ha7dPb0Z3iXYGeaVfaVMYR1cRiVqpjYqdkJgtdvixFocLKYY3kQm20 I8kgE2IozL7ew== Date: Tue, 6 Jan 2026 19:30:18 -0800 From: Eric Biggers To: Jie Zhan Cc: ardb@kernel.org, dhowells@redhat.com, linux-kernel@vger.kernel.org, linuxarm@huawei.com, jonathan.cameron@huawei.com Subject: Re: [PATCH] lib/crypto: tests: Fix syntax error for old python versions Message-ID: <20260107033018.GA2283@sol> References: <20260107015829.2000699-1-zhanjie9@hisilicon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260107015829.2000699-1-zhanjie9@hisilicon.com> On Wed, Jan 07, 2026 at 09:58:29AM +0800, Jie Zhan wrote: > 'make binrpm-pkg' throws me this error, with Python 3.9: > > *** Error compiling '.../gen-hash-testvecs.py'... > File ".../scripts/crypto/gen-hash-testvecs.py", line 121 > return f'{alg.upper().replace('-', '_')}_DIGEST_SIZE' > ^ > SyntaxError: f-string: unmatched '(' > > Old python versions, presumably <= 3.11, can't resolve these quotes. > > Fix it with double quotes for compatibility. > > Fixes: 15c64c47e484 ("lib/crypto: tests: Add SHA3 kunit tests") > Signed-off-by: Jie Zhan > --- > scripts/crypto/gen-hash-testvecs.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I'll apply this, but it's weird that 'make binrpm-pkg' is doing anything with this script. It's not executed during the kernel build process. It's only run manually to generate some files that are checked in elsewhere in the tree. - Eric