From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D9862D29AA for ; Wed, 7 Jan 2026 03:48:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767757728; cv=none; b=B2ZoQr5DkR4vlDHhqYOd1I3c6BVZv339oDb1EDrOaSR2gWJDdu2f0krOebvLaMxIiUoViGuNX5sEshQDTd18mihOL8ByfdyuLwak9RYu5JIz3R4k6pSa+/yLREMYAlF4v50TDHhPT9pmyxtigqmGh94g5Y0p+Vo7dmTNXHAHiCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767757728; c=relaxed/simple; bh=7b6FVIVpJo+xA4SNmeOUyxog3DMDCGrnHY6W6wXIjPI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZzYzHPULg9Xm4ZsC48YN+TUFV8dwTDwfEWbmxC7nurPup7TuBur5j/OciS346f0QFhT2MeT5A9gB4dH5AeEaNFahmFeUewhXEg7UiB+eDqMY/QERRohsDqGfKlIsZ2sR8sjzJbtbhNZyaTUNiuTi+AZiY8i6XOusbGCi1+/NvT0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iuyPj14X; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iuyPj14X" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2ae61424095so982242eec.1 for ; Tue, 06 Jan 2026 19:48:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767757726; x=1768362526; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lVfOOsMtVesahSpJ7NzEZB2a7bFJ+2QiFmRNgCZu9gM=; b=iuyPj14XKkoWH9MWkyK+ItoYjysm2xwZQnqd3XHofHxkQDmMGac9oSzcLBYDBeqLtz rM7Y05s+Vp6JPcTNmWjefnB/fGHoe5JvPk4EfglNeWSJ2uMUZ3hNg2M4jQmaQCVwWHwp PGn3RUeyEAQNdEzO2/KVXwyL7JmHDrVE+K0Ku6AXrcedu6MmC7f7MYeRluE5+IoOQ0gE M3aTso69uZ2l50bovlSz+mHhtXJXkrK/nwTmuyToO6Vm0V7sg7wCAM2ZIhjKOUJrY95g RPMB5Gryt3l8LxiQDX/ReWMNTbZuoWRjqyfyqMQEanatzzhStz8WxxAuXQT6R1EpDCLR 8CwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767757726; x=1768362526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lVfOOsMtVesahSpJ7NzEZB2a7bFJ+2QiFmRNgCZu9gM=; b=o7AMHqiVLb2WmFtDaJdHxc3aZNtjhG2F8wEDY4uBN09FLmTkrbMa3foxueGpBcqE/G Uv77b5Il6GNSSuF2C2nU07dD9lmJ/MmfxwJRbfdMkcRtIRXfwvBf1oIdYhgyiK2jxSW6 UiXjoMog/y3lvXF6eSN+zn7PUgbzGqn65MF1jAV/QdSCF1z6xxlWFiR4OvJol8arjo51 xeBy7zks4paxC+4lFeT3pYX7wiA2aho0uMOD5LpoHZsO0Ny40w+Hu7R+7Vko4ru0wbs+ kLb/T/KI9BEzDxYuAOwkcyUMUecyWGqc1Zkr3k3d8XNJm2DIPAvYYIFWqcs5NAj4Ov/p EFMQ== X-Forwarded-Encrypted: i=1; AJvYcCWcQ01iUV9FE5i0S3Ymud+zz9C6kPnG5QrV//EQo8pAVt8qxIPaFwXuN+8w92WKIRhKi1zCYqghFHl8X/0=@vger.kernel.org X-Gm-Message-State: AOJu0YyaMbK9wJDpEDGy01SJ0ujiFILtOeqd7oDiNDS9NMTLHp+nHn2P MiYDSJEltYdixpLHCztlrXp6Alap9g4oPUy1xcHpWePehkGog+2ndcI5 X-Gm-Gg: AY/fxX7omh4A+Gwrp4yWgmIbjOHGBR1K3Vu7GvUZrNBklkQ4DPYVJ0v0MDuxmPHNlcV vGEz0/uZ2yUdW0piJTkRphvZ7+jWH3PRH6T/wHsP/t49tk1YV/d6JrlHInxlS3vDL9aZyb/+o+f pd6eudmvGmob/vB/qfuImdW9JkFIJe3vYIQsxMiynak/xDH8gwHwzCLm4EbodTDftVKus7l0QIf ktg2l+q0dKnjOE4fL53JKOOV2FIztPSrHDIORxeOsoLOSx6ZayoYTAEZCCkixnqu9iMxNueRqdy Lz1M7zYtDb3lT2au52ccngC48l4oD0pwxjzSiY1SnGJLg99ZHKEyaxWGadEW2rqy77LCil+Lnxp lnGIGFkCZC+AMfDgcHtYqqGn/puldlw1Re1mi8kegaGO2VjluAx94BfrK/lY2wtA= X-Google-Smtp-Source: AGHT+IH/ZbpZvf+ufhdSrgq15FQAA5DMOGdsUeBWMvuc3LZNVn+XAns8eGMqcOV8TZ1Q54ktkq+I7A== X-Received: by 2002:a05:7301:578d:b0:2a4:3593:c7c5 with SMTP id 5a478bee46e88-2b17d1f058bmr978905eec.5.1767757725777; Tue, 06 Jan 2026 19:48:45 -0800 (PST) Received: from gmail.com ([2a09:bac5:1f0d:28::4:33f]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b1707b2256sm5392191eec.25.2026.01.06.19.48.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 19:48:45 -0800 (PST) From: Qingfang Deng To: Eric Biggers Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, Ard Biesheuvel , "Jason A. Donenfeld" , Herbert Xu , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, Holger Dengler , Harald Freudenberger Subject: Re: [PATCH 30/36] crypto: inside-secure - Use new AES library API Date: Wed, 7 Jan 2026 11:48:33 +0800 Message-ID: <20260107034834.1447-1-dqfext@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260105051311.1607207-31-ebiggers@kernel.org> References: <20260105051311.1607207-1-ebiggers@kernel.org> <20260105051311.1607207-31-ebiggers@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, 4 Jan 2026 21:13:03 -0800, Eric Biggers wrote: > --- a/drivers/crypto/inside-secure/safexcel_cipher.c > +++ b/drivers/crypto/inside-secure/safexcel_cipher.c > @@ -2505,37 +2505,35 @@ static int safexcel_aead_gcm_setkey(struct crypto_aead *ctfm, const u8 *key, > unsigned int len) > { > struct crypto_tfm *tfm = crypto_aead_tfm(ctfm); > struct safexcel_cipher_ctx *ctx = crypto_tfm_ctx(tfm); > struct safexcel_crypto_priv *priv = ctx->base.priv; > - struct crypto_aes_ctx aes; > + struct aes_enckey aes; > u32 hashkey[AES_BLOCK_SIZE >> 2]; > int ret, i; > > - ret = aes_expandkey(&aes, key, len); > - if (ret) { > - memzero_explicit(&aes, sizeof(aes)); > + ret = aes_prepareenckey(&aes, key, len); > + if (ret) > return ret; > - } > > if (priv->flags & EIP197_TRC_CACHE && ctx->base.ctxr_dma) { > for (i = 0; i < len / sizeof(u32); i++) { > - if (le32_to_cpu(ctx->key[i]) != aes.key_enc[i]) { > + if (ctx->key[i] != get_unaligned((__le32 *)key + i)) { "key" is big-endian. Casting it to __le32 does not seem correct. Did you mean "get_unaligned_le32", which also convert the endianness? > ctx->base.needs_inv = true; > break; > } > } > } > > for (i = 0; i < len / sizeof(u32); i++) > - ctx->key[i] = cpu_to_le32(aes.key_enc[i]); > + ctx->key[i] = get_unaligned((__le32 *)key + i); Same here. > > ctx->key_len = len; > > /* Compute hash key by encrypting zeroes with cipher key */ > memset(hashkey, 0, AES_BLOCK_SIZE); > - aes_encrypt(&aes, (u8 *)hashkey, (u8 *)hashkey); > + aes_encrypt_new(&aes, (u8 *)hashkey, (u8 *)hashkey); > > if (priv->flags & EIP197_TRC_CACHE && ctx->base.ctxr_dma) { > for (i = 0; i < AES_BLOCK_SIZE / sizeof(u32); i++) { > if (be32_to_cpu(ctx->base.ipad.be[i]) != hashkey[i]) { > ctx->base.needs_inv = true;