* [PATCH] fs/ntfs3: make ntfs_writeback_ops static
@ 2026-01-07 7:37 sunliming
2026-01-16 13:42 ` Konstantin Komarov
0 siblings, 1 reply; 2+ messages in thread
From: sunliming @ 2026-01-07 7:37 UTC (permalink / raw)
To: almaz.alexandrovich; +Cc: ntfs3, linux-kernel, sunliming, kernel test robot
From: sunliming <sunliming@kylinos.cn>
Fix below sparse warnings:
fs/ntfs3/inode.c:972:34: sparse: sparse: symbol 'ntfs_writeback_ops' was not declared.
Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202601061424.nbKLNwC5-lkp@intel.com/
Signed-off-by: sunliming <sunliming@kylinos.cn>
---
fs/ntfs3/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
index b969ad7c3258..636aa77e20e4 100644
--- a/fs/ntfs3/inode.c
+++ b/fs/ntfs3/inode.c
@@ -969,7 +969,7 @@ static ssize_t ntfs_writeback_range(struct iomap_writepage_ctx *wpc,
}
-const struct iomap_writeback_ops ntfs_writeback_ops = {
+static const struct iomap_writeback_ops ntfs_writeback_ops = {
.writeback_range = ntfs_writeback_range,
.writeback_submit = iomap_ioend_writeback_submit,
};
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/ntfs3: make ntfs_writeback_ops static
2026-01-07 7:37 [PATCH] fs/ntfs3: make ntfs_writeback_ops static sunliming
@ 2026-01-16 13:42 ` Konstantin Komarov
0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Komarov @ 2026-01-16 13:42 UTC (permalink / raw)
To: sunliming; +Cc: ntfs3, linux-kernel, sunliming, kernel test robot
On 1/7/26 08:37, sunliming@linux.dev wrote:
> From: sunliming <sunliming@kylinos.cn>
>
> Fix below sparse warnings:
> fs/ntfs3/inode.c:972:34: sparse: sparse: symbol 'ntfs_writeback_ops' was not declared.
> Should it be static?
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202601061424.nbKLNwC5-lkp@intel.com/
> Signed-off-by: sunliming <sunliming@kylinos.cn>
> ---
> fs/ntfs3/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> index b969ad7c3258..636aa77e20e4 100644
> --- a/fs/ntfs3/inode.c
> +++ b/fs/ntfs3/inode.c
> @@ -969,7 +969,7 @@ static ssize_t ntfs_writeback_range(struct iomap_writepage_ctx *wpc,
> }
>
>
> -const struct iomap_writeback_ops ntfs_writeback_ops = {
> +static const struct iomap_writeback_ops ntfs_writeback_ops = {
> .writeback_range = ntfs_writeback_range,
> .writeback_submit = iomap_ioend_writeback_submit,
> };
Applied, will be sent in the next pull request, thanks.
Regards,
Konstantin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-16 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-07 7:37 [PATCH] fs/ntfs3: make ntfs_writeback_ops static sunliming
2026-01-16 13:42 ` Konstantin Komarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox